1452b1275b
Fixes #3168 The Claude Code subagent dispatcher tool is named `Agent` (with `subagent_type` parameter). The `Task*` namespace (TaskCreate, TaskList, TaskGet, TaskUpdate, TaskOutput, TaskStop) is the separate task-tracker. GSD's commands, workflows, and agents were partially migrated and still referenced `- Task` / `Task(` in 55 files, causing orchestrators to silently fall back to inline execution when no `Task` tool appeared on their tool surface. Changes: - `commands/gsd/*.md` allowed-tools: replaced `- Task` with `- Agent` in 24 files; removed duplicate `- Task` from autonomous.md (already had `- Agent`) - `get-shit-done/workflows/*.md`: replaced dispatcher `Task(` → `Agent(` in 29 workflow files (~133 call sites); TaskCreate/List/Get/Update/Output/Stop left untouched - `agents/gsd-debug-session-manager.md`: replaced `Task` → `Agent` in tools frontmatter (the only remaining agent with the wrong name) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
59 lines
2.7 KiB
Markdown
59 lines
2.7 KiB
Markdown
---
|
|
name: gsd:code-review
|
|
description: Review source files changed during a phase for bugs, security issues, and code quality problems
|
|
argument-hint: "<phase-number> [--depth=quick|standard|deep] [--files file1,file2,...] [--fix [--all] [--auto]]"
|
|
allowed-tools:
|
|
- Read
|
|
- Bash
|
|
- Glob
|
|
- Grep
|
|
- Write
|
|
- Agent
|
|
---
|
|
<objective>
|
|
Review source files changed during a phase for bugs, security vulnerabilities, and code quality problems.
|
|
|
|
Spawns the gsd-code-reviewer agent to analyze code at the specified depth level. Produces REVIEW.md artifact in the phase directory with severity-classified findings.
|
|
|
|
Arguments:
|
|
- Phase number (required) — which phase's changes to review (e.g., "2" or "02")
|
|
- `--depth=quick|standard|deep` (optional) — review depth level, overrides workflow.code_review_depth config
|
|
- quick: Pattern-matching only (~2 min)
|
|
- standard: Per-file analysis with language-specific checks (~5-15 min, default)
|
|
- deep: Cross-file analysis including import graphs and call chains (~15-30 min)
|
|
- `--files file1,file2,...` (optional) — explicit comma-separated file list, skips SUMMARY/git scoping (highest precedence for scoping)
|
|
- `--fix` (optional) — after review completes (or if REVIEW.md already exists), auto-apply fixes found. Spawns gsd-code-fixer agent. Accepts sub-flags:
|
|
- `--all` — include Info findings in fix scope (default: Critical + Warning only)
|
|
- `--auto` — enable fix + re-review iteration loop, capped at 3 iterations
|
|
|
|
Output: {padded_phase}-REVIEW.md in phase directory + inline summary of findings
|
|
</objective>
|
|
|
|
<execution_context>
|
|
@~/.claude/get-shit-done/workflows/code-review.md
|
|
</execution_context>
|
|
|
|
<context>
|
|
Phase: $ARGUMENTS (first positional argument is phase number)
|
|
|
|
Optional flags parsed from $ARGUMENTS:
|
|
- `--depth=VALUE` — Depth override (quick|standard|deep). If provided, overrides workflow.code_review_depth config.
|
|
- `--files=file1,file2,...` — Explicit file list override. Has highest precedence for file scoping per D-08. When provided, workflow skips SUMMARY.md extraction and git diff fallback entirely.
|
|
|
|
Context files (CLAUDE.md, SUMMARY.md, phase state) are resolved inside the workflow via `gsd-sdk query init.phase-op` and delegated to agent via `<files_to_read>` blocks.
|
|
</context>
|
|
|
|
<process>
|
|
This command is a thin dispatch layer. It parses arguments and delegates to the workflow.
|
|
|
|
Execute end-to-end.
|
|
|
|
The workflow (not this command) enforces these gates:
|
|
- Phase validation (before config gate)
|
|
- Config gate check (workflow.code_review)
|
|
- File scoping (--files override > SUMMARY.md > git diff fallback)
|
|
- Empty scope check (skip if no files)
|
|
- Agent spawning (gsd-code-reviewer)
|
|
- Result presentation (inline summary + next steps)
|
|
</process>
|