* fix(tests): update 5 source-text tests to read config-schema.cjs VALID_CONFIG_KEYS moved from config.cjs to config-schema.cjs in the drift-prevention companion PR. Tests that read config.cjs source text and checked for key literal includes() now point to the correct file. Closes #2480 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat(workflows): close LEARNINGS.md consumption-and-graduation loop (#2430) Part A — Consumption: extend plan-phase.md cross-phase context load to include LEARNINGS.md files from the 3 most recent prior phases (same recency gate as CONTEXT.md + SUMMARY.md: CONTEXT_WINDOW >= 500000 only). Also loads LEARNINGS.md from any phases in the Depends-on chain. Silent skip if absent; 15% context budget cap with oldest-first truncation; [from Phase N LEARNINGS] attribution. Part B — Graduation: add graduation_scan step to transition.md (after evolve_project) that delegates to new graduation.md helper workflow. The helper clusters recurring items across the last N phases (default window=5, threshold=3) using Jaccard lexical similarity, surfaces HITL Promote/Defer/Dismiss prompts, routes promotions to PROJECT.md or PATTERNS.md by category, annotates graduated items with `graduated:` field, and persists dismissed/deferred clusters in STATE.md graduation_backlog. Always non-blocking; silently no-ops on first phase or when data is insufficient. Also: adds optional `graduated:` annotation docs to extract_learnings.md schema. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(graduation): address CodeRabbit review findings on PR #2490 - graduation.md: unify insufficient-data guard to silent-skip (remove contradictory [no-op] print path) - graduation.md: add TEXT_MODE fallback for HITL cluster prompts - graduation.md: add A (defer-all) to accepted actions [P/D/X/A] - graduation.md: tag untyped code fences with text language (MD040) - transition.md: tag untyped graduation.md fence with text language Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(graduation): rephrase TEXT_MODE line to avoid prompt-injection scanner false positive Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
196 lines
6.9 KiB
Markdown
196 lines
6.9 KiB
Markdown
# graduation.md — LEARNINGS.md Cross-Phase Graduation Helper
|
||
|
||
**Invoked by:** `transition.md` step `graduation_scan`. Never invoked directly by users.
|
||
|
||
This workflow clusters recurring items across the last N phases' LEARNINGS.md files and surfaces promotion candidates to the developer via HITL. No item is promoted without explicit developer approval.
|
||
|
||
---
|
||
|
||
## Configuration
|
||
|
||
Read from project config (`config.json`):
|
||
|
||
| Key | Default | Description |
|
||
|-----|---------|-------------|
|
||
| `features.graduation` | `true` | Master on/off switch. `false` skips silently. |
|
||
| `features.graduation_window` | `5` | How many prior phases to scan |
|
||
| `features.graduation_threshold` | `3` | Minimum cluster size to surface |
|
||
|
||
---
|
||
|
||
## Step 1: Guard Checks
|
||
|
||
```bash
|
||
GRADUATION_ENABLED=$(gsd-sdk query config-get features.graduation 2>/dev/null || echo "true")
|
||
GRADUATION_WINDOW=$(gsd-sdk query config-get features.graduation_window 2>/dev/null || echo "5")
|
||
GRADUATION_THRESHOLD=$(gsd-sdk query config-get features.graduation_threshold 2>/dev/null || echo "3")
|
||
```
|
||
|
||
**Skip silently (print nothing) if:**
|
||
- `features.graduation` is `false`
|
||
- Fewer than `graduation_threshold` completed prior phases exist (not enough data)
|
||
|
||
**Skip silently (print nothing) if total items across all LEARNINGS.md files in the window is fewer than 5.**
|
||
|
||
---
|
||
|
||
## Step 2: Collect LEARNINGS.md Files
|
||
|
||
Find LEARNINGS.md files from the last N completed phases (excluding the phase currently completing):
|
||
|
||
```bash
|
||
find .planning/phases -name "*-LEARNINGS.md" | sort | tail -n "$GRADUATION_WINDOW"
|
||
```
|
||
|
||
For each file found:
|
||
1. Parse the four category sections: `## Decisions`, `## Lessons`, `## Patterns`, `## Surprises`
|
||
2. Extract each `### Item Title` + body as a single item record: `{ category, title, body, source_phase, source_file }`
|
||
3. **Skip items that already contain `**Graduated:**`** — they have been promoted and must not re-surface
|
||
|
||
---
|
||
|
||
## Step 3: Cluster by Lexical Similarity
|
||
|
||
For each category independently, cluster items using Jaccard similarity on tokenized title+body:
|
||
|
||
**Tokenization:** lowercase, strip punctuation, split on whitespace, remove stop words (a, an, the, is, was, in, on, at, to, for, of, and, or, but, with, from, that, this, by, as).
|
||
|
||
**Jaccard similarity:** `|A ∩ B| / |A ∪ B|` where A and B are token sets. Two items are in the same cluster if similarity ≥ 0.25.
|
||
|
||
**Clustering algorithm:** single-pass greedy — process items in phase order; add to the first cluster whose centroid (union of all cluster tokens) has similarity ≥ 0.25 with the new item; otherwise start a new cluster.
|
||
|
||
**Cluster size filter:** only surface clusters with distinct source phases ≥ `graduation_threshold` (not just total items — same item repeated in one phase still counts as 1 distinct phase).
|
||
|
||
---
|
||
|
||
## Step 4: Check graduation_backlog in STATE.md
|
||
|
||
Read `.planning/STATE.md` `graduation_backlog` section (if present). Format:
|
||
|
||
```yaml
|
||
graduation_backlog:
|
||
- cluster_id: "{sha256-of-cluster-title}"
|
||
status: "dismissed" # or "deferred"
|
||
deferred_until: "phase-N" # only for deferred entries
|
||
cluster_title: "{representative title}"
|
||
```
|
||
|
||
**Skip any cluster whose `cluster_id` matches a `dismissed` entry.**
|
||
|
||
**Skip any cluster whose `cluster_id` matches a `deferred` entry where `deferred_until` phase has not yet completed.**
|
||
|
||
---
|
||
|
||
## Step 5: Surface Promotion Candidates
|
||
|
||
For each qualifying cluster, determine the suggested target file:
|
||
|
||
| Category | Suggested Target |
|
||
|----------|-----------------|
|
||
| `decisions` | `PROJECT.md` — append under `## Validated Decisions` (create section if absent) |
|
||
| `patterns` | `PATTERNS.md` — append under the appropriate category section (create file if absent) |
|
||
| `lessons` | `PROJECT.md` — append under `## Invariants` (create section if absent) |
|
||
| `surprises` | Flag for human review — if genuinely surprising 3+ times, something structural is wrong |
|
||
|
||
Print the graduation report:
|
||
|
||
```text
|
||
📚 Graduation scan across phases {M}–{N}:
|
||
|
||
HIGH RECURRENCE ({K}/{WINDOW} phases)
|
||
├─ Cluster: "{representative title}"
|
||
├─ Category: {category}
|
||
├─ Sources: {list of NN-LEARNINGS filenames}
|
||
└─ Suggested target: {target file} § {section}
|
||
|
||
[repeat for each qualifying cluster, ordered HIGH→LOW recurrence]
|
||
|
||
For each cluster above, choose an action:
|
||
P = Promote now D = Defer (re-surface next transition) X = Dismiss (never re-surface) A = Defer all remaining
|
||
```
|
||
|
||
---
|
||
|
||
## Step 6: HITL — Process Each Cluster
|
||
|
||
For each cluster (in order from Step 5), ask the developer:
|
||
|
||
```text
|
||
Cluster: "{title}" [{category}, {K} phases] → {target}
|
||
Action [P/D/X/A]:
|
||
```
|
||
|
||
Use `AskUserQuestion` (or equivalent HITL primitive for the current runtime). If `TEXT_MODE` is true, display the cluster question as plain text and accept typed input. Accept single-character input: `P`, `D`, `X`, `A` (case-insensitive).
|
||
|
||
**On `P` (Promote now):**
|
||
|
||
1. Read the target file (or create it with a standard header if absent)
|
||
2. Append the cluster entry under the suggested section:
|
||
```markdown
|
||
### {Cluster representative title}
|
||
{Merged body — combine unique sentences across cluster items}
|
||
|
||
**Sources:** Phase {A}, Phase {B}, Phase {C}
|
||
**Promoted:** {ISO_DATE}
|
||
```
|
||
3. For each source LEARNINGS.md item in the cluster, append `**Graduated:** {target-file}:{ISO_DATE}` after its last existing field
|
||
4. Commit both the target file and all annotated LEARNINGS.md files in a single atomic commit:
|
||
`docs(learnings): graduate "{cluster title}" to {target-file}`
|
||
|
||
**On `D` (Defer):**
|
||
|
||
Write to `.planning/STATE.md` under `graduation_backlog`:
|
||
```yaml
|
||
- cluster_id: "{sha256}"
|
||
status: "deferred"
|
||
deferred_until: "phase-{NEXT_PHASE_NUMBER}"
|
||
cluster_title: "{title}"
|
||
```
|
||
|
||
**On `X` (Dismiss):**
|
||
|
||
Write to `.planning/STATE.md` under `graduation_backlog`:
|
||
```yaml
|
||
- cluster_id: "{sha256}"
|
||
status: "dismissed"
|
||
cluster_title: "{title}"
|
||
```
|
||
|
||
**On `A` (Defer all):**
|
||
|
||
Defer the current cluster (same as `D`) and skip all remaining clusters for this run, deferring each to the next transition. Print:
|
||
```text
|
||
[graduation: deferred all remaining clusters to next transition]
|
||
```
|
||
Then proceed directly to Step 7.
|
||
|
||
---
|
||
|
||
## Step 7: Completion Report
|
||
|
||
After processing all clusters, print:
|
||
|
||
```text
|
||
Graduation complete: {promoted} promoted, {deferred} deferred, {dismissed} dismissed.
|
||
```
|
||
|
||
If no clusters qualified (all filtered by backlog or threshold), print:
|
||
```text
|
||
[graduation: no qualifying clusters in phases {M}–{N}]
|
||
```
|
||
|
||
---
|
||
|
||
## First-Run Behaviour
|
||
|
||
On the first transition after upgrading to a version that includes this workflow, all extant LEARNINGS.md files may produce a large batch of candidates at once. A `[Defer all]` shorthand is available: if the developer enters `A` at any cluster prompt, all remaining clusters for this run are deferred to the next transition.
|
||
|
||
---
|
||
|
||
## No-Op Conditions (silent skip)
|
||
|
||
- `features.graduation = false`
|
||
- Fewer than `graduation_threshold` prior phases with LEARNINGS.md
|
||
- Total items < 5 across the window
|
||
- All qualifying clusters are in `graduation_backlog` as dismissed
|