* fix(#2973): /gsd-profile-user writes dev-preferences.md to skills/ not legacy commands/gsd/ v1.39.0's install summary claimed the legacy ~/.claude/commands/gsd/ directory had been removed in favor of skills-only architecture, but the cmdGenerateDevPreferences writer at profile-output.cjs:781 still defaulted to the legacy path. Every /gsd-profile-user --refresh deterministically re-created the legacy directory. Missed in PR #1540's migration because dev-preferences is a runtime-generated user artifact, not a GSD-shipped command file. Fix: - Writer default: ~/.claude/skills/gsd-dev-preferences/SKILL.md - profile-user.md Display message + artifact list reference new path - New migrateLegacyDevPreferencesToSkill(targetDir, saved) installer helper. Called at all 5 skills-aware install branches. Copies preserved legacy dev-preferences.md into skills/gsd-dev-preferences/ SKILL.md, but ONLY if no SKILL.md already exists -- never clobbers user-customized skill content. Tests: bug-2973-profile-user-skills-path.test.cjs runs the writer in a subprocess (core.cjs:output uses fs.writeSync(1, ...) which bypasses in-process stubbing), asserts the writer's command_path field is the skills location, the file is on disk at that path, the legacy path is NOT created. Tests for migration helper assert it writes when no skill exists and skips when one does. Closes #2973 * chore(#2973): add changeset fragment for PR #3003 * fix(#2973): rephrase comment to avoid cline-install leaked-path lint The new comment at line 780 of profile-output.cjs literally contained the string '~/.claude/commands/gsd/' which the cline-install leaked-path regression test (tests/cline-install.test.cjs:175) correctly flagged. Cline transforms .claude/skills/ -> .cline/skills/ in installed .cjs files but does not transform .claude/commands/. The new comment talks about the legacy 'commands/gsd' subdirectory without the ~/.claude/ prefix, so the lint passes. The path semantics are unchanged -- the runtime construction at line 787 still uses path.join(os.homedir(), '.claude', 'skills', ...) which the lint regex does not match. * test(#2973): add timeout to spawnSync to prevent CI hangs (CR feedback) CodeRabbit on PR #3003: without a timeout, a regression that hangs the writer or dispatcher would block CI indefinitely. Added a 30s timeout (generous for what should complete in <1s) and an explicit signal assertion so a timeout trip surfaces as a clear test failure with context rather than a hung worker. * test(#2973): add allow-test-rule annotation for legitimate product-text parsing The new var-binding lint from #2982/#2985 caught readFileSync(...).match() and readFileSync(...).includes() calls in this test. Both are legitimate structural assertions against the product workflow markdown, not source-grep: - match() extracts the path from a structured Display: "..." line and asserts on the typed path value (same pattern as bug-2470's installer scanForLeakedPaths regex test). - includes() asserts the absence of a legacy path literal. profile-user.md IS the shipped workflow artifact, and its Display: line IS what the user sees. Per the existing test-rigor convention, this is the source-text-is-the-product justification category. Annotated with allow-test-rule citing that category. * chore(#3003): drop direct CHANGELOG.md edit; release entry now lives in .changeset/ The changeset-fragment workflow (#2975) renders fragments into CHANGELOG.md at release time. Direct edits to [Unreleased] on each PR caused merge conflicts on every concurrent PR. This commit restores CHANGELOG.md to match origin/main; the release entry for this fix is preserved in the .changeset/*.md fragment(s) on this branch, which the release workflow consolidates. * fix(#2973): preserve user-owned gsd-dev-preferences skill across wipe (CR) CodeRabbit on PR #3003 caught a real bug: copyCommandsAsClaudeSkills() wipes ALL gsd-* skill directories at the top of every install, then reinstalls from the package source. Since gsd-dev-preferences is user-generated (written by /gsd-profile-user --refresh) and NOT shipped by the npm package, the wipe deletes the user's customized SKILL.md with nothing to restore from. Fix: USER_OWNED_SKILLS allow-list in copyCommandsAsClaudeSkills. Snapshot files under skills/gsd-dev-preferences/ before the wipe, restore after. Same preserve/restore pattern as PR #1924. Tests: bug-2973 grows by 2 cases: - user-customized SKILL.md survives the wipe - non-user-owned gsd-* skills are still wiped (preservation is opt-in)
16 KiB
This workflow wires Phase 1 (session pipeline) and Phase 2 (profiling engine) into a cohesive user-facing experience. All heavy lifting is done by existing gsd-sdk query handlers (with legacy gsd-tools.cjs parity where needed) and the gsd-user-profiler agent -- this workflow orchestrates the sequence, handles branching, and provides the UX.
<required_reading> Read all files referenced by the invoking prompt's execution_context before starting.
Key references:
- @$HOME/.claude/get-shit-done/references/ui-brand.md (display patterns)
- @$HOME/.claude/agents/gsd-user-profiler.md (profiler agent definition)
- @$HOME/.claude/get-shit-done/references/user-profiling.md (profiling reference doc) </required_reading>
1. Initialize
Parse flags from $ARGUMENTS:
- Detect
--questionnaireflag (skip session analysis, questionnaire-only) - Detect
--refreshflag (rebuild profile even when one exists)
Check for existing profile:
PROFILE_PATH="$HOME/.claude/get-shit-done/USER-PROFILE.md"
[ -f "$PROFILE_PATH" ] && echo "EXISTS" || echo "NOT_FOUND"
If profile exists AND --refresh NOT set AND --questionnaire NOT set:
Text mode (workflow.text_mode: true in config or --text flag): Set TEXT_MODE=true if --text is present in $ARGUMENTS OR text_mode from init JSON is true. When TEXT_MODE is active, replace every AskUserQuestion call with a plain-text numbered list and ask the user to type their choice number. This is required for non-Claude runtimes (OpenAI Codex, Gemini CLI, etc.) where AskUserQuestion is not available.
Use AskUserQuestion:
- header: "Existing Profile"
- question: "You already have a profile. What would you like to do?"
- options:
- "View it" -- Display summary card from existing profile data, then exit
- "Refresh it" -- Continue with --refresh behavior
- "Cancel" -- Exit workflow
If "View it": Read USER-PROFILE.md, display its content formatted as a summary card, then exit. If "Refresh it": Set --refresh behavior and continue. If "Cancel": Display "No changes made." and exit.
If profile exists AND --refresh IS set:
Backup existing profile:
cp "$HOME/.claude/get-shit-done/USER-PROFILE.md" "$HOME/.claude/USER-PROFILE.backup.md"
Display: "Re-analyzing your sessions to update your profile." Continue to step 2.
If no profile exists: Continue to step 2.
2. Consent Gate (ACTV-06)
Skip if --questionnaire flag is set (no JSONL reading occurs -- jump directly to step 4b).
Display consent screen:
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
GSD > PROFILE YOUR CODING STYLE
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Claude starts every conversation generic. A profile teaches Claude
how YOU actually work -- not how you think you work.
## What We'll Analyze
Your recent Claude Code sessions, looking for patterns in these
8 behavioral dimensions:
| Dimension | What It Measures |
|----------------------|---------------------------------------------|
| Communication Style | How you phrase requests (terse vs. detailed) |
| Decision Speed | How you choose between options |
| Explanation Depth | How much explanation you want with code |
| Debugging Approach | How you tackle errors and bugs |
| UX Philosophy | How much you care about design vs. function |
| Vendor Philosophy | How you evaluate libraries and tools |
| Frustration Triggers | What makes you correct Claude |
| Learning Style | How you prefer to learn new things |
## Data Handling
✓ Reads session files locally (read-only, nothing modified)
✓ Analyzes message patterns (not content meaning)
✓ Stores profile at $HOME/.claude/get-shit-done/USER-PROFILE.md
✗ Nothing is sent to external services
✗ Sensitive content (API keys, passwords) is automatically excluded
If --refresh path: Show abbreviated consent instead:
Re-analyzing your sessions to update your profile.
Your existing profile has been backed up to USER-PROFILE.backup.md.
Use AskUserQuestion:
- header: "Refresh"
- question: "Continue with profile refresh?"
- options:
- "Continue" -- Proceed to step 3
- "Cancel" -- Exit workflow
If default (no --refresh) path:
Use AskUserQuestion:
- header: "Ready?"
- question: "Ready to analyze your sessions?"
- options:
- "Let's go" -- Proceed to step 3 (session analysis)
- "Use questionnaire instead" -- Jump to step 4b (questionnaire path)
- "Not now" -- Display "No worries. Run /gsd-profile-user when ready." and exit
3. Session Scan
Display: "◆ Scanning sessions..."
Run session scan:
SCAN_RESULT=$(gsd-sdk query scan-sessions --json 2>/dev/null)
Parse the JSON output to get session count and project count.
Display: "✓ Found N sessions across M projects"
Determine data sufficiency:
- Count total messages available from the scan result (sum sessions across projects)
- If 0 sessions found: Display "No sessions found. Switching to questionnaire." and jump to step 4b
- If sessions found: Continue to step 4a
4a. Session Analysis Path
Display: "◆ Sampling messages..."
Run profile sampling:
SAMPLE_RESULT=$(gsd-sdk query profile-sample --json 2>/dev/null)
Parse the JSON output to get the temp directory path and message count.
Display: "✓ Sampled N messages from M projects"
Display: "◆ Analyzing patterns..."
Spawn gsd-user-profiler agent using Task tool:
Use the Task tool to spawn the gsd-user-profiler agent. Provide it with:
- The sampled JSONL file path from profile-sample output
- The user-profiling reference doc at
$HOME/.claude/get-shit-done/references/user-profiling.md
The agent prompt should follow this structure:
Read the profiling reference document and the sampled session messages, then analyze the developer's behavioral patterns across all 8 dimensions.
Reference: @$HOME/.claude/get-shit-done/references/user-profiling.md
Session data: @{temp_dir}/profile-sample.jsonl
Analyze these messages and return your analysis in the <analysis> JSON format specified in the reference document.
Parse the agent's output:
- Extract the
<analysis>JSON block from the agent's response - Save analysis JSON to a temp file (in the same temp directory created by profile-sample)
ANALYSIS_PATH="{temp_dir}/analysis.json"
Write the analysis JSON to $ANALYSIS_PATH.
Display: "✓ Analysis complete (N dimensions scored)"
Check for thin data:
- Read the analysis JSON and check the total message count
- If < 50 messages were analyzed: Note that a questionnaire supplement could improve accuracy. Display: "Note: Limited session data (N messages). Results may have lower confidence."
Continue to step 5.
4b. Questionnaire Path
Display: "Using questionnaire to build your profile."
Get questions:
QUESTIONS=$(gsd-sdk query profile-questionnaire --json 2>/dev/null)
Parse the questions JSON. It contains 8 questions, one per dimension.
Present each question to the user via AskUserQuestion:
For each question in the questions array:
- header: The dimension name (e.g., "Communication Style")
- question: The question text
- options: The answer options from the question definition
Collect all answers into an answers JSON object mapping dimension keys to selected answer values.
Save answers to temp file:
ANSWERS_PATH=$(mktemp /tmp/gsd-profile-answers-XXXXXX.json)
Write the answers JSON to $ANSWERS_PATH.
Convert answers to analysis:
ANALYSIS_RESULT=$(gsd-sdk query profile-questionnaire --answers "$ANSWERS_PATH" --json 2>/dev/null)
Parse the analysis JSON from the result.
Save analysis JSON to a temp file:
ANALYSIS_PATH=$(mktemp /tmp/gsd-profile-analysis-XXXXXX.json)
Write the analysis JSON to $ANALYSIS_PATH.
Continue to step 5 (skip split resolution since questionnaire handles ambiguity internally).
5. Split Resolution
Skip if questionnaire-only path (splits already handled internally).
Read the analysis JSON from $ANALYSIS_PATH.
Check each dimension for cross_project_consistent: false.
For each split detected:
Use AskUserQuestion:
- header: The dimension name (e.g., "Communication Style")
- question: "Your sessions show different patterns:" followed by the split context (e.g., "CLI/backend projects -> terse-direct, Frontend/UI projects -> detailed-structured")
- options:
- Rating option A (e.g., "terse-direct")
- Rating option B (e.g., "detailed-structured")
- "Context-dependent (keep both)"
If user picks a specific rating: Update the dimension's rating field in the analysis JSON to the selected value.
If user picks "Context-dependent": Keep the dominant rating in the rating field. Add a context_note to the dimension's summary describing the split (e.g., "Context-dependent: terse in CLI projects, detailed in frontend projects").
Write updated analysis JSON back to $ANALYSIS_PATH.
6. Profile Write
Display: "◆ Writing profile..."
gsd-sdk query write-profile --input "$ANALYSIS_PATH" --json
Display: "✓ Profile written to $HOME/.claude/get-shit-done/USER-PROFILE.md"
7. Result Display
Read the analysis JSON from $ANALYSIS_PATH to build the display.
Show report card table:
## Your Profile
| Dimension | Rating | Confidence |
|----------------------|----------------------|------------|
| Communication Style | detailed-structured | HIGH |
| Decision Speed | deliberate-informed | MEDIUM |
| Explanation Depth | concise | HIGH |
| Debugging Approach | hypothesis-driven | MEDIUM |
| UX Philosophy | pragmatic | LOW |
| Vendor Philosophy | thorough-evaluator | HIGH |
| Frustration Triggers | scope-creep | MEDIUM |
| Learning Style | self-directed | HIGH |
(Populate with actual values from the analysis JSON.)
Show highlight reel:
Pick 3-4 dimensions with the highest confidence and most evidence signals. Format as:
## Highlights
- **Communication (HIGH):** You consistently provide structured context with
headers and problem statements before making requests
- **Vendor Choices (HIGH):** You research alternatives thoroughly -- comparing
docs, GitHub activity, and bundle sizes before committing
- **Frustrations (MEDIUM):** You correct Claude most often for doing things
you didn't ask for -- scope creep is your primary trigger
Build highlights from the evidence array and summary fields in the analysis JSON. Use the most compelling evidence quotes. Format each as "You tend to..." or "You consistently..." with evidence attribution.
Offer full profile view:
Use AskUserQuestion:
- header: "Profile"
- question: "Want to see the full profile?"
- options:
- "Yes" -- Read and display the full USER-PROFILE.md content, then continue to step 8
- "Continue to artifacts" -- Proceed directly to step 8
8. Artifact Selection (ACTV-05)
Use AskUserQuestion with multiSelect:
- header: "Artifacts"
- question: "Which artifacts should I generate?"
- options (ALL pre-selected by default):
- "/gsd-dev-preferences command file" -- "Load your preferences in any session"
- "CLAUDE.md profile section" -- "Add profile to this project's CLAUDE.md"
- "Global CLAUDE.md" -- "Add profile to $HOME/.claude/CLAUDE.md for all projects"
If no artifacts selected: Display "No artifacts generated. Your profile is saved at $HOME/.claude/get-shit-done/USER-PROFILE.md" and jump to step 10.
9. Artifact Generation
Generate selected artifacts sequentially (file I/O is fast, no benefit from parallel agents):
For /gsd-dev-preferences (if selected):
gsd-sdk query generate-dev-preferences --analysis "$ANALYSIS_PATH" --json
Display: "✓ Generated /gsd-dev-preferences at $HOME/.claude/skills/gsd-dev-preferences/SKILL.md"
For CLAUDE.md profile section (if selected):
gsd-sdk query generate-claude-profile --analysis "$ANALYSIS_PATH" --json
Display: "✓ Added profile section to CLAUDE.md"
For Global CLAUDE.md (if selected):
gsd-sdk query generate-claude-profile --analysis "$ANALYSIS_PATH" --global --json
Display: "✓ Added profile section to $HOME/.claude/CLAUDE.md"
Error handling: If any gsd-sdk query or gsd-tools.cjs call fails, display the error message and use AskUserQuestion to offer "Retry" or "Skip this artifact". On retry, re-run the command. On skip, continue to next artifact.
10. Summary & Refresh Diff
If --refresh path:
Read both old backup and new analysis to compare dimension ratings/confidence.
Read the backed-up profile:
BACKUP_PATH="$HOME/.claude/USER-PROFILE.backup.md"
Compare each dimension's rating and confidence between old and new. Display diff table showing only changed dimensions:
## Changes
| Dimension | Before | After |
|-----------------|-----------------------------|-----------------------------|
| Communication | terse-direct (LOW) | detailed-structured (HIGH) |
| Debugging | fix-first (MEDIUM) | hypothesis-driven (MEDIUM) |
If nothing changed: Display "No changes detected -- your profile is already up to date."
Display final summary:
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
GSD > PROFILE COMPLETE ✓
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Your profile: $HOME/.claude/get-shit-done/USER-PROFILE.md
Then list paths for each generated artifact:
Artifacts:
✓ /gsd-dev-preferences $HOME/.claude/skills/gsd-dev-preferences/SKILL.md
✓ CLAUDE.md section ./CLAUDE.md
✓ Global CLAUDE.md $HOME/.claude/CLAUDE.md
(Only show artifacts that were actually generated.)
Clean up temp files:
Remove the temp directory created by profile-sample (contains sample JSONL and analysis JSON):
rm -rf "$TEMP_DIR"
Also remove any standalone temp files created for questionnaire answers:
rm -f "$ANSWERS_PATH" 2>/dev/null
rm -f "$ANALYSIS_PATH" 2>/dev/null
(Only clean up temp paths that were actually created during this workflow run.)
<success_criteria>
- Initialization detects existing profile and handles all three responses (view/refresh/cancel)
- Consent gate shown for session analysis path, skipped for questionnaire path
- Session scan discovers sessions and reports statistics
- Session analysis path: samples messages, spawns profiler agent, extracts analysis JSON
- Questionnaire path: presents 8 questions, collects answers, converts to analysis JSON
- Split resolution presents context-dependent splits with user resolution options
- Profile written to USER-PROFILE.md via write-profile subcommand
- Result display shows report card table and highlight reel with evidence
- Artifact selection uses multiSelect with all options pre-selected
- Artifacts generated sequentially via gsd-sdk query (or gsd-tools.cjs) subcommands
- Refresh diff shows changed dimensions when --refresh was used
- Temp files cleaned up on completion </success_criteria>