d3a79917fa
* feat: Phase 2 caller migration — gsd-sdk query in workflows (#2122) Cherry-picked orchestration rewrites from feat/sdk-foundation (#2008, 4018fee) onto current main, resolving conflicts to keep upstream worktree guards and post-merge test gate. SDK stub registry omitted (out of Phase 2 scope per #2122). Refs: #2122 #2008 Made-with: Cursor * docs: add gsd-sdk query migration blurb Made-with: Cursor * docs(workflows): extend Phase 2 gsd-sdk query caller migration - Swap node gsd-tools.cjs for gsd-sdk query in review, plan-phase, execute-plan, ship, extract_learnings, ai-integration-phase, eval-review, next, thread - Document graphify CJS-only in gsd-planner; dual-path in CLI-TOOLS and ARCHITECTURE - Update tests: workstreams gsd-sdk path, thread frontmatter.get, workspace init.*, CRLF-safe autonomous frontmatter parse - CHANGELOG: Phase 2 caller migration scope Made-with: Cursor * docs(phase2): USER-GUIDE + remaining gsd-sdk query call sites - USER-GUIDE: dual-path CLI section; state validate/sync use full CJS path - Commands: debug (config-get+tdd), quick (security note), intel Task prompt - Agent: gsd-debug-session-manager resolve-model via jq - Workflows: milestone-summary, forensics, next, complete-milestone/verify-work (audit-open CJS notes), discuss-phase, progress, verify-phase, add/insert/remove phase, transition, manager, quick workflow; remove-phase commit without --files - Test: quick-session-management accepts frontmatter.get - CHANGELOG: Phase 2 follow-up bullet Made-with: Cursor * docs(phase2): align gsd-sdk query examples in commands and agents - init.* query names; frontmatter.get uses positional field name - state.* handlers use positional args; commit uses positional paths - CJS-only notes for from-gsd2 and graphify; learnings.query wording - CHANGELOG: Phase 2 orchestration doc pass Made-with: Cursor * docs(phase2): normalize gsd-sdk query commit to positional file paths - Strip --files from commit examples in workflows, references, commands - Keep commit-to-subrepo ... --files (separate handler) - git-planning-commit.md: document positional args - Tests: new-project commit line, state.record-session, gates CRLF, roadmap.analyze - CHANGELOG [Unreleased] Made-with: Cursor * feat(sdk): gsd-sdk query parity with gsd-tools and PR 2179 registry fixes - Route query via longest-prefix match and dotted single-token expansion; fall back to runGsdToolsQuery (same argv as node gsd-tools.cjs) for full CLI coverage. - Parse gsd-sdk query permissively so gsd-tools flags (--json, --verify, etc.) are not rejected by strict parseArgs. - resolveGsdToolsPath: honor GSD_TOOLS_PATH; prefer bundled get-shit-done copy over project .claude installs; export runGsdToolsQuery from the SDK. - Fix gsd-tools audit-open (core.output; pass object for --json JSON). - Register summary-extract as alias of summary.extract; fix audit-fix workflow to call audit-uat instead of invalid init.audit-uat (PR review). Updates QUERY-HANDLERS.md and CHANGELOG [Unreleased]. Made-with: Cursor * fix(sdk): Phase 2 scope — Trek-e review (#2179, #2122) - Remove gsd-sdk query passthrough to gsd-tools.cjs; drop GSD_TOOLS_PATH - Consolidate argv routing in resolveQueryArgv(); update USAGE and QUERY-HANDLERS - Surface @file: read failures in GSDTools.parseOutput - execute-plan: defer Task Commit Protocol to gsd-executor - stale-colon-refs: skip .planning/ and root CLAUDE.md (gitignored overlays) - CHANGELOG [Unreleased]: maintainer review and routing notes Made-with: Cursor
88 lines
2.3 KiB
Markdown
88 lines
2.3 KiB
Markdown
# Revision Mode — Planner Reference
|
|
|
|
Triggered when orchestrator provides `<revision_context>` with checker issues. NOT starting fresh — making targeted updates to existing plans.
|
|
|
|
**Mindset:** Surgeon, not architect. Minimal changes for specific issues.
|
|
|
|
### Step 1: Load Existing Plans
|
|
|
|
```bash
|
|
cat .planning/phases/$PHASE-*/$PHASE-*-PLAN.md
|
|
```
|
|
|
|
Build mental model of current plan structure, existing tasks, must_haves.
|
|
|
|
### Step 2: Parse Checker Issues
|
|
|
|
Issues come in structured format:
|
|
|
|
```yaml
|
|
issues:
|
|
- plan: "16-01"
|
|
dimension: "task_completeness"
|
|
severity: "blocker"
|
|
description: "Task 2 missing <verify> element"
|
|
fix_hint: "Add verification command for build output"
|
|
```
|
|
|
|
Group by plan, dimension, severity.
|
|
|
|
### Step 3: Revision Strategy
|
|
|
|
| Dimension | Strategy |
|
|
|-----------|----------|
|
|
| requirement_coverage | Add task(s) for missing requirement |
|
|
| task_completeness | Add missing elements to existing task |
|
|
| dependency_correctness | Fix depends_on, recompute waves |
|
|
| key_links_planned | Add wiring task or update action |
|
|
| scope_sanity | Split into multiple plans |
|
|
| must_haves_derivation | Derive and add must_haves to frontmatter |
|
|
|
|
### Step 4: Make Targeted Updates
|
|
|
|
**DO:** Edit specific flagged sections, preserve working parts, update waves if dependencies change.
|
|
|
|
**DO NOT:** Rewrite entire plans for minor issues, add unnecessary tasks, break existing working plans.
|
|
|
|
### Step 5: Validate Changes
|
|
|
|
- [ ] All flagged issues addressed
|
|
- [ ] No new issues introduced
|
|
- [ ] Wave numbers still valid
|
|
- [ ] Dependencies still correct
|
|
- [ ] Files on disk updated
|
|
|
|
### Step 6: Commit
|
|
|
|
```bash
|
|
gsd-sdk query commit "fix($PHASE): revise plans based on checker feedback" .planning/phases/$PHASE-*/$PHASE-*-PLAN.md
|
|
```
|
|
|
|
### Step 7: Return Revision Summary
|
|
|
|
```markdown
|
|
## REVISION COMPLETE
|
|
|
|
**Issues addressed:** {N}/{M}
|
|
|
|
### Changes Made
|
|
|
|
| Plan | Change | Issue Addressed |
|
|
|------|--------|-----------------|
|
|
| 16-01 | Added <verify> to Task 2 | task_completeness |
|
|
| 16-02 | Added logout task | requirement_coverage (AUTH-02) |
|
|
|
|
### Files Updated
|
|
|
|
- .planning/phases/16-xxx/16-01-PLAN.md
|
|
- .planning/phases/16-xxx/16-02-PLAN.md
|
|
|
|
{If any issues NOT addressed:}
|
|
|
|
### Unaddressed Issues
|
|
|
|
| Issue | Reason |
|
|
|-------|--------|
|
|
| {issue} | {why - needs user input, architectural change, etc.} |
|
|
```
|