* feat: Phase 2 caller migration — gsd-sdk query in workflows (#2122) Cherry-picked orchestration rewrites from feat/sdk-foundation (#2008, 4018fee) onto current main, resolving conflicts to keep upstream worktree guards and post-merge test gate. SDK stub registry omitted (out of Phase 2 scope per #2122). Refs: #2122 #2008 Made-with: Cursor * docs: add gsd-sdk query migration blurb Made-with: Cursor * docs(workflows): extend Phase 2 gsd-sdk query caller migration - Swap node gsd-tools.cjs for gsd-sdk query in review, plan-phase, execute-plan, ship, extract_learnings, ai-integration-phase, eval-review, next, thread - Document graphify CJS-only in gsd-planner; dual-path in CLI-TOOLS and ARCHITECTURE - Update tests: workstreams gsd-sdk path, thread frontmatter.get, workspace init.*, CRLF-safe autonomous frontmatter parse - CHANGELOG: Phase 2 caller migration scope Made-with: Cursor * docs(phase2): USER-GUIDE + remaining gsd-sdk query call sites - USER-GUIDE: dual-path CLI section; state validate/sync use full CJS path - Commands: debug (config-get+tdd), quick (security note), intel Task prompt - Agent: gsd-debug-session-manager resolve-model via jq - Workflows: milestone-summary, forensics, next, complete-milestone/verify-work (audit-open CJS notes), discuss-phase, progress, verify-phase, add/insert/remove phase, transition, manager, quick workflow; remove-phase commit without --files - Test: quick-session-management accepts frontmatter.get - CHANGELOG: Phase 2 follow-up bullet Made-with: Cursor * docs(phase2): align gsd-sdk query examples in commands and agents - init.* query names; frontmatter.get uses positional field name - state.* handlers use positional args; commit uses positional paths - CJS-only notes for from-gsd2 and graphify; learnings.query wording - CHANGELOG: Phase 2 orchestration doc pass Made-with: Cursor * docs(phase2): normalize gsd-sdk query commit to positional file paths - Strip --files from commit examples in workflows, references, commands - Keep commit-to-subrepo ... --files (separate handler) - git-planning-commit.md: document positional args - Tests: new-project commit line, state.record-session, gates CRLF, roadmap.analyze - CHANGELOG [Unreleased] Made-with: Cursor * feat(sdk): gsd-sdk query parity with gsd-tools and PR 2179 registry fixes - Route query via longest-prefix match and dotted single-token expansion; fall back to runGsdToolsQuery (same argv as node gsd-tools.cjs) for full CLI coverage. - Parse gsd-sdk query permissively so gsd-tools flags (--json, --verify, etc.) are not rejected by strict parseArgs. - resolveGsdToolsPath: honor GSD_TOOLS_PATH; prefer bundled get-shit-done copy over project .claude installs; export runGsdToolsQuery from the SDK. - Fix gsd-tools audit-open (core.output; pass object for --json JSON). - Register summary-extract as alias of summary.extract; fix audit-fix workflow to call audit-uat instead of invalid init.audit-uat (PR review). Updates QUERY-HANDLERS.md and CHANGELOG [Unreleased]. Made-with: Cursor * fix(sdk): Phase 2 scope — Trek-e review (#2179, #2122) - Remove gsd-sdk query passthrough to gsd-tools.cjs; drop GSD_TOOLS_PATH - Consolidate argv routing in resolveQueryArgv(); update USAGE and QUERY-HANDLERS - Surface @file: read failures in GSDTools.parseOutput - execute-plan: defer Task Commit Protocol to gsd-executor - stale-colon-refs: skip .planning/ and root CLAUDE.md (gitignored overlays) - CHANGELOG [Unreleased]: maintainer review and routing notes Made-with: Cursor
156 lines
5.2 KiB
Markdown
156 lines
5.2 KiB
Markdown
<purpose>
|
|
Retroactive audit of an implemented AI phase's evaluation coverage. Standalone command that works on any GSD-managed AI phase. Produces a scored EVAL-REVIEW.md with gap analysis and remediation plan.
|
|
|
|
Use after /gsd-execute-phase to verify that the evaluation strategy from AI-SPEC.md was actually implemented. Mirrors the pattern of /gsd-ui-review and /gsd-validate-phase.
|
|
</purpose>
|
|
|
|
<required_reading>
|
|
@~/.claude/get-shit-done/references/ai-evals.md
|
|
</required_reading>
|
|
|
|
<process>
|
|
|
|
## 0. Initialize
|
|
|
|
```bash
|
|
INIT=$(gsd-sdk query init.phase-op "${PHASE_ARG}")
|
|
if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi
|
|
```
|
|
|
|
Parse: `phase_dir`, `phase_number`, `phase_name`, `phase_slug`, `padded_phase`, `commit_docs`.
|
|
|
|
```bash
|
|
AUDITOR_MODEL=$(gsd-sdk query resolve-model gsd-eval-auditor 2>/dev/null | jq -r '.model' 2>/dev/null || true)
|
|
```
|
|
|
|
Display banner:
|
|
```
|
|
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
GSD ► EVAL AUDIT — PHASE {N}: {name}
|
|
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
```
|
|
|
|
## 1. Detect Input State
|
|
|
|
```bash
|
|
SUMMARY_FILES=$(ls "${PHASE_DIR}"/*-SUMMARY.md 2>/dev/null)
|
|
AI_SPEC_FILE=$(ls "${PHASE_DIR}"/*-AI-SPEC.md 2>/dev/null | head -1)
|
|
EVAL_REVIEW_FILE=$(ls "${PHASE_DIR}"/*-EVAL-REVIEW.md 2>/dev/null | head -1)
|
|
```
|
|
|
|
**State A** — AI-SPEC.md + SUMMARY.md exist: Full audit against spec
|
|
**State B** — SUMMARY.md exists, no AI-SPEC.md: Audit against general best practices
|
|
**State C** — No SUMMARY.md: Exit — "Phase {N} not executed. Run /gsd-execute-phase {N} first."
|
|
|
|
|
|
**Text mode (`workflow.text_mode: true` in config or `--text` flag):** Set `TEXT_MODE=true` if `--text` is present in `$ARGUMENTS` OR `text_mode` from init JSON is `true`. When TEXT_MODE is active, replace every `AskUserQuestion` call with a plain-text numbered list and ask the user to type their choice number. This is required for non-Claude runtimes (OpenAI Codex, Gemini CLI, etc.) where `AskUserQuestion` is not available.
|
|
**If `EVAL_REVIEW_FILE` non-empty:** Use AskUserQuestion:
|
|
- header: "Existing Eval Review"
|
|
- question: "EVAL-REVIEW.md already exists for Phase {N}."
|
|
- options:
|
|
- "Re-audit — run fresh audit"
|
|
- "View — display current review and exit"
|
|
|
|
If "View": display file, exit.
|
|
If "Re-audit": continue.
|
|
|
|
**If State B (no AI-SPEC.md):** Warn:
|
|
```
|
|
No AI-SPEC.md found for Phase {N}.
|
|
Audit will evaluate against general AI eval best practices rather than a phase-specific plan.
|
|
Consider running /gsd-ai-integration-phase {N} before implementation next time.
|
|
```
|
|
Continue (non-blocking).
|
|
|
|
## 2. Gather Context Paths
|
|
|
|
Build file list for auditor:
|
|
- AI-SPEC.md (if exists — the planned eval strategy)
|
|
- All SUMMARY.md files in phase dir
|
|
- All PLAN.md files in phase dir
|
|
|
|
## 3. Spawn gsd-eval-auditor
|
|
|
|
```
|
|
◆ Spawning eval auditor...
|
|
```
|
|
|
|
Build prompt:
|
|
|
|
```markdown
|
|
Read ~/.claude/agents/gsd-eval-auditor.md for instructions.
|
|
|
|
<objective>
|
|
Conduct evaluation coverage audit of Phase {phase_number}: {phase_name}
|
|
{If AI-SPEC exists: "Audit against AI-SPEC.md evaluation plan."}
|
|
{If no AI-SPEC: "Audit against general AI eval best practices."}
|
|
</objective>
|
|
|
|
<files_to_read>
|
|
- {summary_paths}
|
|
- {plan_paths}
|
|
- {ai_spec_path if exists}
|
|
</files_to_read>
|
|
|
|
<input>
|
|
ai_spec_path: {ai_spec_path or "none"}
|
|
phase_dir: {phase_dir}
|
|
phase_number: {phase_number}
|
|
phase_name: {phase_name}
|
|
padded_phase: {padded_phase}
|
|
state: {A or B}
|
|
</input>
|
|
```
|
|
|
|
Spawn as Task with model `AUDITOR_MODEL`.
|
|
|
|
## 4. Parse Auditor Result
|
|
|
|
Read the written EVAL-REVIEW.md. Extract:
|
|
- `overall_score`
|
|
- `verdict` (PRODUCTION READY | NEEDS WORK | SIGNIFICANT GAPS | NOT IMPLEMENTED)
|
|
- `critical_gap_count`
|
|
|
|
## 5. Display Summary
|
|
|
|
```
|
|
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
GSD ► EVAL AUDIT COMPLETE — PHASE {N}: {name}
|
|
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
|
|
◆ Score: {overall_score}/100
|
|
◆ Verdict: {verdict}
|
|
◆ Critical Gaps: {critical_gap_count}
|
|
◆ Output: {eval_review_path}
|
|
|
|
{If PRODUCTION READY:}
|
|
Next step: /gsd-plan-phase (next phase) or deploy
|
|
|
|
{If NEEDS WORK:}
|
|
Address critical gaps in EVAL-REVIEW.md, then re-run /gsd-eval-review {N}
|
|
|
|
{If SIGNIFICANT GAPS or NOT IMPLEMENTED:}
|
|
Review AI-SPEC.md evaluation plan. Critical eval dimensions are not implemented.
|
|
Do not deploy until gaps are addressed.
|
|
```
|
|
|
|
## 6. Commit
|
|
|
|
**If `commit_docs` is true:**
|
|
```bash
|
|
git add "${EVAL_REVIEW_FILE}"
|
|
git commit -m "docs({phase_slug}): add EVAL-REVIEW.md — score {overall_score}/100 ({verdict})"
|
|
```
|
|
|
|
</process>
|
|
|
|
<success_criteria>
|
|
- [ ] Phase execution state detected correctly
|
|
- [ ] AI-SPEC.md presence handled (with or without)
|
|
- [ ] gsd-eval-auditor spawned with correct context
|
|
- [ ] EVAL-REVIEW.md written (by auditor)
|
|
- [ ] Score and verdict displayed to user
|
|
- [ ] Appropriate next steps surfaced based on verdict
|
|
- [ ] Committed if commit_docs enabled
|
|
</success_criteria>
|