* fix(#2636): surface gsd-sdk query failures and add workflow↔handler parity check Root cause: workflows invoked `gsd-sdk query agent-skills <slug>` with a trailing `2>/dev/null`, swallowing stderr and exit code. When the installed `@gsd-build/sdk` npm was stale (pre-query), the call resolved to an empty string and `agent_skills.<slug>` config was never injected into spawn prompts — silently. The handler exists on main (sdk/src/query/skills.ts), so this is a publish-drift + silent-fallback bug, not a missing handler. Fix: - Remove bare `2>/dev/null` from every `gsd-sdk query agent-skills …` invocation in workflows so SDK failures surface to stderr. - Apply the same rule to other no-fallback calls (audit-open, write-profile, generate-* profile handlers, frontmatter.get in commands). Best-effort cleanup calls (config-set workflow._auto_chain_active false) keep exit-code forgiveness via `|| true` but no longer suppress stderr. Parity tests: - New: tests/bug-2636-gsd-sdk-query-silent-swallow.test.cjs — fails if any `gsd-sdk query agent-skills … 2>/dev/null` is reintroduced. - Existing: tests/gsd-sdk-query-registry-integration.test.cjs already asserts every workflow noun resolves to a registered handler; confirmed passing post-change. Note: npm republish of @gsd-build/sdk is a separate release concern and is not included in this PR. * fix(#2636): address review — restore broken markdown fences and shell syntax The previous commit's mass removal of '2>/dev/null' suffixes also collapsed adjacent closing code fences and 'fi' tokens onto the command line, producing malformed markdown blocks and 'truefi' / 'true fi' shell syntax errors in the workflows. Repaired sites: - commands/gsd/quick.md, thread.md (frontmatter.get fences) - workflows/complete-milestone.md (audit-open fence) - workflows/profile-user.md (write-profile + generate-* fences) - workflows/verify-work.md (audit-open --json fence) - workflows/execute-phase.md (truefi -> true / fi) - workflows/plan-phase.md, discuss-phase-assumptions.md, discuss-phase/modes/chain.md (true fi -> true / fi) All 5450 tests pass.
191 lines
6.2 KiB
Markdown
191 lines
6.2 KiB
Markdown
<purpose>
|
|
Retroactive 6-pillar visual audit of implemented frontend code. Standalone command that works on any project — GSD-managed or not. Produces scored UI-REVIEW.md with actionable findings.
|
|
</purpose>
|
|
|
|
<required_reading>
|
|
@~/.claude/get-shit-done/references/ui-brand.md
|
|
</required_reading>
|
|
|
|
<available_agent_types>
|
|
Valid GSD subagent types (use exact names — do not fall back to 'general-purpose'):
|
|
- gsd-ui-auditor — Audits UI against design requirements
|
|
</available_agent_types>
|
|
|
|
<process>
|
|
|
|
## 0. Initialize
|
|
|
|
```bash
|
|
INIT=$(gsd-sdk query init.phase-op "${PHASE_ARG}")
|
|
if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi
|
|
AGENT_SKILLS_UI_REVIEWER=$(gsd-sdk query agent-skills gsd-ui-auditor)
|
|
```
|
|
|
|
Parse: `phase_dir`, `phase_number`, `phase_name`, `phase_slug`, `padded_phase`, `commit_docs`.
|
|
|
|
```bash
|
|
UI_AUDITOR_MODEL=$(gsd-sdk query resolve-model gsd-ui-auditor --raw)
|
|
```
|
|
|
|
Display banner:
|
|
```
|
|
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
GSD ► UI AUDIT — PHASE {N}: {name}
|
|
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
```
|
|
|
|
## 1. Detect Input State
|
|
|
|
```bash
|
|
SUMMARY_FILES=$(ls "${PHASE_DIR}"/*-SUMMARY.md 2>/dev/null)
|
|
UI_SPEC_FILE=$(ls "${PHASE_DIR}"/*-UI-SPEC.md 2>/dev/null | head -1)
|
|
UI_REVIEW_FILE=$(ls "${PHASE_DIR}"/*-UI-REVIEW.md 2>/dev/null | head -1)
|
|
```
|
|
|
|
**If `SUMMARY_FILES` empty:** Exit — "Phase {N} not executed. Run /gsd:execute-phase {N} first."
|
|
|
|
|
|
**Text mode (`workflow.text_mode: true` in config or `--text` flag):** Set `TEXT_MODE=true` if `--text` is present in `$ARGUMENTS` OR `text_mode` from init JSON is `true`. When TEXT_MODE is active, replace every `AskUserQuestion` call with a plain-text numbered list and ask the user to type their choice number. This is required for non-Claude runtimes (OpenAI Codex, Gemini CLI, etc.) where `AskUserQuestion` is not available.
|
|
**If `UI_REVIEW_FILE` non-empty:** Use AskUserQuestion:
|
|
- header: "Existing UI Review"
|
|
- question: "UI-REVIEW.md already exists for Phase {N}."
|
|
- options:
|
|
- "Re-audit — run fresh audit"
|
|
- "View — display current review and exit"
|
|
|
|
If "View": display file, exit.
|
|
If "Re-audit": continue.
|
|
|
|
## 2. Gather Context Paths
|
|
|
|
Build file list for auditor:
|
|
- All SUMMARY.md files in phase dir
|
|
- All PLAN.md files in phase dir
|
|
- UI-SPEC.md (if exists — audit baseline)
|
|
- CONTEXT.md (if exists — locked decisions)
|
|
|
|
## 3. Spawn gsd-ui-auditor
|
|
|
|
```
|
|
◆ Spawning UI auditor...
|
|
```
|
|
|
|
Build prompt:
|
|
|
|
```markdown
|
|
Read ~/.claude/agents/gsd-ui-auditor.md for instructions.
|
|
|
|
<objective>
|
|
Conduct 6-pillar visual audit of Phase {phase_number}: {phase_name}
|
|
{If UI-SPEC exists: "Audit against UI-SPEC.md design contract."}
|
|
{If no UI-SPEC: "Audit against abstract 6-pillar standards."}
|
|
</objective>
|
|
|
|
<files_to_read>
|
|
- {summary_paths} (Execution summaries)
|
|
- {plan_paths} (Execution plans — what was intended)
|
|
- {ui_spec_path} (UI Design Contract — audit baseline, if exists)
|
|
- {context_path} (User decisions, if exists)
|
|
</files_to_read>
|
|
|
|
${AGENT_SKILLS_UI_REVIEWER}
|
|
|
|
<config>
|
|
phase_dir: {phase_dir}
|
|
padded_phase: {padded_phase}
|
|
</config>
|
|
```
|
|
|
|
Omit null file paths.
|
|
|
|
```
|
|
Task(
|
|
prompt=ui_audit_prompt,
|
|
subagent_type="gsd-ui-auditor",
|
|
model="{UI_AUDITOR_MODEL}",
|
|
description="UI Audit Phase {N}"
|
|
)
|
|
```
|
|
|
|
## 4. Handle Return
|
|
|
|
**If `## UI REVIEW COMPLETE`:**
|
|
|
|
Display score summary:
|
|
|
|
```
|
|
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
GSD ► UI AUDIT COMPLETE ✓
|
|
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
|
|
|
**Phase {N}: {Name}** — Overall: {score}/24
|
|
|
|
| Pillar | Score |
|
|
|--------|-------|
|
|
| Copywriting | {N}/4 |
|
|
| Visuals | {N}/4 |
|
|
| Color | {N}/4 |
|
|
| Typography | {N}/4 |
|
|
| Spacing | {N}/4 |
|
|
| Experience Design | {N}/4 |
|
|
|
|
Top fixes:
|
|
1. {fix}
|
|
2. {fix}
|
|
3. {fix}
|
|
|
|
Full review: {path to UI-REVIEW.md}
|
|
|
|
───────────────────────────────────────────────────────────────
|
|
|
|
## ▶ Next
|
|
|
|
`/clear` then one of:
|
|
|
|
- `/gsd:verify-work {N}` — UAT testing
|
|
- `/gsd:plan-phase {N+1}` — plan next phase
|
|
|
|
- `/gsd:verify-work {N}` — UAT testing
|
|
- `/gsd:plan-phase {N+1}` — plan next phase
|
|
|
|
───────────────────────────────────────────────────────────────
|
|
```
|
|
|
|
## Automated UI Verification (when Playwright-MCP is available)
|
|
|
|
If `mcp__playwright__*` tools are accessible in this session:
|
|
|
|
1. Navigate to each UI component described in the phase's UI-SPEC.md using
|
|
`mcp__playwright__navigate` (or equivalent Playwright-MCP tool).
|
|
2. Take a screenshot of each component using `mcp__playwright__screenshot`.
|
|
3. Compare against the spec's visual requirements — dimensions, color palette,
|
|
layout, spacing scale, and typography.
|
|
4. Report any dimension, color, or layout discrepancies automatically as
|
|
additional findings within the relevant pillar section of UI-REVIEW.md.
|
|
5. Flag items that require human judgment (brand feel, content tone) as
|
|
`needs_human_review: true` in the findings — these are surfaced to the user
|
|
separately after the automated pass completes.
|
|
|
|
If Playwright-MCP is not available in this session, this section is skipped
|
|
entirely. The audit falls back to the standard code-only review described above.
|
|
No configuration change is required — the availability of `mcp__playwright__*`
|
|
tools is detected at runtime.
|
|
|
|
## 5. Commit (if configured)
|
|
|
|
```bash
|
|
gsd-sdk query commit "docs(${padded_phase}): UI audit review" "${PHASE_DIR}/${PADDED_PHASE}-UI-REVIEW.md"
|
|
```
|
|
|
|
</process>
|
|
|
|
<success_criteria>
|
|
- [ ] Phase validated
|
|
- [ ] SUMMARY.md files found (execution completed)
|
|
- [ ] Existing review handled (re-audit/view)
|
|
- [ ] gsd-ui-auditor spawned with correct context
|
|
- [ ] UI-REVIEW.md created in phase directory
|
|
- [ ] Score summary displayed to user
|
|
- [ ] Next steps presented
|
|
</success_criteria>
|