Dennis Alexis Valin Dittrich c9bff8d2b9 fix(#3899): resolve REVIEWS.md by quoted assignment, not an unquoted ls (#3928)
* fix(#3899): resolve REVIEWS.md by quoted assignment, not an unquoted ls

The convergence loop resolved the phase REVIEWS.md through
`$(ls ${phase_dir}/... 2>/dev/null)`. The unquoted ${phase_dir} word-splits,
so a project path containing a space handed `ls` arguments that do not exist,
the discarded stderr hid the error, and the empty result was reported as
"review agent did not produce REVIEWS.md" — blaming the agent for a quoting
defect. A glob metacharacter fails worse: the pattern expands to whatever
sibling directory matches, so the loop silently reads a different phase's
REVIEWS.md and `ls` still exits 0.

Assign the path directly, quoted, and fail closed with an error that names the
expected location. The regression block extracts the bash fence from the
shipped workflow and RUNS it against space-, glob- and missing-file fixtures,
because every text assertion in that suite passed against the broken line.

* chore(#3899): add the changelog fragment

* fix(#3899): reject a non-file reviews path and anchor the gate harness

Adversarial review (codex, gemini) on the first cut, three findings taken:

- `[ -r ]` alone is true for a readable DIRECTORY, so a directory standing
  where the reviews file belongs passed the gate and reached the consumers
  that read it. Require a regular file as well.
- the harness picked its fence by scanning the WHOLE document for a bash
  block assigning REVIEWS_FILE. If the real fence ever stopped assigning it
  and an unrelated one started, the harness would execute the wrong block and
  report green. Anchor the span to the verification step, between its opening
  sentence and the next heading.
- the no-subshell assertion matched only `$(`; a backtick rewrite would
  reintroduce identical word-splitting unseen. The discarded-stderr assertion
  is scoped to lines naming REVIEWS_FILE rather than banning the redirect
  across the whole fence.

Four findings declined: `return 1 || exit 1` (the document's own idiom is a
bare `exit 1`, including the guard immediately below), `${phase_dir:-}` for
`set -u` (unchanged exposure from the old line, and an unset phase_dir is a
bug worth surfacing), an explicit empty-phase_dir branch (the guard already
fails closed and prints the truncated path), and a downstream
`[ -n "$REVIEWS_FILE" ]` hazard (no such consumer exists — the guard exits
before any of them run).

* chore(#3899): backfill the changeset PR number

* fix(#3899): address required review feedback

Use the fragment-aware workflow reader, remove the inert exemption marker, document the unreadable-arm coverage limit, align errors with the workflow convention, and name an empty phase_dir directly. Migrate the obsolete emitted-drift fragment to the current commit-trailer contract.

Emitted-Drift-Ack-Growth: plan-review-convergence.md — #3899: replace unquoted $(ls ... 2>/dev/null) resolution with a quoted direct path, fail-closed file/readability checks, and an explicit phase_dir diagnostic; surrounding prose records why quoting is load-bearing.

---------

Co-authored-by: davdittrich <davdittrich@gmail.com>
Co-authored-by: CI Rebase Check <ci@gsd-redux>
Co-authored-by: Tom Boucher <trekkie@nomorestars.com>
2026-09-01 20:25:27 -04:00
2026-08-30 02:40:59 +00:00
2026-08-30 02:40:59 +00:00

GSD Core

Git. Ship. Done.

English · Português · 简体中文 · 日本語 · 한국어

A light-weight meta-prompting, context engineering, and spec-driven development system for Claude Code, OpenCode, Antigravity CLI, Kimi CLI, Kilo, Codex, Copilot, Cursor, Windsurf, and more.

npm version npm downloads Tests Discord GitHub stars License


What is GSD Core

GSD Core is a context-engineering and spec-driven development framework that drives AI coding agents (Claude Code, Codex, Antigravity CLI, Kimi CLI, Copilot, Cursor, and more) through a disciplined phase loop. It solves context rot — the quality degradation that accumulates as an AI fills its context window — by running all heavy research, planning, and execution work in fresh-context subagents while keeping your main session lean.


How it works

Each milestone repeats the same five-step loop, one phase at a time:

  1. Discuss — capture implementation decisions before anything is planned
  2. Plan — research, decompose, and verify the plan fits a fresh context window
  3. Execute — run plans in parallel waves; each executor starts with a clean 200k-token context
  4. Verify — walk through what was built; diagnose and fix before declaring done
  5. Ship — create the PR, archive the phase, repeat for the next one

Quickstart

npx @opengsd/gsd-core@latest

The installer prompts for your runtime (Claude Code, OpenCode, Antigravity CLI, Kimi CLI, Kilo, Codex, Copilot, Cursor, Windsurf, and more) and whether to install globally or locally. The installer is required for cross-runtime compatibility — do not copy files from agents/ or commands/ directly.

On another runtime or without Node.js? See Install on your runtime.

Once installed, start a new project or onboard an existing repo:

/gsd-new-project   # greenfield project
/gsd-onboard       # existing codebase

New here? Follow Your first project for a guided walkthrough from install to first shipped phase, or Onboarding an existing codebase for brownfield setup.


Documentation

What's new in 1.7.0 → docs/whats-new-1.7.0.md

Tutorials — learning by doing:

How-to guides — task-focused recipes:

Reference — authoritative facts:

Explanation — concepts and design decisions:

Full index: docs/README.md. Other languages: 日本語 · 한국어 · Português · 简体中文.


Why it works

Most AI-coding setups fail at scale because context bloat silently degrades output quality, there is no shared memory between sessions, and nothing verifies that code actually works. GSD Core solves all three: heavy work runs in fresh subagents, structured artifacts like STATE.md and CONTEXT.md survive session boundaries, and the verify step walks through what was built and generates fix plans before a phase is declared done. See docs/explanation/context-engineering.md for the full reasoning.

Troubleshooting? See docs/how-to/recover-and-troubleshoot.md.


Community

Project Platform
gsd-opencode Original OpenCode port
Discord Community support

Star History

Star History Chart

License

MIT License. See LICENSE for details.


Claude Code is powerful. GSD Core makes it reliable.

Description
No description provided
Readme MIT 77 MiB
Languages
JavaScript 82.3%
TypeScript 17.4%
Shell 0.3%