Files
msd-core/tests/bug-2912-progress-context-authority.test.cjs
Tom Boucher 463cffd894 chore(#604): rename get-shit-done/ runtime directory to gsd-core/ (#615)
* chore(#604): rename get-shit-done/ runtime directory to gsd-core/

Renames the installed runtime directory `get-shit-done/` to `gsd-core/` so the
on-disk name matches the package (`@opengsd/gsd-core`), repo, and binary
(`gsd-tools`). The npm package name and binary are unchanged; npx/npm consumers
are unaffected.

Mechanical (bulk, ~90% of the diff):
- `git mv get-shit-done gsd-core`
- Swept path/identifier references across the repo via
  `perl -pe 's/get-shit-done(?!-\w)/gsd-core/g'`. The negative lookahead
  preserves the five legitimate slug variants that are NOT the directory:
  get-shit-done-{OLD,cc,classic,cli,redux} (old package/repo names).
- Build/manifest wiring: package.json (bin, files, coverage globs),
  tsconfig.build.json (outDir), ~86 .gitignore build-output entries,
  stryker.config.mjs, scan-ignore files, install.js path strings.
- Frozen (not rewritten): CHANGELOG.md history; translated docs
  (README.<locale>.md and docs/{ja-JP,ko-KR,pt-BR,zh-CN}/).

New logic (review here):
- src/installer-migrations/003-rename-get-shit-done-to-gsd-core.cts: a proper
  ADR-0008 installer migration. On upgrade it walks the legacy
  `~/.claude/get-shit-done/` tree, classifies each file via the prior install
  manifest, and emits remove-managed / backup-and-remove for managed files
  while PRESERVING unknown user-added files. Symlink-safe (skips a symlinked
  root and symlinked entries; bounds-checks every path under configDir). The
  framework rolls back on install failure. Emptied dirs may remain (framework
  has no recursive dir-removal primitive) — documented.
- scripts/lint-legacy-dir-name.cjs: CI regression guard forbidding the bare
  `get-shit-done` directory token (split token to avoid self-match; case-
  insensitive; `(?!-\w)` lookahead allows the slug variants; allowlists
  CHANGELOG, translated docs, and `gsd-allow-legacy-name` marker lines).
  Wired into the lint-tests CI job.
- Restored scripts/lint-package-identity-drift.cjs detection regexes (the
  mechanical sweep had wrongly rewritten the old-name patterns it exists to
  detect) and marked them as intentional legacy references.
- TDD tests for the migration and the guard; do.md slash-command guard regex
  tightened so a `/gsd-core/bin` path segment is not mistaken for a command;
  changeset + docs/installer-migrations.md row added.

Breaking: the installed runtime path moves `~/.claude/get-shit-done/` ->
`~/.claude/gsd-core/`. Migration 003 removes the stale legacy dir's managed
files (preserving user files) on upgrade. Users with custom hooks/configs
hardcoding the old path must update them.

Closes #604

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): unsweep pending changesets + allowlist injection-example docs

CI fixes for the rename PR:
- Do not sweep pending .changeset/*.md (ephemeral release-note fragments,
  like CHANGELOG); reverted those body edits so 5 pre-existing malformed
  fragments (missing type/pr) no longer enter the PR diff and trip docs-lint.
  Allowlisted .changeset/ in the legacy-name guard accordingly.
- Allowlisted TEST-EXAMPLES.md and docs/explanation/security-model.md in
  prompt-injection-scan.sh: they contain intentional injection examples /
  security-model prose; the path-reference rewrites are kept.

CodeQL alerts on this PR are pre-existing (alert lines unchanged by this PR;
none in the new migration/guard) and are out of scope for the rename.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): resolve CodeQL alerts surfaced on this PR

The rename diff touched files carrying pre-existing CodeQL findings; per the
no-pre-existing-dismissal rule, fixing every surfaced alert rather than waving
them off. All behavior-preserving:

- scripts/ci-test-scope.cjs: build the config-path match from string
  .includes() instead of a RegExp over an arg-derived value (js/regex-injection).
- src/profile-output.cts: escape backslashes before pipe-escaping desc/safeName
  so the table-cell escape is complete (js/incomplete-sanitization).
- tests/{bug-2643,bug-2808,docs-parity-live-registry}: two-pass HTML-comment
  strip so a bare/unclosed `<!--` cannot survive (js/incomplete-multi-character-sanitization).
- tests/inline-plan-threshold: drop the no-op `\s`->`\s` identity replace,
  keep the meaningful POSIX-class conversion (js/identity-replacement).

Verified: build:lib green; the touched test files + ci-test-scope + profile-output
suites pass; lint:legacy-name clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): correctly resolve remaining CodeQL alerts (regex-injection + sanitization)

The prior commit's fixes for two alerts were ineffective:
- ci-test-scope.cjs js/regex-injection: the alert is the CLI-arg-derived `file`
  reaching static regex `.test(file)` calls (not the config rule). Removed ALL
  regex over file/t — startsWith/includes/=== string checks + an isWindowsHint
  helper — so there is no regex sink for the tainted value.
- js/incomplete-multi-character-sanitization (3 test files): a single
  `.replace(/<!--...-->/g,'')` can let `<!--` re-form. Replaced with a fixpoint
  loop (replace until stable) plus a final bare-opener strip.

Verified: no regex over file/t remains; ci-test-scope + the 3 test suites pass;
lint:legacy-name clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): make ci-test-scope + comment-strippers regex-free to clear CodeQL

CodeQL flags the regex PATTERNS syntactically (regex-injection on the
--files arg split; incomplete-multi-character-sanitization on the <!--...-->
replace), so loop fixes do not satisfy it. Made these paths regex-free:
- ci-test-scope.cjs splitFiles: char-by-char separator tokenizer (no /[,\\s]+/).
- 3 test files: indexOf/slice HTML-comment stripper (no .replace(/<!--/)).
Behavior preserved; ci-test-scope + the 3 suites pass; guard clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): unblock security base64 scan on the large rename diff

The security job hit its 10m timeout: base64-scan.sh choked on the binary
test fixture tests/feat-3594-parser-property-style.test.cjs (embedded NUL/
non-UTF8 bytes -> thousands of bogus blobs + "ignored null byte" warnings),
and the ~800-file rename diff is slow to scan regardless.

- scripts/base64-scan.sh: skip binary-by-content files (grep -Iq .) — they
  can't carry base64-obfuscated *text* and feeding NUL bytes through the
  per-line scanner is pathologically slow. collect_files already filtered
  binary *extensions*; this catches binary *content* in text extensions.
- .github/workflows/security-scan.yml: raise the security job timeout 10m->30m
  to accommodate very large diffs (the scan itself is unchanged).

Verified locally: scan skips the fixture, 0 "ignored null byte" warnings,
0 findings, exit 0.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): sweep get-shit-done refs introduced by merging next

The branch was updated with next (#614/#384/#618 etc.), which reference the
get-shit-done/ dir (still named that on next). Swept the stale references in
the merged files to gsd-core so the rename stays consistent and lint:legacy-name
passes:
- commands/gsd/discuss-phase.md (runtime-launcher shim paths)
- src/core.cts (getAgentsDir layout comments)
- tests/bug-384-agents-runtime-aware.test.cjs (require path to runtime lib)

Verified: guard 0 violations; build green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): exclude gsd-core/ path segments from bug-3683 command cross-ref invariant

The #614 runtime-launcher shim added to discuss-phase.md references
`${_GSD_RUNTIME_ROOT}/gsd-core/bin/...`. bug-3683's REF_PATTERN excluded path-y
refs only via lookbehind, but `}` precedes `/gsd-core/` in the shim, so it
mis-read the directory path as a dangling `/gsd-core` command ref (same class as
the #604 bug-2954 fix). Added a trailing `(?![\w-]*\/)` so `/gsd-<x>/...` path
segments are not treated as slash-command references.

Verified locally on BOTH platforms before pushing:
- mac (node 26) full suite: 0 failures
- gsd-test-runner (linux, node22 image) full suite: 0 failures
- bug-3683 + bug-2954 pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): lazily resolve findProjectRoot in gsd-tools (harden flaky CI)

CI intermittently failed state.test's gsd-tools subprocess with
"findProjectRoot is not a function" (flip-flopping across legs; not reproducible
on mac full suite, gsd-test linux full suite, test:unit, or state.test x8).
findProjectRoot is a re-export from core.cjs (sourced from project-root.cjs);
binding it via destructure at module-load can be undefined under a load-ordering
edge. Resolve it lazily at call time via a small wrapper so the lookup happens
after core.cjs is fully initialized.

Verified green on BOTH platforms before pushing:
- mac (node 26) full suite: 0 failures
- gsd-test-runner (linux, node22) full suite: 0 failures
- state.test.cjs: 106/106; gsd-tools loads cleanly.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): allowlist verification-patterns.md placeholder examples in secret scan

The rename git-mv'd references/verification-patterns.md into gsd-core/, pulling
it into the secret-scan diff. It documents stub/placeholder RED-FLAG env-var
examples (illustrative Stripe test-key / database-URL / API-key placeholders) —
not real credentials. Added it to .secretscanignore with the strict annotation,
mirroring the existing gsd-core/workflows/plan-phase.md exception.

Verified locally: secret-scan-lint --strict OK; secret-scan --diff origin/next
exits 0 with 0 findings.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-02 18:35:29 -04:00

155 lines
5.4 KiB
JavaScript

/**
* Tests for issue #2912 — /gsd-progress can use stale CLAUDE.md project block
* instead of GSD tracking files as authoritative source.
*
* Fix: the `report` step in gsd-core/workflows/progress.md must contain
* an explicit "context authority" directive establishing PROJECT.md, STATE.md,
* and ROADMAP.md as the authoritative sources for the progress report, and
* forbidding the use of CLAUDE.md `## Project` blocks as a source for any
* report field.
*
* These tests parse the workflow markdown structurally (locate the
* <step name="report"> ... </step> block, then locate the blockquote-style
* directive inside it). They do NOT use `.includes()` over the whole file.
*/
const { test, describe } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('fs');
const path = require('path');
const WORKFLOW_PATH = path.join(
__dirname,
'..',
'gsd-core',
'workflows',
'progress.md'
);
/** Extract the body of a <step name="..."> ... </step> block by parsing tags. */
function extractStep(workflow, stepName) {
const openTag = `<step name="${stepName}">`;
const start = workflow.indexOf(openTag);
if (start === -1) return null;
const bodyStart = start + openTag.length;
// Find the matching </step> — workflow steps in this file do not nest.
const end = workflow.indexOf('</step>', bodyStart);
if (end === -1) return null;
return workflow.slice(bodyStart, end);
}
/**
* Extract contiguous markdown blockquote blocks from a chunk of markdown.
* A blockquote is a run of consecutive lines starting with '>' (after any
* leading whitespace). Returns the joined text of each blockquote with the
* leading '>' markers stripped.
*/
function extractBlockquotes(md) {
const lines = md.split(/\r?\n/);
const blocks = [];
let current = null;
for (const line of lines) {
const m = line.match(/^\s*>\s?(.*)$/);
if (m) {
if (current === null) current = [];
current.push(m[1]);
} else {
if (current !== null) {
blocks.push(current.join('\n'));
current = null;
}
}
}
if (current !== null) blocks.push(current.join('\n'));
return blocks;
}
describe('#2912: progress report step has explicit context-authority directive', () => {
test('progress.md workflow file exists and is readable', () => {
const stat = fs.statSync(WORKFLOW_PATH);
assert.ok(stat.isFile(), 'workflow file should exist');
});
test('progress.md has a <step name="report"> section', () => {
const workflow = fs.readFileSync(WORKFLOW_PATH, 'utf8');
const reportStep = extractStep(workflow, 'report');
assert.ok(reportStep, 'workflow should contain a report step');
assert.ok(reportStep.length > 0, 'report step body should not be empty');
});
test('report step contains a blockquote directive about context authority', () => {
const workflow = fs.readFileSync(WORKFLOW_PATH, 'utf8');
const reportStep = extractStep(workflow, 'report');
assert.ok(reportStep, 'report step must be present');
const blockquotes = extractBlockquotes(reportStep);
assert.ok(
blockquotes.length > 0,
'report step should contain at least one blockquote (the context-authority directive)'
);
const authorityBlock = blockquotes.find((b) => /context\s+authority/i.test(b));
assert.ok(
authorityBlock,
'report step should contain a blockquote whose text includes "Context authority"'
);
});
test('context-authority directive names PROJECT.md, STATE.md, and ROADMAP.md as authoritative', () => {
const workflow = fs.readFileSync(WORKFLOW_PATH, 'utf8');
const reportStep = extractStep(workflow, 'report');
assert.ok(reportStep, 'report step must exist');
const blockquotes = extractBlockquotes(reportStep);
const authorityBlock = blockquotes.find((b) => /context\s+authority/i.test(b));
assert.ok(authorityBlock, 'authority blockquote must exist');
assert.match(
authorityBlock,
/PROJECT\.md/,
'directive should name PROJECT.md as authoritative'
);
assert.match(
authorityBlock,
/STATE\.md/,
'directive should name STATE.md as authoritative'
);
assert.match(
authorityBlock,
/ROADMAP\.md/,
'directive should name ROADMAP.md as authoritative'
);
assert.match(
authorityBlock,
/authoritative/i,
'directive should describe these files as authoritative'
);
});
test('context-authority directive forbids using CLAUDE.md project block as a source', () => {
const workflow = fs.readFileSync(WORKFLOW_PATH, 'utf8');
const reportStep = extractStep(workflow, 'report');
assert.ok(reportStep, 'report step must exist');
const blockquotes = extractBlockquotes(reportStep);
const authorityBlock = blockquotes.find((b) => /context\s+authority/i.test(b));
assert.ok(authorityBlock, 'authority blockquote must exist');
assert.match(
authorityBlock,
/CLAUDE\.md/,
'directive should explicitly mention CLAUDE.md'
);
// Must explicitly forbid CLAUDE.md as a source — look for a NOT/do not directive
// co-located with the CLAUDE.md mention.
assert.match(
authorityBlock,
/(do\s+NOT|do\s+not|must\s+NOT|must\s+not|never)/i,
'directive should contain an explicit prohibition (do NOT / must not / never)'
);
assert.match(
authorityBlock,
/## Project/,
'directive should call out the CLAUDE.md "## Project" block specifically'
);
});
});