e50ad8127f
* fix(3696): pr-template enforcer recognises CI/tooling carve-out The enforcer in scripts/pr-template-policy.cjs only validated against three typed templates and three hard-coded DEFAULT_TEMPLATE_MARKERS. It had zero awareness of the documented CI/tooling/dep/doc-only exception in .github/pull_request_template.md, meaning external contributors who followed the documented escape hatch still had their PRs auto-closed. Fix: 1. Path-scope auto-skip: if every changed file matches a tooling glob allowlist (.github/**, scripts/**, docs/**, *.md, .changeset/**, dependency manifests), skip enforcement and exit success with no comment posted. 2. Explicit exemption marker: if the PR body contains <!-- pr-template-exempt: <non-empty reason> -->, skip enforcement. 3. Workflow updated to fetch changed file paths via gh and pass them as CHANGED_FILES env to the policy script. 4. Pull request template updated to document both mechanisms and retire the old "delete this file" prose carve-out. 5. 14 new tests (TDD red→green); all 25 tests pass. Closes #3696 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(3696): allow hyphenated pr-template exemption reasons --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
42 lines
1.9 KiB
Markdown
42 lines
1.9 KiB
Markdown
## ⚠️ Wrong template — please use the correct one for your PR type
|
|
|
|
Every PR must use a typed template. Using this default template is a reason for rejection.
|
|
|
|
Select the template that matches your PR:
|
|
|
|
| PR Type | When to use | Template link |
|
|
|---------|-------------|---------------|
|
|
| **Fix** | Correcting a bug, crash, or behavior that doesn't match documentation | [Use fix template](?template=PULL_REQUEST_TEMPLATE/fix.md) |
|
|
| **Enhancement** | Improving an existing feature — better output, expanded edge cases, performance | [Use enhancement template](?template=PULL_REQUEST_TEMPLATE/enhancement.md) |
|
|
| **Feature** | Adding something new — new command, workflow, concept, or integration | [Use feature template](?template=PULL_REQUEST_TEMPLATE/feature.md) |
|
|
|
|
---
|
|
|
|
### Not sure which type applies?
|
|
|
|
- If it **corrects broken behavior** → Fix
|
|
- If it **improves existing behavior** without adding new commands or concepts → Enhancement
|
|
- If it **adds something that doesn't exist today** → Feature
|
|
- If you are not sure → open a [Discussion](https://github.com/gsd-build/get-shit-done/discussions) first
|
|
|
|
---
|
|
|
|
### Reminder: Issues must be approved before PRs
|
|
|
|
For **enhancements**: the linked issue must have the `approved-enhancement` label before you open this PR.
|
|
|
|
For **features**: the linked issue must have the `approved-feature` label before you open this PR.
|
|
|
|
PRs that arrive without a labeled, approved issue are closed without review.
|
|
|
|
> **No draft PRs.** Draft PRs are automatically closed. Only open a PR when your code is complete, tests pass, and the correct template is used. See [CONTRIBUTING.md](../CONTRIBUTING.md).
|
|
|
|
See [CONTRIBUTING.md](../CONTRIBUTING.md) for the full process.
|
|
|
|
---
|
|
|
|
<!-- CI/tooling, dependency, and doc-only PRs are auto-detected from the changed file paths — no template
|
|
needed. For other cross-cutting exempt PRs, paste the line below into your PR body with a non-empty reason:
|
|
<!-- pr-template-exempt: <reason> -->
|
|
|