* enhancement(#558): add liveness hints to all GSD spawn announcements Append '(runs in a subagent — no output until it returns, ~1–5 min; expected, not a freeze)' inline to every ◆ Spawning… banner and subagent dispatch instruction across 26 workflows. Silent subagents look identical to frozen sessions — this note sets the expectation so users wait instead of killing healthy in-progress work. Changes: - references/ui-brand.md: document liveness convention under Spawning Indicators - 10 banner workflows: append liveness note to ◆ Spawning… lines in-place - 18 subagent-only workflows: add print instruction with liveness phrase - tests/spawn-liveness-banner.test.cjs: new test; fails if any workflow with subagent_type omits 'runs in a subagent' - docs/USER-GUIDE.md: troubleshooting entry for frozen-looking spawns - .changeset/558-spawn-liveness-banner.md: changeset fragment Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(#558): add missing pr field to changeset fragment The changeset lint requires pr: <NNN> in frontmatter; the fragment was written without it, causing parse.cjs to reject it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(#558): address codex review — missed spawns and tighten test - plan-phase.md: add liveness note to chunked outline planner and per-plan chunked planner banners (two missed ◆ Spawning… lines) - quick.md: add liveness note to research banner and add missing display line before planner spawn in Step 5 - plan-review-convergence.md: add liveness note to initial planning and review-agent spawn Display lines - docs-update.md: add Print instructions with liveness note before gsd-doc-verifier spawns in Phase 1 and Phase 2 - autonomous.md: add Print instruction with liveness note before background plan-phase agent dispatch in step 3b - tests/spawn-liveness-banner.test.cjs: replace single file-level check with two assertions: (1) every ◆ Spawning… banner line carries the phrase on that line (2) every file with subagent_type contains the phrase somewhere The tighter test would have caught all five missed spawns. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(#558): tighten spawn-liveness test regex to catch spawn-word-anywhere variants Previous SPAWN_BANNER_RE only matched ◆ immediately followed by Spawning|spawning. Replace with /◆[^\n]*\bspawning?\b/i which matches the spawn word anywhere on the ◆ line — catching "◆ Chunked mode: spawning outline planner..." and similar. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(#558): rename changeset to PR number 566 and correct pr field Changeset was filed as 558-spawn-liveness-banner.md (issue#) but the convention is the PR number. Renamed to 566-spawn-liveness-banner.md and updated pr: 558 → pr: 566 so release notes link to the right PR. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
157 lines
6.1 KiB
Markdown
157 lines
6.1 KiB
Markdown
<purpose>
|
||
Retroactive audit of an implemented AI phase's evaluation coverage. Standalone command that works on any GSD-managed AI phase. Produces a scored EVAL-REVIEW.md with gap analysis and remediation plan.
|
||
|
||
Use after /gsd:execute-phase to verify that the evaluation strategy from AI-SPEC.md was actually implemented. Mirrors the pattern of /gsd:ui-review and /gsd:validate-phase.
|
||
</purpose>
|
||
|
||
<required_reading>
|
||
@~/.claude/get-shit-done/references/ai-evals.md
|
||
</required_reading>
|
||
|
||
<process>
|
||
|
||
## 0. Initialize
|
||
|
||
```bash
|
||
_GSD_SHIM_NAME="gsd-tools.cjs"; _GSD_RUNTIME_ROOT="${RUNTIME_DIR:-$(git rev-parse --show-toplevel 2>/dev/null || pwd)}"; GSD_TOOLS="${_GSD_RUNTIME_ROOT}/get-shit-done/bin/${_GSD_SHIM_NAME}"; if [ -f "$GSD_TOOLS" ]; then gsd_run() { node "$GSD_TOOLS" "$@"; }; elif [ -f "${_GSD_RUNTIME_ROOT}/.claude/get-shit-done/bin/${_GSD_SHIM_NAME}" ]; then GSD_TOOLS="${_GSD_RUNTIME_ROOT}/.claude/get-shit-done/bin/${_GSD_SHIM_NAME}"; gsd_run() { node "$GSD_TOOLS" "$@"; }; elif command -v gsd-tools >/dev/null 2>&1; then GSD_TOOLS="$(command -v gsd-tools)"; gsd_run() { "$GSD_TOOLS" "$@"; }; elif [ -f "$HOME/.claude/get-shit-done/bin/${_GSD_SHIM_NAME}" ]; then GSD_TOOLS="$HOME/.claude/get-shit-done/bin/${_GSD_SHIM_NAME}"; gsd_run() { node "$GSD_TOOLS" "$@"; }; else echo "ERROR: gsd-tools.cjs not found at $GSD_TOOLS and gsd-tools is not on PATH. Run: npx -y @opengsd/gsd-core@latest --claude --local" >&2; exit 1; fi
|
||
INIT=$(gsd_run query init.phase-op "${PHASE_ARG}")
|
||
if [[ "$INIT" == @file:* ]]; then INIT=$(cat "${INIT#@file:}"); fi
|
||
```
|
||
|
||
Parse: `phase_dir`, `phase_number`, `phase_name`, `phase_slug`, `padded_phase`, `commit_docs`.
|
||
|
||
```bash
|
||
AUDITOR_MODEL=$(gsd_run query resolve-model gsd-eval-auditor 2>/dev/null | jq -r '.model' 2>/dev/null || true)
|
||
```
|
||
|
||
Display banner:
|
||
```
|
||
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
||
GSD ► EVAL AUDIT — PHASE {N}: {name}
|
||
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
||
```
|
||
|
||
## 1. Detect Input State
|
||
|
||
```bash
|
||
SUMMARY_FILES=$(ls "${PHASE_DIR}"/*-SUMMARY.md 2>/dev/null)
|
||
AI_SPEC_FILE=$(ls "${PHASE_DIR}"/*-AI-SPEC.md 2>/dev/null | head -1)
|
||
EVAL_REVIEW_FILE=$(ls "${PHASE_DIR}"/*-EVAL-REVIEW.md 2>/dev/null | head -1)
|
||
```
|
||
|
||
**State A** — AI-SPEC.md + SUMMARY.md exist: Full audit against spec
|
||
**State B** — SUMMARY.md exists, no AI-SPEC.md: Audit against general best practices
|
||
**State C** — No SUMMARY.md: Exit — "Phase {N} not executed. Run /gsd:execute-phase {N} first."
|
||
|
||
|
||
**Text mode (`workflow.text_mode: true` in config or `--text` flag):** Set `TEXT_MODE=true` if `--text` is present in `$ARGUMENTS` OR `text_mode` from init JSON is `true`. When TEXT_MODE is active, replace every `AskUserQuestion` call with a plain-text numbered list and ask the user to type their choice number. This is required for non-Claude runtimes (OpenAI Codex, Gemini CLI, etc.) where `AskUserQuestion` is not available.
|
||
**If `EVAL_REVIEW_FILE` non-empty:** Use AskUserQuestion:
|
||
- header: "Existing Eval Review"
|
||
- question: "EVAL-REVIEW.md already exists for Phase {N}."
|
||
- options:
|
||
- "Re-audit — run fresh audit"
|
||
- "View — display current review and exit"
|
||
|
||
If "View": display file, exit.
|
||
If "Re-audit": continue.
|
||
|
||
**If State B (no AI-SPEC.md):** Warn:
|
||
```
|
||
No AI-SPEC.md found for Phase {N}.
|
||
Audit will evaluate against general AI eval best practices rather than a phase-specific plan.
|
||
Consider running /gsd:ai-integration-phase {N} before implementation next time.
|
||
```
|
||
Continue (non-blocking).
|
||
|
||
## 2. Gather Context Paths
|
||
|
||
Build file list for auditor:
|
||
- AI-SPEC.md (if exists — the planned eval strategy)
|
||
- All SUMMARY.md files in phase dir
|
||
- All PLAN.md files in phase dir
|
||
|
||
## 3. Spawn gsd-eval-auditor
|
||
|
||
```
|
||
◆ Spawning eval auditor... (runs in a subagent — no output until it returns, ~1–5 min; expected, not a freeze)
|
||
```
|
||
|
||
Build prompt:
|
||
|
||
```markdown
|
||
Read ~/.claude/agents/gsd-eval-auditor.md for instructions.
|
||
|
||
<objective>
|
||
Conduct evaluation coverage audit of Phase {phase_number}: {phase_name}
|
||
{If AI-SPEC exists: "Audit against AI-SPEC.md evaluation plan."}
|
||
{If no AI-SPEC: "Audit against general AI eval best practices."}
|
||
</objective>
|
||
|
||
<files_to_read>
|
||
- {summary_paths}
|
||
- {plan_paths}
|
||
- {ai_spec_path if exists}
|
||
</files_to_read>
|
||
|
||
<input>
|
||
ai_spec_path: {ai_spec_path or "none"}
|
||
phase_dir: {phase_dir}
|
||
phase_number: {phase_number}
|
||
phase_name: {phase_name}
|
||
padded_phase: {padded_phase}
|
||
state: {A or B}
|
||
</input>
|
||
```
|
||
|
||
Spawn as Task with model `AUDITOR_MODEL`.
|
||
|
||
## 4. Parse Auditor Result
|
||
|
||
Read the written EVAL-REVIEW.md. Extract:
|
||
- `overall_score`
|
||
- `verdict` (PRODUCTION READY | NEEDS WORK | SIGNIFICANT GAPS | NOT IMPLEMENTED)
|
||
- `critical_gap_count`
|
||
|
||
## 5. Display Summary
|
||
|
||
```
|
||
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
||
GSD ► EVAL AUDIT COMPLETE — PHASE {N}: {name}
|
||
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
|
||
|
||
◆ Score: {overall_score}/100
|
||
◆ Verdict: {verdict}
|
||
◆ Critical Gaps: {critical_gap_count}
|
||
◆ Output: {eval_review_path}
|
||
|
||
{If PRODUCTION READY:}
|
||
Next step: /gsd:plan-phase (next phase) or deploy
|
||
|
||
{If NEEDS WORK:}
|
||
Address critical gaps in EVAL-REVIEW.md, then re-run /gsd:eval-review {N}
|
||
|
||
{If SIGNIFICANT GAPS or NOT IMPLEMENTED:}
|
||
Review AI-SPEC.md evaluation plan. Critical eval dimensions are not implemented.
|
||
Do not deploy until gaps are addressed.
|
||
```
|
||
|
||
## 6. Commit
|
||
|
||
**If `commit_docs` is true:**
|
||
```bash
|
||
git add "${EVAL_REVIEW_FILE}"
|
||
git commit -m "docs({phase_slug}): add EVAL-REVIEW.md — score {overall_score}/100 ({verdict})"
|
||
```
|
||
|
||
</process>
|
||
|
||
<success_criteria>
|
||
- [ ] Phase execution state detected correctly
|
||
- [ ] AI-SPEC.md presence handled (with or without)
|
||
- [ ] gsd-eval-auditor spawned with correct context
|
||
- [ ] EVAL-REVIEW.md written (by auditor)
|
||
- [ ] Score and verdict displayed to user
|
||
- [ ] Appropriate next steps surfaced based on verdict
|
||
- [ ] Committed if commit_docs enabled
|
||
</success_criteria>
|