Tom Boucher
f55069ecbf
test( #2974 ): migrate 8 test files to typed-IR assertions ( #3016 )
...
* test(#2974 ): migrate 8 test files to typed-IR assertions
Replaces raw stdout/stderr substring matching with structured-field
assertions per CONTRIBUTING.md "Prohibited: Raw Text Matching on Test
Outputs". Adds shared infrastructure for typed error emission so this
pattern is the easy path going forward.
Shared infrastructure:
- core.cjs: ERROR_REASON frozen enum + setJsonErrorMode/getJsonErrorMode
- gsd-tools.cjs: --json-errors CLI flag, parsed before subcommand dispatch
- config.cjs: typed reasons at all 7 error sites
- graphify.cjs: GRAPHIFY_REASON enum + reason/timeout_ms in execGraphify result
- bin/install.js: pure buildSdkFailFastReport() IR builder + renderer
- hooks/gsd-session-state.sh, gsd-phase-boundary.sh: emit Claude Code
hookSpecificOutput JSON envelope with typed state_present/config_mode/
planning_modified/file_path fields (no-op when hooks.community is off)
Test migrations (all pass, 171 tests across the 8 files):
- bug-2649-sdk-fail-fast: assert on ir.reason / ir.context / ir.fix_command
- bug-2687-config-read-warning-parity: assert.equal stderr === ''
- bug-2796-arg-parsing-regression: assert on result.json.updated/.phase
- bug-2838-summary-rescue: parse rescue footer, assert mtime invariant
- bug-2943-config-get-context-window: parse JSON, assert ERROR_REASON.CONFIG_KEY_NOT_FOUND
- graphify: assert reason === GRAPHIFY_REASON.ENOENT/TIMEOUT
- hooks-opt-in: parse hookSpecificOutput, assert typed fields
- security-scan: reclassified as source-text-is-the-product (scan label
output and CI workflow YAML ARE the deployed contract)
Verification: lint-no-source-grep clean (0 violations), full suite
6741/6741 pass.
Closes #2974
* test(#2974 ): address CR feedback — typed code field, robust idempotency
Two CodeRabbit findings on #3016 addressed:
1. tests/hooks-opt-in.test.cjs:355 (Minor, inline) —
parsed.reason.includes('Conventional Commits') was still substring
matching after the typed-IR migration. Fixed at the source: the
gsd-validate-commit hook now emits a typed `code` field
('CONVENTIONAL_COMMITS_VIOLATION', 'COMMIT_SUBJECT_TOO_LONG')
alongside the human-readable `reason`. Test asserts strictEqual
on the code; the prose copy is no longer part of the test contract.
2. tests/bug-2838-summary-rescue-gitignored-planning.test.cjs:224-250
(Outside-diff) — mtimeMs alone can stay unchanged on coarse-grained
filesystems (HFS+, FAT) when two rewrites land within the same
timestamp tick, falsely passing the idempotency assertion.
Replaced with a full snapshot (mtimeMs, ctimeMs, size, ino, sha256
of contents) compared via assert.deepStrictEqual — the hash
catches any rewrite the timestamp would miss.
Verification: 30/30 pass on the two affected files; lint-no-source-grep
clean (0 violations across 368 test files).
2026-05-02 09:27:23 -04:00
..
2026-04-25 10:50:54 -04:00
2026-04-04 14:29:03 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-25 10:50:54 -04:00
2026-04-11 03:39:29 -07:00
2026-04-20 09:31:34 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-11 03:30:05 -07:00
2026-04-07 17:27:20 -04:00
2026-05-01 19:50:10 -04:00
2026-04-04 14:29:03 -04:00
2026-04-25 10:50:54 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-04 07:24:31 -04:00
2026-04-11 08:50:44 -04:00
2026-04-07 08:13:52 -04:00
2026-04-05 17:49:20 -04:00
2026-04-05 17:32:18 -04:00
2026-04-05 18:05:32 -04:00
2026-04-05 18:20:11 -04:00
2026-04-19 16:35:32 -05:00
2026-04-25 11:34:55 -04:00
2026-04-22 12:04:06 -04:00
2026-04-07 17:19:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-10 10:48:00 -04:00
2026-05-01 19:50:10 -04:00
2026-04-11 03:37:34 -07:00
2026-04-10 10:50:17 -04:00
2026-04-10 11:19:32 -04:00
2026-04-10 11:25:55 -04:00
2026-04-10 11:15:59 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-15 14:58:41 -04:00
2026-04-23 11:58:06 -04:00
2026-04-17 09:20:26 -04:00
2026-04-25 10:50:54 -04:00
2026-04-22 10:41:58 -04:00
2026-04-25 12:02:58 -04:00
2026-04-17 09:20:42 -04:00
2026-04-29 07:56:51 -04:00
2026-04-20 18:37:42 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-20 10:09:33 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-30 00:43:47 -04:00
2026-05-01 19:50:10 -04:00
2026-04-20 10:11:00 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-20 10:08:46 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-21 09:46:01 -04:00
2026-05-01 19:50:10 -04:00
2026-04-21 21:20:27 -04:00
2026-04-21 10:10:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-22 12:09:12 -04:00
2026-04-22 10:41:58 -04:00
2026-04-21 20:33:43 -04:00
2026-05-01 19:50:10 -04:00
2026-04-21 21:18:58 -04:00
2026-04-22 11:28:25 -04:00
2026-04-29 22:56:59 -04:00
2026-04-22 12:04:17 -04:00
2026-05-01 19:50:10 -04:00
2026-04-22 12:03:56 -04:00
2026-04-22 12:04:06 -04:00
2026-05-01 19:50:10 -04:00
2026-04-25 12:09:27 -04:00
2026-04-24 18:05:10 -04:00
2026-04-24 18:10:45 -04:00
2026-04-24 18:05:33 -04:00
2026-04-29 22:56:59 -04:00
2026-04-24 18:05:18 -04:00
2026-05-02 09:27:23 -04:00
2026-04-24 20:22:17 -04:00
2026-04-24 20:22:29 -04:00
2026-05-01 19:50:10 -04:00
2026-04-25 12:10:01 -04:00
2026-04-25 12:16:04 -04:00
2026-04-25 12:10:01 -04:00
2026-04-25 12:15:39 -04:00
2026-05-02 09:27:23 -04:00
2026-05-01 19:50:10 -04:00
2026-04-28 18:28:53 -04:00
2026-04-27 12:31:43 -04:00
2026-04-27 12:31:49 -04:00
2026-05-01 19:50:10 -04:00
2026-04-27 12:31:15 -04:00
2026-05-01 19:50:10 -04:00
2026-04-27 12:31:26 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-28 20:37:47 -04:00
2026-04-28 20:22:59 -04:00
2026-04-28 20:23:32 -04:00
2026-04-28 20:16:27 -04:00
2026-05-02 09:27:23 -04:00
2026-04-28 20:21:44 -04:00
2026-04-29 21:52:20 -04:00
2026-04-28 20:21:48 -04:00
2026-04-28 20:23:29 -04:00
2026-05-01 19:50:10 -04:00
2026-04-29 07:59:30 -04:00
2026-05-01 19:50:10 -04:00
2026-04-29 08:00:17 -04:00
2026-05-02 09:27:23 -04:00
2026-04-29 07:56:32 -04:00
2026-04-29 21:52:20 -04:00
2026-04-29 21:51:58 -04:00
2026-04-29 23:27:27 -04:00
2026-04-30 17:30:19 -04:00
2026-04-30 21:08:26 -04:00
2026-04-30 21:57:27 -04:00
2026-05-01 09:23:02 -04:00
2026-05-01 09:22:13 -04:00
2026-05-02 09:27:23 -04:00
2026-05-01 11:25:26 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 11:25:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 13:04:39 -04:00
2026-05-01 16:10:30 -04:00
2026-05-01 17:25:20 -04:00
2026-05-01 15:15:20 -04:00
2026-05-01 15:15:20 -04:00
2026-05-02 00:29:34 -04:00
2026-05-02 00:29:45 -04:00
2026-05-02 00:40:09 -04:00
2026-05-01 17:25:20 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 17:25:20 -04:00
2026-05-01 21:13:25 -04:00
2026-05-01 17:39:35 -04:00
2026-05-02 00:29:43 -04:00
2026-05-02 00:29:31 -04:00
2026-05-02 00:29:34 -04:00
2026-05-02 00:29:34 -04:00
2026-05-01 21:14:14 -04:00
2026-05-01 19:50:10 -04:00
2026-04-23 08:36:03 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 18:12:20 -04:00
2026-05-01 18:12:20 -04:00
2026-05-01 18:12:20 -04:00
2026-05-01 18:12:20 -04:00
2026-05-01 18:12:20 -04:00
2026-05-01 18:12:20 -04:00
2026-05-01 19:50:10 -04:00
2026-04-11 09:15:36 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-20 09:31:34 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-12 08:10:30 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-29 22:56:59 -04:00
2026-05-01 19:50:10 -04:00
2026-04-05 17:02:20 -04:00
2026-04-10 10:56:09 -04:00
2026-05-01 19:50:10 -04:00
2026-04-25 11:34:55 -04:00
2026-04-07 17:25:11 -04:00
2026-05-01 19:50:10 -04:00
2026-04-24 18:05:16 -04:00
2026-04-15 16:46:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-30 01:04:41 -04:00
2026-04-29 23:27:27 -04:00
2026-05-01 19:50:10 -04:00
2026-04-11 09:20:27 -04:00
2026-04-04 14:29:03 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-05 09:15:41 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-25 11:34:55 -04:00
2026-05-01 19:50:10 -04:00
2026-04-27 09:03:36 -04:00
2026-04-01 08:47:31 -06:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-25 16:26:15 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-25 14:23:40 -04:00
2026-04-22 12:04:21 -04:00
2026-04-29 08:14:11 -04:00
2026-04-30 01:04:41 -04:00
2026-04-30 01:04:41 -04:00
2026-04-30 00:48:49 -04:00
2026-05-01 19:50:10 -04:00
2026-04-25 12:04:16 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-22 20:49:52 -04:00
2026-04-05 18:33:17 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-26 21:40:38 -04:00
2026-05-01 19:50:10 -04:00
2026-04-30 00:57:17 -04:00
2026-05-02 09:27:23 -04:00
2026-05-01 19:50:10 -04:00
2026-04-30 14:04:50 -04:00
2026-05-01 19:50:10 -04:00
2026-04-20 10:08:46 -04:00
2026-04-15 22:46:31 -04:00
2026-04-04 14:37:54 -04:00
2026-04-04 14:29:03 -04:00
2026-04-29 23:27:27 -04:00
2026-04-30 22:48:08 -04:00
2026-05-01 19:50:10 -04:00
2026-04-04 14:29:03 -04:00
2026-04-20 09:31:34 -04:00
2026-05-02 09:27:23 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-15 14:59:07 -04:00
2026-04-17 09:20:26 -04:00
2026-04-27 12:31:49 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 09:23:20 -04:00
2026-05-01 22:37:48 -04:00
2026-04-23 11:53:51 -04:00
2026-04-15 14:59:24 -04:00
2026-05-01 19:50:10 -04:00
2026-04-20 09:39:05 -04:00
2026-04-20 09:39:05 -04:00
2026-05-01 19:50:10 -04:00
2026-04-26 13:33:54 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-05 19:09:14 -04:00
2026-04-30 11:38:13 -04:00
2026-04-14 17:57:38 -04:00
2026-05-01 19:50:10 -04:00
2026-04-04 14:29:03 -04:00
2026-05-01 19:50:10 -04:00
2026-04-25 11:34:55 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-26 11:48:47 -04:00
2026-04-25 12:09:27 -04:00
2026-04-30 22:48:08 -04:00
2026-04-05 18:05:32 -04:00
2026-04-07 08:13:46 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 16:10:30 -04:00
2026-05-01 19:50:10 -04:00
2026-04-25 11:34:55 -04:00
2026-05-01 19:50:10 -04:00
2026-04-06 15:13:23 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-16 17:15:29 -04:00
2026-04-04 14:29:03 -04:00
2026-04-11 15:02:55 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-30 14:10:28 -04:00
2026-04-04 14:29:03 -04:00
2026-04-25 12:02:58 -04:00
2026-05-01 19:50:10 -04:00
2026-04-25 14:18:34 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-30 11:38:13 -04:00
2026-05-01 19:50:10 -04:00
2026-04-30 12:13:55 -04:00
2026-04-30 14:19:46 -04:00
2026-04-30 14:19:46 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-04 14:29:03 -04:00
2026-05-01 19:50:10 -04:00
2026-04-16 17:22:31 -04:00
2026-05-01 19:50:10 -04:00
2026-04-17 10:11:08 -04:00
2026-04-30 21:57:27 -04:00
2026-04-04 14:29:03 -04:00
2026-04-05 10:23:41 -04:00
2026-05-01 19:50:10 -04:00
2026-04-11 11:19:47 -04:00
2026-05-01 19:50:10 -04:00
2026-04-04 14:29:03 -04:00
2026-05-01 19:50:10 -04:00
2026-04-16 17:22:31 -04:00
2026-04-30 00:43:47 -04:00
2026-04-30 00:43:47 -04:00
2026-04-26 13:33:45 -04:00
2026-04-30 14:10:28 -04:00
2026-04-23 11:53:20 -04:00
2026-05-01 19:50:10 -04:00
2026-04-15 14:59:56 -04:00
2026-05-01 19:50:10 -04:00
2026-04-01 16:53:20 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-02 09:27:23 -04:00
2026-04-20 10:08:18 -04:00
2026-05-01 19:50:10 -04:00
2026-04-04 07:10:21 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-10 13:55:27 -04:00
2026-04-15 10:35:29 -04:00
2026-04-11 15:02:55 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-11 15:39:50 -04:00
2026-04-11 09:15:00 -04:00
2026-05-01 19:50:10 -04:00
2026-04-05 17:49:20 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-20 10:08:18 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 09:22:13 -04:00
2026-04-30 01:04:41 -04:00
2026-04-12 17:56:19 -04:00
2026-04-25 16:26:15 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-04 14:29:03 -04:00
2026-05-01 19:50:10 -04:00
2026-04-04 14:29:03 -04:00
2026-04-06 08:40:37 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-30 00:43:47 -04:00
2026-04-02 21:36:36 -05:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-05-01 19:50:10 -04:00
2026-04-04 14:29:03 -04:00