71180983a0
* fix(#3423): standardize on required_reading, retire files_to_read emit tag * test(#3423): flip tag assertions, extend consistency guard to spawner surfaces * fix(#3423): sweep capabilities fragments, regen registry+skills, anchor executor test * chore(#3423): acknowledge tag-rename emitted ripples and workflow growth * chore(#3423): broaden emitted-ripple acknowledgment to all embedders * chore(#3423): settle emitted-drift acks post-rebase (merge 3004/1689-owned keys) * chore(#3423): drop stale ripple acks, ack execute-phase growth * chore(#3423): restore pristine 3004 fragment, keep only consumed appends * chore(#3423): backfill changeset pr number * chore(#3423): settle emitted-drift acks post-merge (move code-review-fix ripple into 3190, tag-rename ripples into 3191/3297) * chore(#3423): re-arm 3324 ack for execute-phase.md tag-rename ripple * fix(#3423): trim 8 bytes from execute-phase model note to hold ADR-857 margin, re-arm 3370 ack for net +4 growth --------- Co-authored-by: sim <sim@local>
60 lines
2.7 KiB
Markdown
60 lines
2.7 KiB
Markdown
---
|
|
name: gsd:code-review
|
|
description: Review source files changed during a phase for bugs, security issues, and code quality problems
|
|
argument-hint: "<phase-number> [--depth=quick|standard|deep] [--files file1,file2,...] [--fix [--all] [--auto]]"
|
|
allowed-tools:
|
|
- Read
|
|
- Bash
|
|
- Glob
|
|
- Grep
|
|
- Write
|
|
- Agent
|
|
requires: [config, import, phase, quick, review]
|
|
---
|
|
<objective>
|
|
Review source files changed during a phase for bugs, security vulnerabilities, and code quality problems.
|
|
|
|
Spawns the gsd-code-reviewer agent to analyze code at the specified depth level. Produces REVIEW.md artifact in the phase directory with severity-classified findings.
|
|
|
|
Arguments:
|
|
- Phase number (required) — which phase's changes to review (e.g., "2" or "02")
|
|
- `--depth=quick|standard|deep` (optional) — review depth level, overrides workflow.code_review_depth config
|
|
- quick: Pattern-matching only (~2 min)
|
|
- standard: Per-file analysis with language-specific checks (~5-15 min, default)
|
|
- deep: Cross-file analysis including import graphs and call chains (~15-30 min)
|
|
- `--files file1,file2,...` (optional) — explicit comma-separated file list, skips SUMMARY/git scoping (highest precedence for scoping)
|
|
- `--fix` (optional) — after review completes (or if REVIEW.md already exists), auto-apply fixes found. Spawns gsd-code-fixer agent. Accepts sub-flags:
|
|
- `--all` — include Info findings in fix scope (default: Critical + Warning only)
|
|
- `--auto` — enable fix + re-review iteration loop, capped at 3 iterations
|
|
|
|
Output: {padded_phase}-REVIEW.md in phase directory + inline summary of findings
|
|
</objective>
|
|
|
|
<execution_context>
|
|
@~/.claude/gsd-core/workflows/code-review.md
|
|
</execution_context>
|
|
|
|
<context>
|
|
Phase: $ARGUMENTS (first positional argument is phase number)
|
|
|
|
Optional flags parsed from $ARGUMENTS:
|
|
- `--depth=VALUE` — Depth override (quick|standard|deep). If provided, overrides workflow.code_review_depth config.
|
|
- `--files=file1,file2,...` — Explicit file list override. Has highest precedence for file scoping per D-08. When provided, workflow skips SUMMARY.md extraction and git diff fallback entirely.
|
|
|
|
Context files (CLAUDE.md, SUMMARY.md, phase state) are resolved inside the workflow via `gsd-tools query init.phase-op` and delegated to agent via `<required_reading>` blocks.
|
|
</context>
|
|
|
|
<process>
|
|
This command is a thin dispatch layer. It parses arguments and delegates to the workflow.
|
|
|
|
Execute end-to-end.
|
|
|
|
The workflow (not this command) enforces these gates:
|
|
- Phase validation (before config gate)
|
|
- Config gate check (workflow.code_review)
|
|
- File scoping (--files override > SUMMARY.md > git diff fallback)
|
|
- Empty scope check (skip if no files)
|
|
- Agent spawning (gsd-code-reviewer)
|
|
- Result presentation (inline summary + next steps)
|
|
</process>
|