Tom Boucher 9ade7926ca test(#3761): replace vacuous wave/files_modified gate with an anchored one (#3764) ...

The test 'planner has validation step or quality gate for wave/files_modified
consistency' asserted a six-token disjunction over whole-file substrings, five
of which occur ZERO times in agents/gsd-planner.md (validate_waves,
wave_validation, same wave — the last killing the entire quality-gate arm,
since that file has no quality_gate block). The sixth matched one incidental
pseudocode comment, so deleting the wave-ordering gate outright left the suite
green.

Per RULESET.TESTS.delete-bad-tests (CONTEXT.md:595) the vacuous test is DELETED
and replaced, not patched. The replacement anchors on the normative **Rule:**
sentence inside <step name="assign_waves"> — scoped to that step rather than to
the whole document, and requiring all four semantic clauses (wave scope,
files_modified subject, prohibition, overlap predicate) to hold within a single
sentence, so co-occurring words scattered across a paragraph do not pass.

agents/gsd-planner.md is unchanged: the anchor already exists there and survives
PR #3758's edits to the same region.

Teeth proven on the remote runner: a control commit paired these tests with a
deliberately gutted assign_waves step that retained the incidental phrase. The
new anchored test failed while the sibling test using the old predicate's
surviving arm stayed green — same input, opposite verdicts.

Fixes #3761

Co-authored-by: sim <sim@local>

2026-08-22 17:52:23 -04:00

22 KiB

Raw Blame History

View Raw