golem15/summercms
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(10.1): record code review disposition

Browse Source
This commit is contained in:
Jakub Zych
2026-09-29 10:10:45 +02:00
parent c0d16eccc1
commit 0bbbce6d27
1 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
.planning/phases/10.1-runtime-admin-extension-point/10.1-REVIEW-DISPOSITION.md
View File

@@ -5,31 +5,31 @@ titles: json
findings: findings:
- id: CR-01 - id: CR-01
severity: critical severity: critical
disposition: open disposition: fixed
title: "A fractional, exponent or overflowing number for an integer column is a 500, not a validation error" title: "A fractional, exponent or overflowing number for an integer column is a 500, not a validation error"
- id: WR-01 - id: WR-01
severity: warning severity: warning
disposition: open disposition: fixed
title: "A late schema response re-activates the previous controller's stylesheets over the current view" title: "A late schema response re-activates the previous controller's stylesheets over the current view"
- id: WR-02 - id: WR-02
severity: warning severity: warning
disposition: open disposition: fixed
title: "Plugin stylesheets stay enabled on views that are not controller views" title: "Plugin stylesheets stay enabled on views that are not controller views"
- id: WR-03 - id: WR-03
severity: warning severity: warning
disposition: open disposition: fixed
title: "The partial view-model guard (T-10.1-09) is shallow and easy to bypass" title: "The partial view-model guard (T-10.1-09) is shallow and easy to bypass"
- id: WR-04 - id: WR-04
severity: warning severity: warning
disposition: open disposition: fixed
title: "`isJSONScalar` trusts `reflect.Kind`, not the JSON the value encodes to" title: "`isJSONScalar` trusts `reflect.Kind`, not the JSON the value encodes to"
- id: WR-05 - id: WR-05
severity: warning severity: warning
disposition: open disposition: fixed
title: "Form schema shows widgets the admin is not allowed to run" title: "Form schema shows widgets the admin is not allowed to run"
- id: WR-06 - id: WR-06
severity: warning severity: warning
disposition: open disposition: fixed
title: "The widget action route ignores the field's `context`" title: "The widget action route ignores the field's `context`"
- id: IN-01 - id: IN-01
severity: info severity: info
@@ -59,22 +59,22 @@ findings:
severity: info severity: info
disposition: open disposition: open
title: "The `compilePartials` escape check has false positives" title: "The `compilePartials` escape check has false positives"
open: 14 open: 7
total: 14 total: 14
recorded: 2026-09-29T01:29:52.513Z recorded: 2026-09-29T08:10:44.662Z
--- ---
# Phase 10.1: Code Review Disposition # Phase 10.1: Code Review Disposition
| Finding | Severity | Disposition | Source | | Finding | Severity | Disposition | Source |
|---------|----------|-------------|--------| |---------|----------|-------------|--------|
| CR-01 | critical | open | - | | CR-01 | critical | fixed | 10.1-REVIEW-FIX.md |
| WR-01 | warning | open | - | | WR-01 | warning | fixed | 10.1-REVIEW-FIX.md |
| WR-02 | warning | open | - | | WR-02 | warning | fixed | 10.1-REVIEW-FIX.md |
| WR-03 | warning | open | - | | WR-03 | warning | fixed | 10.1-REVIEW-FIX.md |
| WR-04 | warning | open | - | | WR-04 | warning | fixed | 10.1-REVIEW-FIX.md |
| WR-05 | warning | open | - | | WR-05 | warning | fixed | 10.1-REVIEW-FIX.md |
| WR-06 | warning | open | - | | WR-06 | warning | fixed | 10.1-REVIEW-FIX.md |
| IN-01 | info | open | - | | IN-01 | info | open | - |
| IN-02 | info | open | - | | IN-02 | info | open | - |
| IN-03 | info | open | - | | IN-03 | info | open | - |