fix(32.2): WR-03 refuse an unknown MCPGrant.Subject instead of treating it as a user grant

pier now resolves only the empty subject (frontend user grant) and pact.MCPGrantSubjectBackend; any other value is ErrUnauthorized and never reaches the linked-administrator lookup.
This commit is contained in:
Jakub Zych
2026-11-21 09:11:46 +01:00
parent 1dcc2ed06d
commit 19bb3f9485
6 changed files with 18 additions and 6 deletions

View File

@@ -82,6 +82,10 @@ func TestBackendOnlyGrant(t *testing.T) {
"oas_at_no_admin": {Subject: pact.MCPGrantSubjectBackend, ClientID: "c1", TokenID: 5, Scopes: []string{"admin:read"}, ExpiresAt: exp},
"oas_at_linked_user": {UserID: 7, BackendUserID: 42, ClientID: "c1", TokenID: 6, Scopes: []string{"read", "backend"}, ExpiresAt: exp},
"oas_at_no_subject_0": {BackendUserID: 7, ClientID: "c1", TokenID: 7, Scopes: []string{"admin:read"}, ExpiresAt: exp},
// An unknown subject kind is refused even when it names a frontend
// user (and a linked administrator), never read as a user grant.
"oas_at_member": {Subject: "member", UserID: 7, BackendUserID: 42, ClientID: "c1", TokenID: 8, Scopes: []string{"read", "backend"}, ExpiresAt: exp},
"oas_at_backend_": {Subject: "Backend", UserID: 7, BackendUserID: 42, ClientID: "c1", TokenID: 9, Scopes: []string{"read"}, ExpiresAt: exp},
}
links := &countingLinks{admin: 42}
r := newIdentityResolver(grantApp(t, verifier, links), Config{}, "user")
@@ -129,7 +133,7 @@ func TestBackendOnlyGrant(t *testing.T) {
t.Fatalf("the linked-backend resolver was called %d times", n)
}
for _, raw := range []string{"oas_at_user_too", "oas_at_no_admin", "oas_at_no_subject_0", "oas_at_unknown"} {
for _, raw := range []string{"oas_at_user_too", "oas_at_no_admin", "oas_at_no_subject_0", "oas_at_member", "oas_at_backend_", "oas_at_unknown"} {
if _, err := r.resolve(ctx, raw); !errors.Is(err, ErrUnauthorized) {
t.Fatalf("%s: err = %v, want ErrUnauthorized", raw, err)
}