golem15/summercms
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(17-06): deferred items from the unit tests plan

Browse Source
This commit is contained in:
Jakub Zych
2026-10-12 19:51:33 +02:00
parent 2274cd6b9b
commit 31adf71b82
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.planning/phases/17-blog-companions/deferred-items.md
View File

@@ -26,3 +26,8 @@ Out-of-scope findings logged during execution. None blocks the plan that found i
1. **Every public Go response sets the translate locale cookie.** On UAT, `/sitemap.xml`, `/_journal/api/v1/...` and the new `/_menu/api/v1/...` all answer `Set-Cookie: golem15.translate.locale=en; Path=/; Max-Age=31536000; HttpOnly` (Secure behind HTTPS), although the site's only enabled locale is `pl`. Pre-existing translate middleware behaviour (the Journal API had it before Phase 17); the Nuxt layers' SSR fetches ignore it, but browsers that call `/_menu/` or `/_faq/` and crawlers reading the sitemap receive it. Follow-up in sm-translate-plugin: set the cookie only when a request chose a locale, and never on anonymous read APIs or the sitemap.
2. **Sitemap `lastmod` of imported Journal rows is the import time.** The Go sitemap's post and category `lastmod` come from `updated_at`, which the Phase 16 import set to 2026-10-09; the PHP sitemap shows the PHP edit times. Corrects itself as posts are edited; a one-off copy of the PHP `updated_at` values would align it before the production cutover.
## From 17-06 (unit tests and the phase gate)
1. **The singleton first-open race fix is unreleased.** `fix(17-06)` 6312929 (cabana `singletonRoute` reruns its transaction once after a unique violation from `SingletonRecord`) is framework production code after v0.1.23. It reaches the sitemap definition admin only with the next framework tag and the plugins' and host's require bump.
2. **Protocol-relative menu URLs are links, not text.** Plan 06's layer behaviour list said a protocol-relative URL to a foreign host gives text without href. The shipped rule is D-16's: the server's `AllowedURL` accepts any URL starting with `/`, and vue-menu-layer renders `//host/...` (and `/\host/...`) as a plain anchor, the same as `https://host/...`, never as a router link and never active. The new layer tests pin the shipped rule. If the stricter rule is wanted, the menu plugin's `AllowedURL` and the layer's `isAllowedUrl` change together (a menu plugin push with a host bump, and a layer tag).