golem15/summercms
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(12-04): require every album broadcast golden to pass

Browse Source 
All four goldens run through the album handlers now: no pending skip is expected
and the named check requires created and updated to pass.
This commit is contained in:
Jakub Zych
2026-10-02 14:30:13 +02:00
parent 7ac6c05ab3
commit 6649763590
3 changed files with 9 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
scripts/check-phase10.1.sh
View File

@@ -21,10 +21,9 @@ APP_PLUGINS=(./plugins/golem15/fonoteka/... ./plugins/golem15/user/...)
KNOWN_APP_FAILURES="" KNOWN_APP_FAILURES=""
# Phase 11 (11-06) records the created/updated broadcast goldens from PHP and # Phase 11 (11-06) records the created/updated broadcast goldens from PHP and
# reports them as skipped until Phase 12 asserts them; check-phase11.sh # reports them as skipped until Phase 12 asserts them; check-phase11.sh
# requires exactly these skips with this text. Phase 12 (12-04) asserts the # requires exactly these skips with this text. Phase 12 (12-04) asserts all
# created golden through the album store handler; updated stays pending # four goldens through the album handlers, so no skip is expected any more.
# until the update handler lands. APP_PENDING_SKIPS=""
APP_PENDING_SKIPS="TestBroadcastGoldens/updated"
APP_PENDING_TEXT="pending: Phase 12" APP_PENDING_TEXT="pending: Phase 12"
usage() { usage() {

7
scripts/check-phase10.sh
View File

@@ -20,10 +20,9 @@ APP_PLUGINS=(./plugins/golem15/fonoteka/... ./plugins/golem15/user/...)
KNOWN_APP_FAILURES="" KNOWN_APP_FAILURES=""
# Phase 11 (11-06) records the created/updated broadcast goldens from PHP and # Phase 11 (11-06) records the created/updated broadcast goldens from PHP and
# reports them as skipped until Phase 12 asserts them; check-phase11.sh # reports them as skipped until Phase 12 asserts them; check-phase11.sh
# requires exactly these skips with this text. Phase 12 (12-04) asserts the # requires exactly these skips with this text. Phase 12 (12-04) asserts all
# created golden through the album store handler; updated stays pending # four goldens through the album handlers, so no skip is expected any more.
# until the update handler lands. APP_PENDING_SKIPS=""
APP_PENDING_SKIPS="TestBroadcastGoldens/updated"
APP_PENDING_TEXT="pending: Phase 12" APP_PENDING_TEXT="pending: Phase 12"
usage() { usage() {

7
scripts/check-phase11.sh
View File

@@ -26,9 +26,8 @@ VALIDATION="$PHASE_DIR/11-VALIDATION.md"
APP_PLUGINS=(./plugins/golem15/fonoteka/... ./plugins/golem15/user/...) APP_PLUGINS=(./plugins/golem15/fonoteka/... ./plugins/golem15/user/...)
KNOWN_APP_FAILURES="" KNOWN_APP_FAILURES=""
# The broadcast goldens recorded from PHP but asserted only in Phase 12. # The broadcast goldens recorded from PHP but asserted only in Phase 12.
# 12-04 asserts created through the album store handler; updated stays # 12-04 asserts all four through the album handlers: no skip is expected.
# pending until the update handler lands. GOLDEN_SKIPS=""
GOLDEN_SKIPS="TestBroadcastGoldens/updated"
GOLDEN_SKIP_TEXT="pending: Phase 12" GOLDEN_SKIP_TEXT="pending: Phase 12"
RIVER_VERSION="v0.47.0" RIVER_VERSION="v0.47.0"
@@ -661,7 +660,7 @@ run_named() {
phase11_tests "$ROOT" ./modules/tide TestCentrifugoRecorder TestNormalizePublications TestDiffPublications phase11_tests "$ROOT" ./modules/tide TestCentrifugoRecorder TestNormalizePublications TestDiffPublications
phase11_tests "$APP" ./plugins/golem15/fonoteka TestWsAuthorizer TestAlbumBroadcastBinding TestAlbumSearchable \ phase11_tests "$APP" ./plugins/golem15/fonoteka TestWsAuthorizer TestAlbumBroadcastBinding TestAlbumSearchable \
TestFonotekaScheduleSkipsUnregisteredPrune TestRealtimeSubscribeProxy TestAlbumBroadcastSmoke TestAlbumSearchSmoke TestFonotekaScheduleSkipsUnregisteredPrune TestRealtimeSubscribeProxy TestAlbumBroadcastSmoke TestAlbumSearchSmoke
PHASE11_REQUIRE="TestBroadcastGoldens TestBroadcastGoldens/deleted TestBroadcastGoldens/bulk" \ PHASE11_REQUIRE="TestBroadcastGoldens TestBroadcastGoldens/deleted TestBroadcastGoldens/bulk TestBroadcastGoldens/created TestBroadcastGoldens/updated" \
PHASE11_EXPECT_SKIP="$GOLDEN_SKIPS" PHASE11_SKIP_TEXT="$GOLDEN_SKIP_TEXT" \ PHASE11_EXPECT_SKIP="$GOLDEN_SKIPS" PHASE11_SKIP_TEXT="$GOLDEN_SKIP_TEXT" \
phase11_go "$APP" ./parity -run '^TestBroadcastGoldens$' phase11_go "$APP" ./parity -run '^TestBroadcastGoldens$'
echo "phase11 named passed" echo "phase11 named passed"