docs(19.7): cabana subject-event bug resolved
This commit is contained in:
@@ -45,7 +45,7 @@ was changed by the plan that recorded it.
|
||||
stored `initialized` flag would close the gap; not needed for the
|
||||
single-instance demo.
|
||||
- cabana's backend subject events never reach pier (found during 19.7-03 Task 2)
|
||||
status: open
|
||||
status: resolved
|
||||
**What:** `modules/cabana/subject_events.go` fires `pact.MCPSubjectChanged`
|
||||
as a value (`app.Events.Fire(ctx, pact.MCPSubjectChanged{...})`), while
|
||||
`modules/pier/events.go` listens for a pointer
|
||||
@@ -59,3 +59,7 @@ was changed by the plan that recorded it.
|
||||
pier does receive. Fix in the framework: fire `&pact.MCPSubjectChanged{}`
|
||||
from cabana and defer it with `lagoon.AfterCommit`, with a pier test that
|
||||
a cabana save reaches `handleEvent`. Must be fixed before v0.5.0.
|
||||
**Resolved:** cabana now fires `&pact.MCPSubjectChanged{}` through
|
||||
`lagoon.AfterCommit` (immediately outside a transaction);
|
||||
`subject_events_test.go` pins delivery to a pointer listener, no firing
|
||||
before commit and none after a rollback.
|
||||
|
||||
Reference in New Issue
Block a user