golem15/summercms
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(19.7): cabana subject-event bug resolved

Browse Source
This commit is contained in:
Jakub Zych
2026-10-23 12:44:09 +02:00
parent d96c726d6c
commit 7c43820afe
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.planning/phases/19.7-generic-mcp-module/deferred-items.md
View File

@@ -45,7 +45,7 @@ was changed by the plan that recorded it.
stored `initialized` flag would close the gap; not needed for the stored `initialized` flag would close the gap; not needed for the
single-instance demo. single-instance demo.
- cabana's backend subject events never reach pier (found during 19.7-03 Task 2) - cabana's backend subject events never reach pier (found during 19.7-03 Task 2)
status: open status: resolved
**What:** `modules/cabana/subject_events.go` fires `pact.MCPSubjectChanged` **What:** `modules/cabana/subject_events.go` fires `pact.MCPSubjectChanged`
as a value (`app.Events.Fire(ctx, pact.MCPSubjectChanged{...})`), while as a value (`app.Events.Fire(ctx, pact.MCPSubjectChanged{...})`), while
`modules/pier/events.go` listens for a pointer `modules/pier/events.go` listens for a pointer
@@ -59,3 +59,7 @@ was changed by the plan that recorded it.
pier does receive. Fix in the framework: fire `&pact.MCPSubjectChanged{}` pier does receive. Fix in the framework: fire `&pact.MCPSubjectChanged{}`
from cabana and defer it with `lagoon.AfterCommit`, with a pier test that from cabana and defer it with `lagoon.AfterCommit`, with a pier test that
a cabana save reaches `handleEvent`. Must be fixed before v0.5.0. a cabana save reaches `handleEvent`. Must be fixed before v0.5.0.
**Resolved:** cabana now fires `&pact.MCPSubjectChanged{}` through
`lagoon.AfterCommit` (immediately outside a transaction);
`subject_events_test.go` pins delivery to a pointer listener, no firing
before commit and none after a rollback.