docs(35): record code review disposition
This commit is contained in:
@@ -6,19 +6,35 @@ findings:
|
||||
- id: CR-01
|
||||
severity: critical
|
||||
disposition: open
|
||||
title: "Site name (Branding or mail.from display name) can stop every send on the built-in layouts and block template/layout saves"
|
||||
title: "A site name that `UnsafeText` accepts still stops every default/system-layout send (CR-01 residual)"
|
||||
- id: CR-02
|
||||
severity: critical
|
||||
disposition: open
|
||||
title: "Scheme and handler checks are skipped inside raw-text elements: `<noscript>`, and `<title>`/`<textarea>`/`<style>` in SVG/MathML"
|
||||
- id: WR-01
|
||||
severity: warning
|
||||
disposition: open
|
||||
title: "Site name is interpreted as Markdown in the footer (but printed literally in the header)"
|
||||
title: "List-valued, `meta` content, `style` and comment checks do not strip whitespace, so `java	script:` passes"
|
||||
- id: WR-02
|
||||
severity: warning
|
||||
disposition: open
|
||||
title: "Lock-order inversion between show/save transactions and the index sync (global advisory lock taken inside request transactions)"
|
||||
title: "Ordinary text still blocks a send through the whole-document `eventHandler` regex"
|
||||
- id: WR-03
|
||||
severity: warning
|
||||
disposition: open
|
||||
title: "`mailLocales` swallows TranslationWriter errors while running inside a Postgres transaction"
|
||||
title: "The new `UnsafeText` rule refuses ordinary names that the docs promise are accepted"
|
||||
- id: IN-01
|
||||
severity: info
|
||||
disposition: open
|
||||
title: "The footer partial's Markdown `body` branch is never previewed or validated in the partial editor"
|
||||
- id: IN-02
|
||||
severity: info
|
||||
disposition: open
|
||||
title: "`settings.go` now localizes every settings model's `BeforeValidate` error"
|
||||
- id: IN-03
|
||||
severity: info
|
||||
disposition: open
|
||||
title: "CSS escape sequences bypass the CSS `data:`/`javascript:` checks (accepted residual, undocumented to users)"
|
||||
- id: WR-04
|
||||
severity: warning
|
||||
disposition: open
|
||||
@@ -27,25 +43,13 @@ findings:
|
||||
severity: warning
|
||||
disposition: open
|
||||
title: "Safety check runs on undecoded markup; the new opt-out ships what the inlined path would reject"
|
||||
- id: IN-01
|
||||
severity: info
|
||||
disposition: open
|
||||
title: "`scopeTemplates` is dead code after the switch to `scopeTemplateVersions`"
|
||||
- id: IN-02
|
||||
severity: info
|
||||
disposition: open
|
||||
title: "Fallback info line claims \"Until you customize it, the default version is sent\" on customized rows"
|
||||
- id: IN-03
|
||||
severity: info
|
||||
disposition: open
|
||||
title: "check-phase35.sh self-test asserts against the wrong repository"
|
||||
- id: IN-04
|
||||
severity: info
|
||||
disposition: open
|
||||
title: "Case handling differs between `EnsureLocaleRows` and send resolution; doc comment reflow"
|
||||
open: 10
|
||||
total: 10
|
||||
recorded: 2026-11-13T21:23:46.212Z
|
||||
open: 11
|
||||
total: 11
|
||||
recorded: 2026-11-14T15:18:29.660Z
|
||||
---
|
||||
|
||||
# Phase 35: Code Review Disposition
|
||||
@@ -53,15 +57,16 @@ recorded: 2026-11-13T21:23:46.212Z
|
||||
| Finding | Severity | Disposition | Source |
|
||||
|---------|----------|-------------|--------|
|
||||
| CR-01 | critical | open | - |
|
||||
| CR-02 | critical | open | - |
|
||||
| WR-01 | warning | open | - |
|
||||
| WR-02 | warning | open | - |
|
||||
| WR-03 | warning | open | - |
|
||||
| WR-04 | warning | open | - |
|
||||
| WR-05 | warning | open | - |
|
||||
| IN-01 | info | open | - |
|
||||
| IN-02 | info | open | - |
|
||||
| IN-03 | info | open | - |
|
||||
| IN-04 | info | open | - |
|
||||
| WR-04 | warning | open | - (not in the current review) |
|
||||
| WR-05 | warning | open | - (not in the current review) |
|
||||
| IN-04 | info | open | - (not in the current review) |
|
||||
|
||||
Dispositions: `open` (recorded, not yet triaged), `fixed`, `skipped`, `deferred`.
|
||||
Set `deferred` by hand and put the reason in the Source cell; both are preserved. A `|` in the reason is kept as prose and escaped on the next run.
|
||||
|
||||
Reference in New Issue
Block a user