test(35): complete UAT - 8 passed, 2 issues

This commit is contained in:
Jakub Zych
2026-11-13 16:11:26 +01:00
parent 593f99ac70
commit 9db6a66ca4

View File

@@ -1,40 +1,87 @@
---
status: testing
status: complete
phase: 35-mail-templates-and-layouts-editor
source: [35-VERIFICATION.md]
started: 2026-11-13T13:46:04.193Z
updated: 2026-11-13T13:46:04.193Z
updated: 2026-11-13T15:15:00.000Z
---
## Current Test
number: 1
name: Open Settings → Mail → Mail templates in a running admin SPA with a plugin that registers HasMailTemplates (e.g. user plugin templates).
expected: |
All registered templates appear; customize subject/body/layout; save; Reset to file version restores file content; drift callout appears after file change.
awaiting: user response
[testing complete]
## Tests
### 1. Open Settings → Mail → Mail templates in a running admin SPA with a plugin that registers HasMailTemplates (e.g. user plugin templates).
expected: All registered templates appear; customize subject/body/layout; save; Reset to file version restores file content; drift callout appears after file change.
result: [pending]
### 1. Template list
expected: Settings → Mail → Mail templates lists the templates from user, mfa, paymentgateway and quizzes.
result: issue
reported: "fact that each locale is a separate entry in backend is absolute disaster, why was it planned like that? imagine site with 50 locales."
severity: major
### 2. Edit a layout in codeeditor (HTML/text/CSS tabs); insert an image from the library; save Branding colours and logo; preview HTML/plain text; Send test to me.
expected: CodeMirror highlighting/focus feels correct; inserted URL is absolute server URL; preview iframe is sandboxed server HTML; test mail arrives only at the signed-in admin address (Mailpit).
result: [pending]
### 2. Customize and save a template
expected: Open the user plugin's activate template (the row without a locale suffix), change the subject to "UAT subject", Save. Reopen it: the subject is "UAT subject" and the row shows as customized.
result: pass
### 3. Confirm judgment-tier prohibition: postcard imports modules/lagoon/attach for AbsolutePublicURL.
### 3. Reset to file version
expected: On the same template click "Reset to file version" and confirm. The subject is back to the file's subject and the row no longer shows as customized.
result: pass
### 4. Drift notice
expected: Customize activate again and save. Edit ../sm-demo-app/plugins/golem15/user/views/mail/activate.htm (change any text), restart with scripts/dev.sh down && scripts/dev.sh up. Opening the template shows a callout that the file changed since it was customized; your saved version is still what's used.
result: pass
### 5. Layout editor
expected: Settings → Mail → Mail layouts, open "user". HTML, plain text and CSS tabs each show a code editor with syntax highlighting; typing works and Save persists after reload.
result: pass
### 6. Insert image into layout
expected: In the layout HTML tab, use the insert-image button, pick or upload an image. The inserted <img src> is a full URL starting with http://127.0.0.1:8097/.
result: pass
### 7. Branding
expected: Mail branding: change a colour and set a logo, Save, reload. Values persist; the preview of any template uses the new colour/logo.
result: pass
### 8. Preview
expected: On a template, the HTML preview renders the mail with its layout; the plain-text tab shows the text version.
result: issue
reported: "logo doesn't appear, only kind of proper layout is System layout (logo doesn't show, Aktywuj konto on activate email doesn't seem to be a button, totally unstyled), other layouts sucks, I expect beautiful and working out of box layouts after this phase."
severity: major
### 9. Send test to me
expected: Click "Send test to me". ../sm-demo-app/logs/go.log gets a mail entry addressed to the signed-in admin's email (no other recipient can be entered).
result: pass
### 10. Confirm judgment-tier prohibition: postcard imports modules/lagoon/attach for AbsolutePublicURL.
expected: Accept as intentional (D-24 / 35-01 SUMMARY threat_flag dependency-surface) or request a follow-up to move AbsolutePublicURL out of lagoon.
result: [pending]
result: pass
note: "User accepted the lagoon/attach import as intentional."
## Summary
total: 3
passed: 0
issues: 0
pending: 3
total: 10
passed: 8
issues: 2
pending: 0
skipped: 0
blocked: 0
## Gaps
- gap_id: G-35-1
truth: "Locale variants of one mail template are managed as a single backend entry (per-locale tabs/switcher), so a site with many locales does not get one list row per locale."
status: failed
reason: "User reported: fact that each locale is a separate entry in backend is absolute disaster, why was it planned like that? imagine site with 50 locales."
severity: major
test: 1
artifacts: []
missing: []
- gap_id: G-35-8
truth: "Mail preview renders the template inside a polished, working layout out of the box: branding logo shows, call-to-action links (e.g. 'Aktywuj konto' in activate) render as styled buttons, and every shipped layout (system and plugin layouts such as user, paymentgateway) looks finished."
status: failed
reason: "User reported: logo doesn't appear, only kind of proper layout is System layout (logo doesn't show, Aktywuj konto on activate email doesn't seem to be a button, totally unstyled), other layouts sucks, I expect beautiful and working out of box layouts after this phase."
severity: major
test: 8
artifacts: []
missing: []