test(admin): mail template locale switcher

- LocaleVariantSwitcher: current flag, option values and locales, the label
  through the control id, the query kept on navigation, no navigation for the
  open version, selection restored when a guard throws, props updates
- FormView: no switcher with one variant; with unsaved edits switching asks
  the unsaved-changes confirm, stays on cancel and opens the sibling on confirm
- check-phase35.sh requires LocaleVariantSwitcher.test.ts (ADMIN_FILES)
This commit is contained in:
Jakub Zych
2026-11-13 21:38:36 +01:00
parent eed91c821a
commit a9381165c7
3 changed files with 111 additions and 3 deletions

View File

@@ -125,6 +125,57 @@ describe('FormView mail footer actions and meta.deletable', () => {
const none = await mountApp('/summercms/cabana/mailtemplates/7', routes())
expect(none.wrapper.find('[data-locale-variant]').exists()).toBe(false)
const one = await mountApp(
'/summercms/cabana/mailtemplates/7',
routes({
[`GET ${RECORD}`]: mailRecord({
localeVariants: [{ id: 7, locale: '', label: 'Default', states: [], current: true }],
}),
}),
)
expect(one.wrapper.find('[data-locale-variant]').exists()).toBe(false)
})
it('asks the unsaved-changes confirm before switching locale and stays on cancel', async () => {
const localeVariants = [
{ id: 7, locale: '', label: 'Default', states: [], current: true },
{ id: 9, locale: 'de', label: 'de', states: [], current: false },
]
const sibling = clone(recordFixture)
sibling.data = { id: 9, subject: 'Hallo', body: 'Body' }
sibling.meta = {
...sibling.meta,
actions: [],
deletable: false,
localeVariants: localeVariants.map((variant) => ({ ...variant, current: variant.id === 9 })),
}
const { wrapper, router, calls } = await mountApp(
'/summercms/cabana/mailtemplates/7',
routes({
[`GET ${RECORD}`]: mailRecord({ actions: [], localeVariants }),
[`GET ${BASE}/9`]: { body: sibling },
}),
)
await wrapper.find('#field-subject').setValue('Changed')
const select = wrapper.find<HTMLSelectElement>('header select[data-locale-variant]')
await select.setValue('9')
await flushPromises()
const dialog = document.body.querySelector<HTMLElement>('[data-confirm-dialog]')
expect(dialog?.textContent).toContain(langFixture.data['backend::lang.form.unsaved_confirm']!.other)
dialog!.querySelector<HTMLButtonElement>('[data-action="cancel"]')!.click()
await flushPromises()
expect(router.currentRoute.value.fullPath).toBe('/summercms/cabana/mailtemplates/7')
expect(select.element.value).toBe('7')
expect((wrapper.find('#field-subject').element as HTMLInputElement).value).toBe('Changed')
expect(calls.some((request) => request.method === 'GET' && request.url.endsWith('/mailtemplates/9'))).toBe(false)
await select.setValue('9')
await flushPromises()
document.body.querySelector<HTMLButtonElement>('[data-confirm-dialog] [data-action="confirm"]')!.click()
await flushPromises()
expect(router.currentRoute.value.fullPath).toBe('/summercms/cabana/mailtemplates/9')
expect(calls.some((request) => request.method === 'GET' && request.url.endsWith('/mailtemplates/9'))).toBe(true)
})
it('toasts 403 and 409 paths from record actions', async () => {

View File

@@ -14,15 +14,18 @@ const variants = [
const Stub = defineComponent({ render: () => h('div') })
async function mountSwitcher(allow: () => boolean) {
async function mountSwitcher(
allow: () => boolean,
options: { list?: typeof variants; path?: string; controlId?: string } = {},
) {
const router = createRouter({
history: createMemoryHistory(),
routes: [{ path: '/:vendor/:plugin/:controller/:id', name: 'update', component: Stub }],
})
router.beforeEach((_to, from) => (from.matched.length === 0 ? true : allow()))
await router.push('/summercms/cabana/mailtemplates/7')
await router.push(options.path ?? '/summercms/cabana/mailtemplates/7')
const wrapper = mount(LocaleVariantSwitcher, {
props: { variants },
props: { variants: options.list ?? variants, controlId: options.controlId },
global: { plugins: [router] },
attachTo: document.body,
})
@@ -72,4 +75,57 @@ describe('LocaleVariantSwitcher', () => {
expect(router.currentRoute.value.params.id).toBe('7')
expect(select.element.value).toBe('7')
})
it('selects the variant flagged current, not the first one', async () => {
const list = variants.map((variant) => ({ ...variant, current: variant.id === 9 }))
const { wrapper } = await mountSwitcher(() => true, { list, path: '/summercms/cabana/mailtemplates/9' })
expect(wrapper.find<HTMLSelectElement>('select').element.value).toBe('9')
expect(wrapper.findAll('option').map((option) => option.attributes('data-locale'))).toEqual(['', 'de', 'en'])
expect(wrapper.findAll('option').map((option) => option.attributes('value'))).toEqual(['7', '9', '8'])
})
it('labels the select through the given control id', async () => {
const { wrapper } = await mountSwitcher(() => true, { controlId: 'form-locale-variant' })
const select = wrapper.find('select')
expect(select.attributes('id')).toBe('form-locale-variant')
expect(wrapper.find('label').attributes('for')).toBe('form-locale-variant')
expect(document.body.querySelector<HTMLSelectElement>('#form-locale-variant')?.labels?.[0]?.textContent).toBe('Language')
})
it('keeps the query string when it opens a sibling version', async () => {
const { wrapper, router } = await mountSwitcher(() => true, { path: '/summercms/cabana/mailtemplates/7?tab=preview' })
await wrapper.find('select').setValue('8')
await flushPromises()
expect(router.currentRoute.value.fullPath).toBe('/summercms/cabana/mailtemplates/8?tab=preview')
})
it('does not navigate when the open version is chosen again', async () => {
let asked = 0
const { wrapper, router } = await mountSwitcher(() => {
asked++
return true
})
await wrapper.find('select').setValue('7')
await flushPromises()
expect(asked).toBe(0)
expect(router.currentRoute.value.params.id).toBe('7')
})
it('restores the selection when the navigation throws', async () => {
const { wrapper, router } = await mountSwitcher(() => {
throw new Error('guard failed')
})
router.onError(() => {})
const select = wrapper.find<HTMLSelectElement>('select')
await select.setValue('9')
await flushPromises()
expect(router.currentRoute.value.params.id).toBe('7')
expect(select.element.value).toBe('7')
})
it('follows a new current variant from the props', async () => {
const { wrapper } = await mountSwitcher(() => true)
await wrapper.setProps({ variants: variants.map((variant) => ({ ...variant, current: variant.id === 8 })) })
expect(wrapper.find<HTMLSelectElement>('select').element.value).toBe('8')
})
})

View File

@@ -134,6 +134,7 @@ ADMIN_FILES=(
tests/form/ColorPickerField.test.ts
tests/form/MailImageField.test.ts
tests/form/FormViewMail.test.ts
tests/form/LocaleVariantSwitcher.test.ts
tests/list/RowStateBadges.test.ts
tests/views/SettingsFormView.test.ts
)