docs(35): record code review disposition

This commit is contained in:
Jakub Zych
2026-11-13 22:23:46 +01:00
parent 75669b343f
commit b1f85c2177

View File

@@ -1,19 +1,68 @@
---
phase: 35
source: 35-REVIEW.md
created: 2026-11-13
review: 35-REVIEW.md
titles: json
findings:
- id: CR-01
severity: critical
disposition: open
title: "Site name (Branding or mail.from display name) can stop every send on the built-in layouts and block template/layout saves"
- id: WR-01
severity: warning
disposition: open
title: "Site name is interpreted as Markdown in the footer (but printed literally in the header)"
- id: WR-02
severity: warning
disposition: open
title: "Lock-order inversion between show/save transactions and the index sync (global advisory lock taken inside request transactions)"
- id: WR-03
severity: warning
disposition: open
title: "`mailLocales` swallows TranslationWriter errors while running inside a Postgres transaction"
- id: WR-04
severity: warning
disposition: open
title: "Fallback-locale rule silently resolves typos, yet rejects real locales the admin offers"
- id: WR-05
severity: warning
disposition: open
title: "Safety check runs on undecoded markup; the new opt-out ships what the inlined path would reject"
- id: IN-01
severity: info
disposition: open
title: "`scopeTemplates` is dead code after the switch to `scopeTemplateVersions`"
- id: IN-02
severity: info
disposition: open
title: "Fallback info line claims \"Until you customize it, the default version is sent\" on customized rows"
- id: IN-03
severity: info
disposition: open
title: "check-phase35.sh self-test asserts against the wrong repository"
- id: IN-04
severity: info
disposition: open
title: "Case handling differs between `EnsureLocaleRows` and send resolution; doc comment reflow"
open: 10
total: 10
recorded: 2026-11-13T21:23:46.212Z
---
# Review Disposition — Phase 35
# Phase 35: Code Review Disposition
| ID | Severity | Disposition | Notes |
|----|----------|-------------|-------|
| WR-01 | warning | open | Layout status filter hides database-only layouts |
| WR-02 | warning | open | Unknown filterStatus leaves query unfiltered |
| WR-03 | warning | open | Mail image upload ignores field-level validation details |
| WR-04 | warning | open | Partial preview gated only on content_html |
| IN-01 | info | open | Stale preview HTML after clear-then-retype |
| IN-02 | info | open | Color picker swatch shows last valid when text empty |
| IN-03 | info | open | ListExtendRecords mutates locale/source pointers for display |
| Finding | Severity | Disposition | Source |
|---------|----------|-------------|--------|
| CR-01 | critical | open | - |
| WR-01 | warning | open | - |
| WR-02 | warning | open | - |
| WR-03 | warning | open | - |
| WR-04 | warning | open | - |
| WR-05 | warning | open | - |
| IN-01 | info | open | - |
| IN-02 | info | open | - |
| IN-03 | info | open | - |
| IN-04 | info | open | - |
All findings left `open` at execute-phase disposition (advisory; does not block).
Dispositions: `open` (recorded, not yet triaged), `fixed`, `skipped`, `deferred`.
Set `deferred` by hand and put the reason in the Source cell; both are preserved. A `|` in the reason is kept as prose and escaped on the next run.
Re-running the gate keeps every row it can. A row the current review no longer reports is kept and its Source cell flagged, so a finding does not leave this record silently. ONE exception: when a finding id is REUSED by a different finding, the earlier decision cannot keep a row — the id is taken — and it is dropped. A RECORDED decision (anything but `open`) is named on the console when that happens; a row still at `open` is replaced silently, because `open` records no decision to lose.