docs(32.2): record code review disposition

This commit is contained in:
Jakub Zych
2026-11-21 02:41:55 +01:00
parent 7a2b4954be
commit c16402f79b

View File

@@ -0,0 +1,42 @@
---
phase: "32.2"
sources: [32.2-REVIEW.md (framework, prefix FW), 32.2-REVIEW-plugin-app.md (plugin+app, prefix PA)]
open: 29
total: 29
---
# Phase 32.2 code review disposition
One row per finding, defaulting to `open`. Edit the disposition (fixed / accepted / deferred / wontfix) and the source cell when a finding is triaged.
| ID | Severity | Title | Disposition | Source |
|----|----------|-------|-------------|--------|
| FW-WR-01 | warning | `DefaultScopes` never applies to an `offline_access`-only authorize request, which ends in a consent screen with nothing to grant | open | — |
| FW-WR-02 | warning | `ConsentPath` is concatenated onto `Issuer` without validation and can send the browser off-origin | open | — |
| FW-WR-03 | warning | pier treats an unknown `MCPGrant.Subject` as a frontend-user grant (fail-open) | open | — |
| FW-WR-04 | warning | The Administrators and Roles hooks fire `BackendAccessRevokedEvent` with a possibly nil `Tx`, and the listener then revokes outside the save's transaction | open | — |
| FW-WR-05 | warning | The deactivate site hands listeners an `Unscoped` session as `Tx`, unlike every other site | open | — |
| FW-WR-06 | warning | The framework never checks the provider's redirect against the request's redirect URI, and the SPA guard is only a scheme deny-list | open | — |
| FW-IN-01 | info | A requested `*` is offered to administrators who hold no permission, so the "none grantable" state never shows for them | open | — |
| FW-IN-02 | info | The session binding namespaces can collide | open | — |
| FW-IN-03 | info | Item actions can answer 409, but the OpenAPI annotation does not document it | open | — |
| FW-IN-04 | info | The new literal admin API routes shadow controller routes of a vendor named `mcp` or `account` | open | — |
| FW-IN-05 | info | Dispatched calls of administrator OAuth grants carry no credential, so `interactiveOnly` cannot tell them from a cookie session | open | — |
| PA-CR-01 | critical | App master pins oauthserver v0.1.7, which ignores `mcp.subject`/`oidc.enabled`, and check-deploy cannot tell | open | — |
| PA-WR-01 | warning | Administrator refresh asks the pool for a second connection while holding the rotation transaction | open | — |
| PA-WR-02 | warning | A transient failure in the administrator lookup becomes a terminal `invalid_grant` or 401 | open | — |
| PA-WR-03 | warning | The consent decision and the code exchange never re-validate the administrator under the lock | open | — |
| PA-WR-04 | warning | Two administrators deciding the same pending request are not serialized, and the last writer silently wins | open | — |
| PA-WR-05 | warning | The verifier accepts administrator grants whatever the configured mode | open | — |
| PA-WR-06 | warning | The BackendCascade fallback without a transaction makes the revocation non-atomic and the lock a no-op | open | — |
| PA-WR-07 | warning | The DEPLOY.md rollback leaves administrators' grants alive for a later re-enable | open | — |
| PA-WR-08 | warning | smoke-mcp-oauth.sh puts passwords, the authorization code and the PKCE verifier on process argv | open | — |
| PA-WR-09 | warning | The committed `mcp.resource` is loopback, and a missing env override fails silently | open | — |
| PA-IN-01 | info | Migration rollback keeps administrators' MCP codes | open | — |
| PA-IN-02 | info | The Clients screen's authorizations partial silently drops administrators' consents | open | — |
| PA-IN-03 | info | check-deploy's OpenID Connect location regex misses broader routes | open | — |
| PA-IN-04 | info | The advisory lock keys are 32-bit `hashtext` values shared with the user-grants namespace | open | — |
| PA-IN-05 | info | Smoke step 12 does not prove the cascade or the refresh | open | — |
| PA-IN-06 | info | The refresh-token CHECK allows `user_id = 0`, unlike the access-token CHECK | open | — |
| PA-IN-07 | info | A wall-clock sleep in a Docker test | open | — |
| PA-IN-08 | info | nginx `limit_except` refuses CORS preflight on the authorization server endpoints | open | — |