docs(19.1): persist verification, UAT and review disposition

2026-10-18 16:11:13 +02:00
parent 905b035184
commit ebedba8c94
3 changed files with 346 additions and 0 deletions
--- a/.planning/phases/19.1-chat-satellites/19.1-REVIEW-DISPOSITION.md
+++ b/.planning/phases/19.1-chat-satellites/19.1-REVIEW-DISPOSITION.md
@@ -0,0 +1,62 @@
+---
+phase: 19.1
+review: 19.1-REVIEW.md
+titles: json
+findings:
+  - id: WR-01
+    severity: warning
+    disposition: open
+    title: "LiveKit RoomService never uses the TrustedMode fetchguard client"
+  - id: WR-02
+    severity: warning
+    disposition: open
+    title: "Start commits an active session before CreateRoom succeeds"
+  - id: WR-03
+    severity: warning
+    disposition: open
+    title: "Reconcile ends empty rooms with no grace, including ringing calls"
+  - id: WR-04
+    severity: warning
+    disposition: open
+    title: "Generic chatbots dispatch ignores IsAvailable"
+  - id: WR-05
+    severity: warning
+    disposition: open
+    title: "Chatvideo starter delete cascades the whole session and skips LiveKit cleanup"
+  - id: IN-01
+    severity: info
+    disposition: open
+    title: "Forum SetAccessResolver is a silent no-op before Boot"
+  - id: IN-02
+    severity: info
+    disposition: open
+    title: "screen_share config is copied and never applied to tokens"
+  - id: IN-03
+    severity: info
+    disposition: open
+    title: "Herald Deliver swallows every per-subscription send error"
+  - id: IN-04
+    severity: info
+    disposition: open
+    title: "Group invite created_by has no FK and is not cleared on user delete"
+open: 9
+total: 9
+recorded: 2026-10-18T14:16:00Z
+---
+
+# Phase 19.1: Code Review Disposition
+
+| Finding | Severity | Disposition | Source |
+|---------|----------|-------------|--------|
+| WR-01 | warning | open | 19.1-REVIEW.md |
+| WR-02 | warning | open | 19.1-REVIEW.md |
+| WR-03 | warning | open | 19.1-REVIEW.md |
+| WR-04 | warning | open | 19.1-REVIEW.md |
+| WR-05 | warning | open | 19.1-REVIEW.md |
+| IN-01 | info | open | 19.1-REVIEW.md |
+| IN-02 | info | open | 19.1-REVIEW.md |
+| IN-03 | info | open | 19.1-REVIEW.md |
+| IN-04 | info | open | 19.1-REVIEW.md |
+
+Dispositions: `open` (recorded, not yet triaged), `fixed`, `skipped`, `deferred`.
+Set `deferred` by hand and put the reason in the Source cell; both are preserved.
--- a/.planning/phases/19.1-chat-satellites/19.1-UAT.md
+++ b/.planning/phases/19.1-chat-satellites/19.1-UAT.md
@@ -0,0 +1,32 @@
+---
+status: testing
+phase: 19.1-chat-satellites
+source: [19.1-VERIFICATION.md]
+started: 2026-10-18T14:10:42.648Z
+updated: 2026-10-18T14:10:42.648Z
+---
+
+## Current Test
+
+number: 1
+name: Accept an override that ../sm-userfriends-plugin/go.mod may require sm-chat-plugin so Boot can Lookup[*chatcontracts.Registry], while Plugin.Requires() stays []string{"golem15.user"} only.
+expected: |
+  Override recorded. No code change. Removing the go.mod require would make the D-08 soft adapter uncompilable.
+awaiting: user response
+
+## Tests
+
+### 1. Accept an override that ../sm-userfriends-plugin/go.mod may require sm-chat-plugin so Boot can Lookup[*chatcontracts.Registry], while Plugin.Requires() stays []string{"golem15.user"} only.
+expected: Override recorded. No code change. Removing the go.mod require would make the D-08 soft adapter uncompilable.
+result: [pending]
+
+## Summary
+
+total: 1
+passed: 0
+issues: 0
+pending: 1
+skipped: 0
+blocked: 0
+
+## Gaps
--- a/.planning/phases/19.1-chat-satellites/19.1-VERIFICATION.md
+++ b/.planning/phases/19.1-chat-satellites/19.1-VERIFICATION.md
@@ -0,0 +1,252 @@
+---
+phase: 19.1-chat-satellites
+verified: 2026-10-18T14:15:00Z
+status: human_needed
+score: 16/16 must-haves verified
+covered_files:
+  - .planning/ROADMAP.md
+  - .planning/notes/2026-10-18-bluemonday-forum-policy.md
+  - .planning/notes/2026-10-18-livekit-server-sdk-go.md
+  - .planning/notes/2026-10-18-webpush-go.md
+  - .planning/phases/19.1-chat-satellites/19.1-01-PLAN.md
+  - .planning/phases/19.1-chat-satellites/19.1-01-SUMMARY.md
+  - .planning/phases/19.1-chat-satellites/19.1-02-PLAN.md
+  - .planning/phases/19.1-chat-satellites/19.1-02-SUMMARY.md
+  - .planning/phases/19.1-chat-satellites/19.1-03-PLAN.md
+  - .planning/phases/19.1-chat-satellites/19.1-03-SUMMARY.md
+  - .planning/phases/19.1-chat-satellites/19.1-04-PLAN.md
+  - .planning/phases/19.1-chat-satellites/19.1-04-SUMMARY.md
+  - .planning/phases/19.1-chat-satellites/19.1-05-PLAN.md
+  - .planning/phases/19.1-chat-satellites/19.1-05-SUMMARY.md
+  - .planning/phases/19.1-chat-satellites/19.1-06-PLAN.md
+  - .planning/phases/19.1-chat-satellites/19.1-06-SUMMARY.md
+  - README.md
+  - docs/services/markdown.md
+  - modules/breakwater/README.md
+  - modules/breakwater/breakwater.go
+  - modules/breakwater/breakwater_test.go
+  - modules/breakwater/example_test.go
+  - scripts/check-phase19.1.sh
+covered_digest: "v2:sha256:2311abea5e82d375f2b20a2ae8ba39cb0849574ac0d8cdfc27ac48b689d72069"
+behavior_unverified: 0
+overrides_applied: 0
+decision_coverage:
+  honored: 18
+  total: 18
+  not_honored: []
+human_verification:
+  - test: "Accept an override that ../sm-userfriends-plugin/go.mod may require sm-chat-plugin so Boot can Lookup[*chatcontracts.Registry], while Plugin.Requires() stays []string{\"golem15.user\"} only."
+    expected: "Override recorded. No code change. Removing the go.mod require would make the D-08 soft adapter uncompilable."
+    why_human: "Plan 01 prohibition literally says go.mod never require sm-chat-plugin. The same plan's D-08 truth requires a typed Lookup of the chat Registry. Those two statements cannot both be true in Go. Implementation honors D-08 (Requires() is user-only; missing chat is a skip). A human must accept the deviation."
+---
+
+# Phase 19.1: Chat satellites Verification Report
+
+**Phase Goal:** The remaining shared plugins that Wavepath's app plugin requires run on SummerCMS: chatbots, chatvideo, forum, herald and userfriends.
+**Verified:** 2026-10-18T14:15:00Z
+**Status:** human_needed
+**Re-verification:** No — initial verification
+
+Roadmap `**Mode:** mvp` is set, but the ROADMAP goal is not a user-story sentence (`user-story.validate` → `false`). Verification proceeded because execute-phase `verify_phase_goal` asked for this report and each plan already carries an application-mounts-satellites user story. A `/msd mvp-phase 19.1` rewrite of the ROADMAP goal is optional bookkeeping, not a code gap.
+
+This is an infrastructure/plugin-port phase (sibling repos, generic JWT APIs, no end-user UI). Human verification is therefore limited to the one planner-prohibition contradiction below — not invented UI walkthroughs.
+
+## User Flow Coverage
+
+Aggregated from the six plan user stories (ROADMAP goal is not a user story):
+
+| Step | Expected | Evidence | Status |
+|------|----------|----------|--------|
+| Mount Friends | Host binds no extra seam; JWT `/_userfriends/api/v1` request/accept/list works | `../sm-userfriends-plugin/routes.go`; `TestHTTPTracer` passed (postgres) | ✓ |
+| Mount Forum | Host binds `ForumAccessResolver`; context-scoped categories; GFM stored, XSS stripped | `../sm-forum-plugin/routes.go`; `breakwater.Render` on write; `TestHTTPTracer` passed | ✓ |
+| Mount Chat bots | Host registers slash commands; dispatch invoker is the JWT actor | `../sm-chatbots-plugin/api/commands.go` uses `actor()` / `bouncer.User`; `TestHTTPTracer` passed | ✓ |
+| Mount Herald | Host stores subscriptions and sends Web Push without PHP | `../sm-herald-plugin/routes.go`; `TestHTTPTracer` + `TestSendEventRollback` passed | ✓ |
+| Mount Chat video | Host starts/joins/ends conversation video; stale sessions reconcile | `../sm-chatvideo-plugin/routes.go`; `TestHTTPTracer` + `TestReconcileEmptyRoom` passed | ✓ |
+| Fail-closed gate | Skipped/missing named tests fail `scripts/check-phase19.1.sh` | `--self-test`, `--plugins`, `--docs`, `--postgres` all exit 0 this session | ✓ |
+
+## Goal Achievement
+
+### Observable Truths
+
+Merged from ROADMAP success criteria (SC-19.1-1..4) plus PLAN `must_haves.truths` (D-01..D-18). Roadmap wording kept where a plan restated an SC.
+
+| # | Truth | Status | Evidence |
+| --- | ------- | ---------- | -------------- |
+| 1 | SC-19.1-1: each plugin ports schema, models, routes and events 1:1 against its PHP original | ✓ VERIFIED | Five sibling repos exist with Winter layout, `202610180001_create_golem15_*_baseline`, models, JWT routes, and (where applicable) festival/lighthouse events. PHP method maps: userfriends 31, forum 25, chatbots 22, herald 14 declarations / 13 unique, chatvideo 0 in-plugin + Wavepath generic-or-N/A. |
+| 2 | SC-19.1-2: webpush-go, LiveKit, and bluemonday decision notes exist and name the locked modules/versions | ✓ VERIFIED | `.planning/notes/2026-10-18-webpush-go.md` (`SherClockHolmes/webpush-go` v1.4.0); `2026-10-18-livekit-server-sdk-go.md` (`server-sdk-go/v2` v2.19.0, pion/media-sdk/buildkit flag); `2026-10-18-bluemonday-forum-policy.md` (v1.0.27, PHP allow-list, not UGC). `check-phase19.1.sh --docs` passed. |
+| 3 | SC-19.1-3: ROADMAP marks criterion 3 already met; fonoteka.go has no userfriends port | ✓ VERIFIED | ROADMAP criterion 3 text is the “already met” wording; Repos line names `summercms.go`. Grep of `../fonoteka.go` for `userfriends` / `golem15.userfriends` returned no matches. |
+| 4 | SC-19.1-4 / D-04: last plan delivers unit tests, PHP method maps, goldens, fail-closed gate | ✓ VERIFIED | `TestPHPMethodMap` ×5, goldens in all five repos, `scripts/check-phase19.1.sh` self-test/plugins/docs/postgres all green this session. |
+| 5 | D-01: module paths, plugin IDs, Requires() match the frozen contract | ✓ VERIFIED | `golem15.userfriends` Requires `golem15.user` only; `golem15.forum` Requires user; `golem15.chatbots` Requires chat+user (no AI plugin; `TestNoGolem` passed); `golem15.herald` Requires empty; `golem15.chatvideo` Requires chat. |
+| 6 | D-02: one idempotent IF NOT EXISTS baseline per plugin; demo-seed IDs are comments | ✓ VERIFIED | Baseline IDs `202610180001_create_golem15_{userfriends,forum,chatbots,herald,chatvideo}_baseline`. Userfriends comment records v1.0.1 demo-seed and inserts no demo rows. `TestBaseline` ×5 passed under `-short`. |
+| 7 | D-03: DenyAll access seams with Boot Warn + setter; GDPR cascades | ✓ VERIFIED | Forum/chatbots/herald DenyAll + Warn + setter. `TestAccessResolverDefault`, `TestBotAuthResolverDefault`, `TestPresenceGateDefault` exist. Postgres: `TestUserDeletingHeir` (admin then member by `role ASC, created_at ASC`), `TestUserDeletionAnonymizes` (null `user_id`, keep bodies), `TestUserDeletionCascadesBotFlag`. |
+| 8 | D-05: generic JWT APIs under documented prefixes; actor from token; named buckets | ✓ VERIFIED | `/_userfriends/api/v1` (`community-join` 10/min on request/join); `/_forum/api/v1/contexts/{type}/{id}/...`; `/_chatbots/api/v1` commands+dispatch; `/_herald/api/v1/push/*`; `/_chatvideo/api/v1/conversations/{id}/video/{start,join,leave,end,status}` + `/call-links/{code}` (`video-initiate` 5/min on start only). Five `TestHTTPTracer` runs passed (postgres). |
+| 9 | D-06: herald ships the generic API (PHP “no routes” reversed) | ✓ VERIFIED | `routes.go` mounts subscription + vapid-public-key. README states the reversal and D-06. |
+| 10 | D-07: legacy `/api/friends`, `/api/video`, Winter components, bundled JS, demo seeders not registered | ✓ VERIFIED | Userfriends and chatvideo `Routes()` only mount `/_* /api/v1`. No `FriendsList` / `VideoCall` components. Demo seeders are comments. |
+| 11 | D-08: group festival events; soft chat adapter; forum `DeleteContext`; forum never imports userfriends | ✓ VERIFIED | `userfriends.GroupCreated/GroupDeleted/MemberJoined/MemberLeft`; `Fire` inside write tx; `Lookup[*chatcontracts.Registry]` skip if absent; `Requires()` omits chat. `ForumService.DeleteContext` soft-deletes the morph pair. `TestNoUserfriendsImport` passed. |
+| 12 | D-10 / D-11: PublicOnly subscribe/send; enqueue on caller tx; rollback sends 0; 410/404 prune | ✓ VERIFIED | `ValidateEndpoint` rejects non-HTTPS; `NewSender` uses `fetchguard.PublicOnlyMode`; `Options.HTTPClient = s.http`; `jobs.Enqueue` on caller `tx`; `TestSendEventRollback` passed; `Deliver` prunes 404/410. No `EndpointGuard` type. |
+| 13 | D-12: VAPID config keys + `herald:vapid-generate`; private key not logged | ✓ VERIFIED | `golem15.herald.vapid.{subject,public_key,private_key}`. Command prints `VAPID_PUBLIC_KEY=` / `VAPID_PRIVATE_KEY=` via `bonfire.Output`, not slog. GET vapid-public-key returns public key only. |
+| 14 | D-13 / D-14 / D-15: LiveKit RoomAPI, token golden, video authorizer segment 2, 5-minute reconciler | ✓ VERIFIED | `type RoomAPI interface`; `TrustedMode` to operator URL; `parseVideoSessionChannel` splits segment 2 (`video:session:{id}`), capabilities `["prs"]`; `TestLiveKitTokenClaims` + `TestVideoAuthorizer` passed (`-short`); `chatvideo:reconcile-sessions` + `golem15.chatvideo.reconcile_sessions` MaxAttempts 1 + `Every(5 * time.Minute)`; `TestReconcileEmptyRoom` passed. Unique `active_conversation_id`, `join_code`, nullable `card_message_id`. |
+| 15 | D-16 / D-17 / D-18: breakwater `Render`/`Purify`; forum write-path render; adopted `content_html` served stored | ✓ VERIFIED | `modules/breakwater` exports both funcs; forum `go.mod` has no direct bluemonday/goldmark require (indirect via summercms). `forum_service.go` / `lifecycle.go` call `breakwater.Render` on write. `api/json.go` copies stored `ContentHTML`. `TestAdoptedContentHTML` + forum `TestHTTPTracer` (table present, no `<script>`). |
+| 16 | Gate: `scripts/check-phase19.1.sh` fail-closed named tests across five sibling roots | ✓ VERIFIED | This session: `--self-test` passed (refuses planted skip/miss/zero); `--plugins` passed (`go vet` + `-short` + named tests); `--docs` passed; `--postgres` passed (Docker up). |
+
+**Score:** 16/16 truths verified (0 present, behavior-unverified)
+
+### Required Artifacts
+
+`msd_run query verify.artifacts` on all six plans: **29/29 passed** (exists, non-stub).
+
+| Artifact | Expected | Status | Details |
+| -------- | -------- | ------ | ------- |
+| `../sm-userfriends-plugin/plugin.go` | golem15.userfriends | ✓ VERIFIED | Requires user only |
+| `../sm-userfriends-plugin/updates/202610180001_create_golem15_userfriends_baseline.go` | IF NOT EXISTS baseline | ✓ VERIFIED | six tables |
+| `../sm-userfriends-plugin/events/events.go` | group festival events | ✓ VERIFIED | four names |
+| `../sm-userfriends-plugin/http_tracer_test.go` | JWT tracer | ✓ VERIFIED | postgres pass |
+| `.planning/ROADMAP.md` | SC2/SC3 wording | ✓ VERIFIED | webpush-go / already met |
+| `../sm-forum-plugin/plugin.go` | golem15.forum | ✓ VERIFIED | |
+| `../sm-forum-plugin/classes/forum_service.go` | DeleteContext | ✓ VERIFIED | + Render on write |
+| `../sm-forum-plugin/contracts/access_resolver.go` | CanRead seam | ✓ VERIFIED | |
+| `../sm-forum-plugin/console/rewrite_context_types.go` | forum:rewrite-context-types | ✓ VERIFIED | |
+| `.planning/notes/2026-10-18-bluemonday-forum-policy.md` | D-16 note | ✓ VERIFIED | |
+| `../sm-chatbots-plugin/plugin.go` | golem15.chatbots | ✓ VERIFIED | |
+| `../sm-chatbots-plugin/classes/registry.go` | registerBuiltin | ✓ VERIFIED | reserved help |
+| `../sm-chatbots-plugin/classes/dispatcher.go` | Dispatch | ✓ VERIFIED | |
+| `../sm-chatbots-plugin/http_tracer_test.go` | /ping tracer | ✓ VERIFIED | postgres pass |
+| `.planning/notes/2026-10-18-webpush-go.md` | D-09 note | ✓ VERIFIED | |
+| `../sm-herald-plugin/jobs/send.go` | golem15.herald.send | ✓ VERIFIED | |
+| `../sm-herald-plugin/console/vapid_generate.go` | herald:vapid-generate | ✓ VERIFIED | |
+| `../sm-herald-plugin/http_tracer_test.go` | rollback tracer | ✓ VERIFIED | postgres pass |
+| `.planning/notes/2026-10-18-livekit-server-sdk-go.md` | D-13 note | ✓ VERIFIED | |
+| `../sm-chatvideo-plugin/classes/livekit.go` | RoomAPI | ✓ VERIFIED | |
+| `../sm-chatvideo-plugin/classes/authorizer.go` | parseVideoSessionChannel | ✓ VERIFIED | |
+| `../sm-chatvideo-plugin/jobs/reconcile.go` | reconcile job | ✓ VERIFIED | |
+| `../sm-chatvideo-plugin/console/reconcile.go` | chatvideo:reconcile-sessions | ✓ VERIFIED | |
+| `scripts/check-phase19.1.sh` | USERFRIENDS env | ✓ VERIFIED | |
+| five `testdata/PHP_METHOD_MAP.md` | mapped PHP methods | ✓ VERIFIED | counts match plan |
+
+### Key Link Verification
+
+`msd_run query verify.key-links` rejected sibling `../sm-*-plugin` paths (`Source path rejected — resolves outside the project directory`). Links were re-checked by reading the files. The one in-repo link (`scripts/check-phase19.1.sh` → `TestHTTPTracer`) verified automatically.
+
+| From | To | Via | Status | Details |
+| ---- | --- | --- | ------ | ------- |
+| `../sm-userfriends-plugin/boot.go` | `events/events.go` | Fire GroupCreated; Listen user.Deleting | WIRED | `onUserDeleting` → `GroupService.OnUserDeleting`; Create fires `GroupCreated` in tx |
+| `../sm-userfriends-plugin/routes.go` | `api/friends.go` | jwt.auth + community-join | WIRED | JoinBucket on POST `/friends/request` |
+| `../sm-userfriends-plugin/classes/friends_context_adapter.go` | chat Registry | Lookup; alias friendcontext | WIRED | `bootChatAdapter` skip if absent |
+| `../sm-forum-plugin/classes/forum_service.go` | breakwater.Render | write-path render | WIRED | CreateThread/Reply/Edit |
+| `../sm-forum-plugin/boot.go` | `classes/deny_all.go` | Boot Warn deny-all | WIRED | Warn string contains `deny-all` |
+| `../sm-forum-plugin/console/rewrite_context_types.go` | baseline context_type | morph rewrite | WIRED | UPDATEs `golem15_forum_categories.context_type` |
+| `../sm-chatbots-plugin/api/commands.go` | dispatcher | actor from bouncer.User | WIRED | `Dispatch(ctx, input, userID, ...)` |
+| `../sm-chatbots-plugin/boot.go` | deny_all | BotAuthResolver Warn | WIRED | |
+| `../sm-herald-plugin/classes/sender.go` | fetchguard | HTTPClient PublicOnly | WIRED | `Options.HTTPClient = s.http` |
+| `../sm-herald-plugin/classes/sender.go` | `jobs/send.go` | Enqueue on caller tx | WIRED | `s.jobs.Enqueue(ctx, db, args, ...)` |
+| `../sm-chatvideo-plugin/boot.go` | authorizer | Register("video") | WIRED | `Registry.Register("video", ...)` |
+| `../sm-chatvideo-plugin/classes/livekit.go` | fetchguard TrustedMode | operator URL | WIRED | `NewProductionRooms` |
+| `../sm-chatvideo-plugin/routes.go` | `api/video.go` | video-initiate on start | WIRED | |
+| `scripts/check-phase19.1.sh` | userfriends TestHTTPTracer | postgres stage | WIRED | automated |
+| herald PHP_METHOD_MAP | fetchguard | EndpointGuard N/A D-10 | WIRED | three not-applicable rows + fetchguard pointer |
+
+### Data-Flow Trace (Level 4)
+
+| Artifact | Data Variable | Source | Produces Real Data | Status |
+| -------- | ------------- | ------ | ------------------ | ------ |
+| userfriends friends/groups API | friendship/group rows | GORM on baseline tables | yes (TestHTTPTracer) | ✓ FLOWING |
+| forum posts | content / content_html | write-path `breakwater.Render`; read returns stored HTML | yes | ✓ FLOWING |
+| chatbots dispatch | CommandResult | Registry + Dispatcher; JWT actor | yes | ✓ FLOWING |
+| herald subscriptions / send | subscription rows + webpush | GORM + fetchguard PublicOnly + conga job | yes (rollback tracer) | ✓ FLOWING |
+| chatvideo sessions | session / participant / JWT | GORM + RoomAPI fake in tests | yes | ✓ FLOWING |
+
+No static `[]` / hardcoded empty payload on the published handlers.
+
+### Behavioral Spot-Checks
+
+| Behavior | Command | Result | Status |
+| -------- | ------- | ------ | ------ |
+| Gate self-test refuses planted skip/miss/zero | `bash scripts/check-phase19.1.sh --self-test` | `phase19.1 self-test passed` | ✓ PASS |
+| Decision-note pins | `bash scripts/check-phase19.1.sh --docs` | `phase19.1 docs passed` | ✓ PASS |
+| Short named tests ×5 repos | `bash scripts/check-phase19.1.sh --plugins` | vet + short + named tests; `phase19.1 plugins passed` | ✓ PASS |
+| HTTP tracers, GDPR, rollback, reconcile | `bash scripts/check-phase19.1.sh --postgres` | 11 named tests passed; `phase19.1 postgres passed` | ✓ PASS |
+| breakwater exports | grep `func Render` / `func Purify` | both present | ✓ PASS |
+
+### Probe Execution
+
+| Probe | Command | Result | Status |
+| ------ | ------- | ------ | ------ |
+| — | — | Phase is spec-less (REQUIREMENTS TBD; plan 01 recorded no probe predicates). No `scripts/*/tests/probe-*.sh`. Gate script above is the named check. | SKIP |
+
+### Requirements Coverage
+
+`.planning/REQUIREMENTS.md` has **Requirements: TBD** for Phase 19.1 and no `SC-19.1-*` rows. No orphaned REQUIREMENTS IDs. PLAN frontmatter IDs accounted for:
+
+| Requirement | Source Plan | Description | Status | Evidence |
+| ----------- | ---------- | ----------- | ------ | -------- |
+| SC-19.1-1 | 01–06 | 1:1 schema/models/routes/events | ✓ SATISFIED | five repos + maps |
+| SC-19.1-2 | 03, 04, 05 | decision notes; chatbots not wired to AI plugin | ✓ SATISFIED | three notes; `TestNoGolem` |
+| SC-19.1-3 | 01 | fonoteka already met | ✓ SATISFIED | ROADMAP + no fonoteka.go port |
+| SC-19.1-4 | 06 | unit tests last | ✓ SATISFIED | maps, goldens, gate |
+| D-01..D-18 | 01–06 | CONTEXT decisions | ✓ SATISFIED | 18/18 decision-coverage honored; see truths |
+
+### Decision Coverage
+
+All 18 trackable CONTEXT.md decisions are honored by shipped artifacts (`check.decision-coverage-verify`: honored 18 / total 18, `not_honored: []`).
+
+### Test Quality Audit
+
+| Test File | Linked Req | Active | Skipped | Circular | Assertion Level | Verdict |
+|-----------|-----------|--------|---------|----------|-----------------|---------|
+| five `http_tracer_test.go` | D-05 | yes (postgres) | skip only via testmain `-short` | no | behavioral | OK |
+| five `updates/baseline_test.go` | D-02 | yes | no | no | value (IF NOT EXISTS / IDs) | OK |
+| five `php_method_map_test.go` | D-04 | yes | no | no | value (map completeness) | OK |
+| forum `golden_test.go` / `api/json_test.go` | D-18 | yes | no | no — `_source` is PHP corpus / “live capture NOT RUN” | value (normalized DOM / stored HTML) | OK |
+| chatvideo `classes/livekit_token_test.go` | D-13 | yes | no | no — PHP LiveKitService.php claims fixture | value | OK |
+| herald `http_tracer_test.go` TestSendEventRollback | D-11 | yes (postgres) | short-skip in testmain | no | behavioral | OK |
+| userfriends `user_deleting_test.go` | D-03 | yes (postgres) | short-skip | no | behavioral | OK |
+
+**Disabled tests on requirements:** 0 → no blocker  
+**Circular patterns detected:** 0 → goldens cite PHP fixtures, not live capture of the Go SUT  
+**Insufficient assertions:** 0
+
+`t.Skip("requires testcontainers postgres")` lives only in each repo’s `testmain_test.go` for `-short`. Those names are required in the postgres stage, which ran and passed.
+
+### Anti-Patterns Found
+
+| File | Line | Pattern | Severity | Impact |
+| ---- | ---- | ------- | -------- | ------ |
+| `../sm-userfriends-plugin/go.mod` | 6 | direct `require sm-chat-plugin` | ⚠️ Warning | Plan 01 prohibition says go.mod never require chat. Needed for typed `Lookup[*chatcontracts.Registry]` (D-08). Requires() still omits chat. See Human Verification. |
+| `../sm-forum-plugin/go.mod` | 85, 120 | bluemonday/goldmark **indirect** | ℹ️ Info | Not a direct require. D-17 “never requires” is met. |
+| `../sm-chatvideo-plugin/go.mod` | pion lines | pion **indirect** via LiveKit SDK | ℹ️ Info | Tests do not import pion; no `lksdk.Room` construct. |
+| `../sm-herald-plugin/go.mod` | sm-user-plugin | test-harness require | ℹ️ Info | Production `.go` files do not import user models. Requires() empty. |
+| five `*-SUMMARY.md` (03–06) | frontmatter | `commits:` vs summercms.go `plan_head_before..after` | ⚠️ Warning | Plan 03 claimed 2 / window 0; 04 claimed 3 / window 1; 05 claimed 3 / window 1; 06 claimed 12 / window 1. Work landed in sibling repos (git logs show the feat/test commits). Instrument measures this repo only. Not a missing-implementation gap. |
+| Phase directory | — | no `*-SECURITY.md` | ⚠️ Warning | Plan 06 / CONTEXT asked for a security-review pass after APIs+push+tokens+HTML+GDPR exist. Planner did not spawn it. Discretion, not a must-have truth. |
+
+No `TBD` / `FIXME` / `XXX` in phase-touched Go or the gate script.
+
+**This looks intentional** (userfriends go.mod). To accept the deviation, add to this file’s frontmatter:
+
+```yaml
+overrides:
+  - must_have: "Requires() and go.mod never require sm-chat-plugin"
+    reason: "D-08 soft adapter is a typed Lookup of sm-chat-plugin/contracts.Registry; go.mod must list the module. Requires() stays golem15.user only; missing chat is a Boot skip."
+    accepted_by: "{name}"
+    accepted_at: "{ISO timestamp}"
+```
+
+Then re-run verification so the prohibition can become PASSED (override).
+
+### Human Verification Required
+
+### 1. Accept userfriends go.mod chat import (planner contradiction)
+
+**Test:** Confirm that `../sm-userfriends-plugin/go.mod` requiring `sm-chat-plugin` is acceptable because Boot does `Lookup[*chatcontracts.Registry]` and skips when chat is absent, while `Plugin.Requires()` remains `[]string{"golem15.user"}`.
+**Expected:** Override recorded. No production code change.
+**Why human:** Plan 01 `must_haves.prohibitions` forbids the go.mod require in the same breath as D-08 requiring a typed Registry Lookup. Grep cannot resolve a planner contradiction.
+
+### Gaps Summary
+
+No implementation gaps. All 16 merged truths are present, wired, data-flowing, and (where behavior-dependent) exercised by named tests that passed this session, including Docker postgres tracers.
+
+The phase is **not** `passed` solely because a grep-tier prohibition failed as written and must not be silently absorbed. Accept the override above (or rewrite the prohibition) and re-verify.
+
+---
+
+_Verified: 2026-10-18T14:15:00Z_  
+_Verifier: Claude (msd-verifier)_