docs(18-08): complete Stripe decline gap-closure plan
- 18-08-SUMMARY.md: four sm-pgstripe-plugin commits, 17-subtest TestHostStripeFlow, gate stages, decisions, open follow-ups - push reply recorded verbatim; sm-pgstripe-plugin main pushed to 0313820, no tag - STATE and ROADMAP: plan 18-08 complete (8/8), three decisions, session record
This commit is contained in:
Jakub Zych
@@ -1113,7 +1113,7 @@ Plans:
|
||||
4. A host test proves the order-create, Stripe-pay and order-paid flow that Horoskopia relies on.
|
||||
5. The new code has unit tests, delivered in the phase's last plan.
|
||||
|
||||
**Plans:** 7/8 plans executed
|
||||
**Plans:** 8/8 plans executed
|
||||
|
||||
Plans:
|
||||
**Wave 1**
|
||||
@@ -1138,7 +1138,7 @@ Plans:
|
||||
- [x] 18-07-PLAN.md — Unit tests last: the 74-case PHP map, money and FSM matrices, legacy fixtures, security evidence, framework and layer tests, `scripts/check-phase18.sh`, validated 18-VALIDATION.md, final push approval
|
||||
|
||||
**Wave 8** *(gap closure; blocked on 18-05 and 18-07)*
|
||||
- [ ] 18-08-PLAN.md — Gap closure SC-2 (sm-pgstripe-plugin): `payment_intent.payment_failed` logged and non-terminal so a declined-then-retried payment is accepted; a paid signal on a payment that refuses Accept is logged at Error level (replays silent); expired and canceled stay no-ops by decision; decline-then-succeed proofs in both modes, Docker-free decline coverage, README event table; push with go-ahead, no tag
|
||||
- [x] 18-08-PLAN.md — Gap closure SC-2 (sm-pgstripe-plugin): `payment_intent.payment_failed` logged and non-terminal so a declined-then-retried payment is accepted; a paid signal on a payment that refuses Accept is logged at Error level (replays silent); expired and canceled stay no-ops by decision; decline-then-succeed proofs in both modes, Docker-free decline coverage, README event table; push with go-ahead, no tag
|
||||
|
||||
### Phase 18.1: Payment Gateway Subscriptions (INSERTED)
|
||||
|
||||
@@ -1343,7 +1343,7 @@ Phases execute in numeric order: 1 → 2 → 3 → 4 → 5 → 6 → 7 → 8 →
|
||||
| 15. Journal plugin | 4/4 | Complete | 2026-10-06 |
|
||||
| 16. grzybyfunkcjonalne.pl on reusable blog views | 5/5 | In Progress| |
|
||||
| 17. Blog companions | 6/6 | In Progress| |
|
||||
| 18. Payment Gateway | 7/7 | In Progress| |
|
||||
| 18. Payment Gateway | 8/8 | In Progress| |
|
||||
| 18.1. Payment Gateway Subscriptions | 0/TBD | Not started | - |
|
||||
| 19. Chat and ChatChannels | 0/TBD | Not started | - |
|
||||
| 19.1. Chat satellites | 0/TBD | Not started | - |
|
||||
|
||||
@@ -4,16 +4,16 @@ milestone: v1.0
|
||||
current_phase: 18
|
||||
current_phase_name: Payment Gateway
|
||||
status: executing
|
||||
stopped_at: Completed 18-07-PLAN.md
|
||||
last_updated: "2026-10-13T16:43:35.617Z"
|
||||
stopped_at: Completed 18-08-PLAN.md
|
||||
last_updated: "2026-10-13T22:20:51.124Z"
|
||||
last_activity: 2026-10-13
|
||||
last_activity_desc: Phase 18 execution started
|
||||
state_head: 96f094bcb0b837928f7794eeac671ac402a71070
|
||||
state_head: d1f39cc109c410fc9a0325b352b1df4361e63f55
|
||||
progress:
|
||||
total_phases: 40
|
||||
completed_phases: 14
|
||||
total_plans: 176
|
||||
completed_plans: 175
|
||||
completed_plans: 176
|
||||
gsd_state_version: "1.0"
|
||||
milestone_name: milestone
|
||||
---
|
||||
@@ -29,8 +29,8 @@ See: .planning/PROJECT.md (updated 2026-10-12)
|
||||
|
||||
## Current Position
|
||||
|
||||
Phase: 18 (Payment Gateway) — READY TO EXECUTE
|
||||
Plan: 7 of 7
|
||||
Phase: 18 (Payment Gateway) — EXECUTING
|
||||
Plan: 8 of 8
|
||||
Status: Ready to execute
|
||||
Last activity: 2026-10-13 — Phase 18 execution started
|
||||
|
||||
@@ -232,6 +232,7 @@ Progress: [████░░░░░░] 44%
|
||||
| Phase 18 P05 | 20min | 3 tasks | 31 files |
|
||||
| Phase 18 P06 | 70min | 6 tasks | 52 files |
|
||||
| Phase 18 P07 | 75 min | 5 tasks | 62 files |
|
||||
| Phase 18 P08 | 20min | 4 tasks | 7 files |
|
||||
|
||||
## Accumulated Context
|
||||
|
||||
@@ -775,6 +776,9 @@ Recent decisions affecting current work:
|
||||
- [Phase 18]: 18-07 money fields accept trailing zeros beyond the scale (fix eb60c32), published in v0.1.25
|
||||
- [Phase 18]: 18-07 fixtures none: synthetic legacy rows stand in for D-11; TestLegacyFixtures picks up shop-export rows later
|
||||
- [Phase 18]: 18-07 the two pgstripe reliability tests are 18.1; replay_and_race is Phase 18 idempotency evidence
|
||||
- [Phase 18]: 18-08: payment_intent.payment_failed is not terminal: the Stripe operator logs one Warn line and leaves the payment Sent; only checkout.session.async_payment_failed rejects; checkout.session.expired and payment_intent.canceled stay 200 no-ops closed by pg:cancel-sent-payments — Stripe sends the event on every declined attempt and the customer may retry on the same Checkout page or client secret; Reject is final, and PHP never moved a payment from a notification except to Accept (gap 1 of 18-VERIFICATION, A-CR-01)
|
||||
- [Phase 18]: 18-08: a paid signal the payment machine refuses is logged at Error level (refuses Accept) for never-accepted payments; Accepted and Refunded are silent; no payment event, automatic refund or data write — The log line is the alert hook; a new event would be a public contract on a shared plugin with no listener, and a refund moves money (A-CR-02 logging half; session expiry on cancel stays open)
|
||||
- [Phase 18]: 18-08 push: sm-pgstripe-plugin main pushed to 0313820 after the human reply push; no tag, summercms.go not pushed — Task 4 checkpoint:decision; no application mounts the plugin yet, so no pointer bump
|
||||
|
||||
### Pending Todos
|
||||
|
||||
@@ -853,6 +857,6 @@ Items acknowledged and carried forward from previous milestone close:
|
||||
|
||||
## Session Continuity
|
||||
|
||||
Last session: 2026-10-13T15:47:20.063Z
|
||||
Stopped at: Completed 18-07-PLAN.md
|
||||
Last session: 2026-10-13T22:20:33.417Z
|
||||
Stopped at: Completed 18-08-PLAN.md
|
||||
Resume file: None
|
||||
|
||||
307
.planning/phases/18-payment-gateway/18-08-SUMMARY.md
Normal file
307
.planning/phases/18-payment-gateway/18-08-SUMMARY.md
Normal file
@@ -0,0 +1,307 @@
|
||||
---
|
||||
phase: 18-payment-gateway
|
||||
plan: 08
|
||||
subsystem: payments
|
||||
tags: [pgstripe, stripe, webhook, gap-closure, payment-failed, decline-retry, refused-accept, logging, testcontainers, proof-host]
|
||||
|
||||
requires:
|
||||
- phase: 18-05
|
||||
provides: sm-pgstripe-plugin (the Stripe operator, the webhook event table, the browser return) and the proof host TestHostStripeFlow
|
||||
- phase: 18-07
|
||||
provides: TestStripeOperator, TestStripeWebhook and scripts/check-phase18.sh (stages plugins and postgres)
|
||||
provides:
|
||||
- a non-terminal payment_intent.payment_failed (one Warn line, the payment stays Sent), so a declined-then-retried payment is accepted in Checkout and PaymentIntent modes
|
||||
- the exported pgstripe.PaymentError (Code, DeclineCode, Type) and EventObject.LastPaymentError; the decline message is never decoded
|
||||
- an Error log line ("refuses Accept") for a paid signal on a payment that was never accepted and can no longer be; Accepted and Refunded stay silent
|
||||
- TestHostStripeFlow at 17 subtests (decline_then_succeed, decline_then_succeed_payment_intent, paid_after_final_state; event_table corrected and extended)
|
||||
- Docker-free decline, expired/canceled and last_payment_error decode coverage
|
||||
- the README event table and Stripe Dashboard step as implemented
|
||||
- sm-pgstripe-plugin main published at 0313820 (no tag)
|
||||
affects: [phase 18 verification (gap 1 of 18-VERIFICATION.md), 18.1 subscriptions, applications that later mount sm-pgstripe-plugin]
|
||||
|
||||
actuals:
|
||||
tokens: 12636 # chars/4 over the realized sm-pgstripe-plugin diff d488834..0313820 (50,542 bytes)
|
||||
tasks: 4
|
||||
commits: 0 # measured in summercms.go (d1f39cc..HEAD before this SUMMARY): the code lives in the sibling repository
|
||||
plan_head_before: d1f39cc109c410fc9a0325b352b1df4361e63f55
|
||||
plan_head_after: d1f39cc109c410fc9a0325b352b1df4361e63f55
|
||||
plugin_commits: 4 # measured: git -C ../sm-pgstripe-plugin rev-list --count d488834..HEAD
|
||||
plugin_head_before: d4888349926c517ad27ad2865e93cc6d490bf7ea
|
||||
plugin_head_after: 0313820f8deb221ffb3fa837ed582152f59d72ee
|
||||
|
||||
tech-stack:
|
||||
added: []
|
||||
patterns:
|
||||
- "A provider webhook moves a payment only on a terminal signal; a retryable decline is logged and leaves the payment open"
|
||||
- "A paid signal the payment machine refuses is an Error log line with every id needed for a manual refund; no transition, event, data write or provider call"
|
||||
- "Decode only the fields that may be logged (PaymentError has no message field), so no code path can leak the decline text"
|
||||
- "Log assertions keep level and attributes (capturedLog/find in the host test, recordHandler in the Docker-free test)"
|
||||
|
||||
key-files:
|
||||
created: []
|
||||
modified:
|
||||
- ../sm-pgstripe-plugin/webhook.go
|
||||
- ../sm-pgstripe-plugin/operator.go
|
||||
- ../sm-pgstripe-plugin/browser_return.go
|
||||
- ../sm-pgstripe-plugin/host_test.go
|
||||
- ../sm-pgstripe-plugin/operator_test.go
|
||||
- ../sm-pgstripe-plugin/webhook_test.go
|
||||
- ../sm-pgstripe-plugin/README.md
|
||||
|
||||
key-decisions:
|
||||
- "payment_intent.payment_failed is not terminal: one Warn line, the payment stays Sent (supersedes the optional Reject of RESEARCH Pattern 6)"
|
||||
- "checkout.session.async_payment_failed keeps rejecting; checkout.session.expired and payment_intent.canceled stay 200 no-ops and pg:cancel-sent-payments closes the abandoned payment, as on PHP"
|
||||
- "A paid signal the machine refuses is logged at Error level for every never-accepted state; Accepted and Refunded are silent; no payment event, no automatic refund, no data write"
|
||||
- "Task 4 push: human reply verbatim \"push\"; sm-pgstripe-plugin main pushed to 0313820, no tag, summercms.go not pushed"
|
||||
|
||||
patterns-established:
|
||||
- "Gap-closure plan carrying its own tests as the phase's last plan"
|
||||
|
||||
requirements-completed: [SC-2, SC-4, D-14, D-16]
|
||||
|
||||
coverage:
|
||||
- id: D1
|
||||
description: "A declined attempt (payment_intent.payment_failed) leaves the payment Sent and is logged once at Warn level with ids and Stripe's codes, never the decline message"
|
||||
requirement: "SC-2"
|
||||
verification:
|
||||
- kind: integration
|
||||
ref: "../sm-pgstripe-plugin/host_test.go#TestHostStripeFlow/decline_then_succeed, /event_table (Postgres; first executor's run, t3-host.log)"
|
||||
status: pass
|
||||
- kind: unit
|
||||
ref: "../sm-pgstripe-plugin/operator_test.go#TestStripeOperator/a_declined_attempt_is_logged_and_never_rejected (re-run at the pushed head)"
|
||||
status: pass
|
||||
- kind: unit
|
||||
ref: "../sm-pgstripe-plugin/webhook_test.go#TestStripeWebhook/last_payment_error_decodes_its_codes (re-run at the pushed head)"
|
||||
status: pass
|
||||
human_judgment: false
|
||||
- id: D2
|
||||
description: "Decline then succeed pays the order in Checkout and PaymentIntent modes; a late redelivery of the decline changes nothing"
|
||||
requirement: "SC-2, D-16"
|
||||
verification:
|
||||
- kind: integration
|
||||
ref: "../sm-pgstripe-plugin/host_test.go#TestHostStripeFlow/decline_then_succeed"
|
||||
status: pass
|
||||
- kind: integration
|
||||
ref: "../sm-pgstripe-plugin/host_test.go#TestHostStripeFlow/decline_then_succeed_payment_intent"
|
||||
status: pass
|
||||
human_judgment: false
|
||||
- id: D3
|
||||
description: "A paid signal (event or browser return) for a Canceled or Rejected payment changes nothing and writes one Error line; replays and refunded payments stay silent"
|
||||
requirement: "SC-2, D-14"
|
||||
verification:
|
||||
- kind: integration
|
||||
ref: "../sm-pgstripe-plugin/host_test.go#TestHostStripeFlow/paid_after_final_state"
|
||||
status: pass
|
||||
human_judgment: false
|
||||
- id: D4
|
||||
description: "checkout.session.async_payment_failed rejects; checkout.session.expired and payment_intent.canceled are 200 no-ops"
|
||||
requirement: "SC-2"
|
||||
verification:
|
||||
- kind: integration
|
||||
ref: "../sm-pgstripe-plugin/host_test.go#TestHostStripeFlow/event_table"
|
||||
status: pass
|
||||
- kind: unit
|
||||
ref: "../sm-pgstripe-plugin/operator_test.go#TestStripeOperator/expired_sessions_and_canceled_intents_change_nothing (re-run at the pushed head)"
|
||||
status: pass
|
||||
human_judgment: false
|
||||
- id: D5
|
||||
description: "Phase gate stays green with the fix: stages plugins and postgres (PHASE18_REQUIRE_POSTGRES=1)"
|
||||
requirement: "SC-4"
|
||||
verification:
|
||||
- kind: other
|
||||
ref: "bash scripts/check-phase18.sh plugins ('phase18 plugins passed', t3-plugins.log)"
|
||||
status: pass
|
||||
- kind: other
|
||||
ref: "PHASE18_REQUIRE_POSTGRES=1 bash scripts/check-phase18.sh postgres ('phase18 postgres passed', t3-postgres.log)"
|
||||
status: pass
|
||||
human_judgment: false
|
||||
- id: D6
|
||||
description: "README states the event mapping as implemented (event list, Dashboard step, PaymentError, Testing notes)"
|
||||
verification: []
|
||||
human_judgment: true
|
||||
rationale: "Grep acceptance criteria pass, but whether the prose is accurate and clear for operators is a reading judgment"
|
||||
- id: D7
|
||||
description: "sm-pgstripe-plugin main published after the human's reply; no tag"
|
||||
verification:
|
||||
- kind: other
|
||||
ref: "git -C ../sm-pgstripe-plugin rev-parse HEAD == origin/main == ls-remote refs/heads/main == 0313820f8deb221ffb3fa837ed582152f59d72ee; git tag and ls-remote --tags empty"
|
||||
status: pass
|
||||
human_judgment: false
|
||||
|
||||
duration: about 20 min active (10 min for Tasks 1 to 3, then the wait at the checkpoint)
|
||||
completed: 2026-10-13
|
||||
status: complete
|
||||
---
|
||||
|
||||
# Phase 18 Plan 08: Gap closure, a Stripe decline is not terminal Summary
|
||||
|
||||
**`payment_intent.payment_failed` no longer rejects the payment: the Stripe operator logs the declined attempt and leaves the payment Sent, so the customer's retry on the same Checkout page or card form is accepted and the order is paid. A paid signal for a payment that can no longer be accepted is logged at Error level instead of being dropped. The four commits are on `sm-pgstripe-plugin` `origin/main` at `0313820`; nothing is tagged.**
|
||||
|
||||
This closes the one failed truth of `18-VERIFICATION.md` (SC-2, review A-CR-01 and the logging half of A-CR-02).
|
||||
|
||||
## Performance
|
||||
|
||||
- **Started:** 2026-10-13T17:28:18Z. **Checkpoint (Task 4) reached:** 2026-10-13T17:38:38Z. **Push and SUMMARY:** 2026-10-13T22:17Z, by a continuation executor after the human's reply.
|
||||
- **Duration:** about 20 min active.
|
||||
- **Tasks:** 4 of 4 (Task 1 tracer, Task 2 auto with `tdd="true"`, Task 3 auto, Task 4 checkpoint:decision answered `push`).
|
||||
- **Files:** 7 in sm-pgstripe-plugin, +650/-33. None in summercms.go besides this SUMMARY and the tracking files.
|
||||
|
||||
## Accomplishments
|
||||
|
||||
- **The decline is not terminal (Task 1).** `handleEvent` gives `payment_intent.payment_failed` its own case. `attemptFailed` writes one Warn line, `golem15.pgstripe: payment attempt failed; the payment stays open for a retry`, with the payment id, uuid, event id, PaymentIntent id and, when Stripe sent them, `code` and `decline_code`. The payment stays Sent, the order stays AwaitingPayment, and no PaymentRejected event or mail is produced. The new exported `PaymentError` decodes `code`, `decline_code` and `type` only, so the decline message cannot be logged.
|
||||
- **A refused paid signal is visible (Task 2).** `accept` takes a trigger (the Stripe event id, or `browser_return`). When the payment machine refuses Accept, `refusedAccept` is silent for Accepted and Refunded and otherwise writes one Error line containing `refuses Accept`, with the payment id, uuid, state, trigger, PaymentIntent id and stored Checkout Session id. It makes no transition, data write, payment event or Stripe call. The answers are unchanged: 200 for an event, 303 for the browser return.
|
||||
- **Expired and canceled are documented no-ops (Task 2).** `checkout.session.expired` and `payment_intent.canceled` answer 200 and leave the payment Sent; the reasons are in the `handleEvent` doc comment and the README.
|
||||
- **Tests (Tasks 1 to 3).** `TestHostStripeFlow` grew from 14 to 17 subtests. `TestStripeOperator` and `TestStripeWebhook` gained three Docker-free subtests.
|
||||
- **README (Task 3).** The webhook event list, the Stripe Dashboard step (the decline event is optional, logged only), `PaymentError` in the API reference and the Testing notes describe the mapping as implemented.
|
||||
|
||||
## Task Commits
|
||||
|
||||
All in `../sm-pgstripe-plugin` on `main`, on top of `d488834`. Measured: `git rev-list --count d488834..HEAD` = 4.
|
||||
|
||||
1. **Task 1: tracer, the decline leaves the payment open** - `0c4fde7` (fix): webhook.go, host_test.go
|
||||
2. **Task 2: Error line for a paid payment that refuses Accept** - `f5c10e8` (fix): operator.go, browser_return.go, webhook.go, host_test.go
|
||||
3. **Task 3: Docker-free coverage, the PaymentIntent proof, README** - `be75108` (test): operator_test.go, webhook_test.go, host_test.go; `0313820` (docs): README.md
|
||||
4. **Task 4: push approval** - checkpoint:decision, reply `push` (see Push)
|
||||
|
||||
No commit carries a co-author trailer (`git log d488834..HEAD` searched for `co-authored`: 0).
|
||||
|
||||
summercms.go: no code commit. **Plan metadata:** the commit holding this SUMMARY with STATE and ROADMAP.
|
||||
|
||||
## Event mapping as implemented
|
||||
|
||||
| Stripe event | Effect on the payment |
|
||||
|--------------|-----------------------|
|
||||
| `checkout.session.completed` with `payment_status` paid | Accept (unpaid: nothing) |
|
||||
| `checkout.session.async_payment_succeeded` | Accept |
|
||||
| `checkout.session.async_payment_failed` | Reject (terminal: the asynchronous payment of a completed session failed) |
|
||||
| `payment_intent.succeeded` | Accept, recording the charge |
|
||||
| `payment_intent.payment_failed` | none; one Warn line |
|
||||
| `checkout.session.expired`, `payment_intent.canceled` | none; `pg:cancel-sent-payments` closes the abandoned payment after `payment_sent_to_canceled_timeout` |
|
||||
| any other type | 200, no change |
|
||||
|
||||
A paid signal while Accept is refused: nothing changes; one Error line unless the payment is Accepted or Refunded.
|
||||
|
||||
## TestHostStripeFlow subtests
|
||||
|
||||
Run on Postgres (testcontainers) by the first executor after Task 3; `t3-host.log` shows 17 PASS lines and `ok` in 14.3 s. The count was 15 after Task 1 and 16 after Task 2 (`t1-host.log`, `t2-host.log`).
|
||||
|
||||
| # | Subtest | Result |
|
||||
|---|---------|--------|
|
||||
| 1 | checkout_operator_path | PASS |
|
||||
| 2 | payment_intent_operator_path | PASS |
|
||||
| 3 | payment_intent_confirmed_and_declined | PASS |
|
||||
| 4 | decline_then_succeed (new, Task 1) | PASS |
|
||||
| 5 | decline_then_succeed_payment_intent (new, Task 3) | PASS |
|
||||
| 6 | per_order_override | PASS |
|
||||
| 7 | consumer_driven_path_b | PASS |
|
||||
| 8 | wrong_secret | PASS |
|
||||
| 9 | missing_header | PASS |
|
||||
| 10 | missing_secret | PASS |
|
||||
| 11 | older_api_version | PASS |
|
||||
| 12 | replay_and_race | PASS |
|
||||
| 13 | browser_return | PASS |
|
||||
| 14 | refund | PASS |
|
||||
| 15 | event_table (decline case corrected; expired and canceled cases added) | PASS |
|
||||
| 16 | paid_after_final_state (new, Task 2) | PASS |
|
||||
| 17 | no_secret_key | PASS |
|
||||
|
||||
New Docker-free subtests, re-run by the continuation executor at the pushed head (`go test -count=1 -short -run '^(TestStripeOperator|TestStripeWebhook)$' -v .`):
|
||||
|
||||
- `TestStripeOperator/a_declined_attempt_is_logged_and_never_rejected` PASS
|
||||
- `TestStripeOperator/expired_sessions_and_canceled_intents_change_nothing` PASS
|
||||
- `TestStripeWebhook/last_payment_error_decodes_its_codes` PASS
|
||||
|
||||
## Gate stages run
|
||||
|
||||
| Stage | Result | Evidence |
|
||||
|-------|--------|----------|
|
||||
| `bash scripts/check-phase18.sh plugins` | `phase18 plugins passed` (vet and `-short` in both plugins; 6 pgstripe top-level tests by name) | first executor, `t3-plugins.log` |
|
||||
| `PHASE18_REQUIRE_POSTGRES=1 bash scripts/check-phase18.sh postgres` | `phase18 postgres passed` (cabana 9, sm-paymentgateway-plugin 22, sm-pgstripe-plugin 3) | first executor, `t3-postgres.log` |
|
||||
| Task 4 verify (`plugins` and a clean plugin tree) | `gap-gate-ok` | first executor's note |
|
||||
| `go vet ./...` and `go test -count=1 -short ./...` in sm-pgstripe-plugin | green | first executor at each commit; continuation executor at the pushed head |
|
||||
|
||||
The other stages (go, admin, layers, docs, `--self-test`) were not run in this plan: it changes no file they cover. The Docker suites were not re-run after the push; the push changed no file.
|
||||
|
||||
## Decisions Made
|
||||
|
||||
As recorded in the plan and implemented:
|
||||
|
||||
1. **The decline is not terminal.** It supersedes the optional Reject of RESEARCH Pattern 6.
|
||||
2. **`checkout.session.async_payment_failed` keeps rejecting.**
|
||||
3. **`checkout.session.expired` and `payment_intent.canceled` neither reject nor cancel.** PHP never moved a payment from a notification except to Accept; a terminal transition would first need the event object id matched against the stored session or intent id.
|
||||
4. **The Error branch covers every state that was never accepted.** Rejected, Canceled, or Created/Sent with the operator guard refusing. Accepted and Refunded are silent, because a Checkout Session still reports paid after a refund.
|
||||
5. **No event, no automatic refund, no data write on the Error path.** The Error line is the alert hook.
|
||||
6. **The purchase-time status mapping is unchanged.** A server-confirmed decline at Purchase still ends Send plus Reject.
|
||||
7. **Release.** Commits only until the reply; then one push, no tag.
|
||||
|
||||
`sm-paymentgateway-plugin` and its payment machine are untouched: clean tree at `f55320a`.
|
||||
|
||||
## Deviations from Plan
|
||||
|
||||
### Auto-fixed Issues
|
||||
|
||||
None.
|
||||
|
||||
### Plan adjustments
|
||||
|
||||
1. **Task 2 RED state observed but not committed.** Task 2 is `tdd="true"`. The first executor ran the new `paid_after_final_state` subtest before the implementation and saw it fail at host_test.go:1082 ("Error records for the Canceled payment: 0, want 1"). The plan fixes one commit for Task 2 and the plan type is `execute`, so test and implementation are in the single commit `f5c10e8`. There is no separate `test(...)` RED commit in history.
|
||||
2. **Test additions beyond the plan text.** A control case in the Docker-free decline subtest, snapshot comparisons, and a doc comment on `TestStripeOperator`. No existing assertion was removed, by the first executor's account; the `event_table` decline case now asserts the corrected outcome, as the plan requires.
|
||||
|
||||
**Total deviations:** 0 auto-fixed, 2 plan adjustments. **Impact:** none on the plan's contracts.
|
||||
|
||||
## Issues Encountered
|
||||
|
||||
None.
|
||||
|
||||
## Open follow-ups (not fixed here)
|
||||
|
||||
- **A-CR-02, remainder:** expire the Checkout Session from a PaymentCanceled listener, and an admin notice for a paid payment that cannot be accepted. This plan delivers the Error log line only.
|
||||
- **A-IN-02:** early handling of `checkout.session.expired` after matching the stored session id.
|
||||
- **A-WR-01 to A-WR-05:** the payment does not record its own mode; accepted events are not checked against amount, currency or session/intent id; rounding for non-two-decimal currencies; no idempotency key on the refund; outbound Stripe calls under the row lock on the unauthenticated browser return.
|
||||
- **Settings copy:** `lang.settings.webhook_comment` (en and pl) still lists the three accepting events only. It is a pre-existing text that this plan leaves unchanged; the README's Dashboard step is the complete list.
|
||||
- **App pointer bump:** none needed. No `.gitmodules`, `go.mod` or `go.work` outside the plugin's own `go.mod` names `sm-pgstripe-plugin` (re-checked before the push).
|
||||
|
||||
## Known Stubs
|
||||
|
||||
None.
|
||||
|
||||
## Threat Flags
|
||||
|
||||
None. The register's mitigations are covered:
|
||||
- T-18-49: `decline_then_succeed`, `decline_then_succeed_payment_intent`, `event_table`, and the Docker-free decline subtest (no payment service published, so a transition would fail it).
|
||||
- T-18-50: `paid_after_final_state` (exactly three Error records).
|
||||
- T-18-51: `PaymentError` has no message field (`grep -c 'json:"message"' webhook.go` = 0); the Docker-free subtest asserts the message text is in no record.
|
||||
- T-18-52: the gateway repository is clean at `f55320a`; `refusedAccept` makes no transition.
|
||||
- T-18-SC: no package installed; go.mod and go.sum untouched.
|
||||
|
||||
## User Setup Required
|
||||
|
||||
None. An operator who already subscribed a Stripe endpoint to `payment_intent.payment_failed` may keep it: the event is now logged only.
|
||||
|
||||
## Push (Task 4)
|
||||
|
||||
**Human reply (verbatim):** `push`
|
||||
|
||||
The reply reached the continuation executor through the orchestrator. It authorised one push and nothing else.
|
||||
|
||||
Before the push, in sm-pgstripe-plugin: `git status --porcelain` empty; `git fetch origin` exit 0; `origin/main` still `d488834`; `HEAD...origin/main` 4 ahead, 0 behind. The push was `git -C ../sm-pgstripe-plugin push origin main`, no force:
|
||||
|
||||
| Repository | Branch | Range pushed | Pushed head |
|
||||
|------------|--------|--------------|-------------|
|
||||
| sm-pgstripe-plugin | main | `d488834..0313820` (4 commits) | `0313820f8deb221ffb3fa837ed582152f59d72ee` |
|
||||
|
||||
**Verification after the push:** local `HEAD`, `origin/main` and `ls-remote origin refs/heads/main` all read `0313820f8deb221ffb3fa837ed582152f59d72ee`. `git tag` and `ls-remote --tags origin` print nothing.
|
||||
|
||||
Not done, on purpose: no tag in any repository, no push of summercms.go (its planning commits stay local), no deploy, no app pointer bump.
|
||||
|
||||
## Next Phase Readiness
|
||||
|
||||
- Phase 18's gap closure is executed. The next step is the verifier's re-run (`/msd-verify-work 18`), which re-checks gap 1 of `18-VERIFICATION.md` against the pushed head. VERIFICATION and VALIDATION are updated only through that flow.
|
||||
- The open review findings above remain for a later decision; none blocks the gap truth.
|
||||
|
||||
## Self-Check: PASSED
|
||||
|
||||
- Files exist in sm-pgstripe-plugin: webhook.go, operator.go, browser_return.go, host_test.go, operator_test.go, webhook_test.go, README.md.
|
||||
- Commits exist: `0c4fde7`, `f5c10e8`, `be75108`, `0313820` (all in `d488834..origin/main`).
|
||||
- Acceptance re-run at the pushed head: `"last_payment_error"` 1 and `type PaymentError struct` 1 in webhook.go; `o.reject(` 1; `json:"message"` 0; `refuses Accept` in operator.go; `o.accept(ctx, pc, ev.ID` 3; `browserReturnTrigger` 3 in browser_return.go; `pg:cancel-sent-payments` in webhook.go and README.md; `PaymentError` in README.md; `payment_intent.payment_failed` 2 in README.md; the three new `t.Run` names in host_test.go; no consuming application named in `*.go` or `*.md`; plugin tree clean; gateway clean at `f55320a`.
|
||||
- Not re-run by the continuation executor: the Postgres suites and the two gate stages. Their results are the first executor's logs quoted above.
|
||||
@@ -91,7 +91,7 @@
|
||||
{
|
||||
"number": "14.2",
|
||||
"name": "Local Fonoteka frontend on local SummerCMS backend (INSERTED)",
|
||||
"status": "pending"
|
||||
"status": "complete"
|
||||
},
|
||||
{
|
||||
"number": "14.3",
|
||||
@@ -111,12 +111,12 @@
|
||||
{
|
||||
"number": "17",
|
||||
"name": "Blog companions",
|
||||
"status": "pending"
|
||||
"status": "in_progress"
|
||||
},
|
||||
{
|
||||
"number": "18",
|
||||
"name": "Payment Gateway",
|
||||
"status": "pending"
|
||||
"status": "in_progress"
|
||||
},
|
||||
{
|
||||
"number": "18.1",
|
||||
@@ -167,7 +167,7 @@
|
||||
"next": {
|
||||
"command": "/msd:progress --next",
|
||||
"label": "Advance to the next step",
|
||||
"reason": "Phase 14.2 of 40 · executing"
|
||||
"reason": "Phase 18 of 40 · executing"
|
||||
},
|
||||
"updated_at": "2026-10-11T15:48:22.885Z"
|
||||
"updated_at": "2026-10-13T22:19:45.651Z"
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user