golem15/msd-core
3
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(rulesets): correct status-check context order (os, node)

Browse Source 
The GitHub Actions matrix in test.yml is ordered {os, node-version},
so matrix-derived check contexts are 'test (<os>, <node>)'. The
ruleset specs had the inverse, so the required_status_checks rule
silently watches for names that never appear in any check run.

In evaluate mode this is a no-op; flipping to 'active' without this
fix would deadlock every PR.

Closes #111
Refs #107
This commit is contained in:
Tom Boucher
2026-05-22 10:42:22 -04:00
parent 00a47e34fd
commit b6ead21971
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
.github/rulesets/main-protection.json vendored
View File

@@ -35,12 +35,12 @@
"strict_required_status_checks_policy": true,
"required_status_checks": [
{ "context": "lint-tests" },
{ "context": "test (22, ubuntu-latest)" },
{ "context": "test (22, macos-latest)" },
{ "context": "test (22, windows-latest)" },
{ "context": "test (24, ubuntu-latest)" },
{ "context": "test (24, macos-latest)" },
{ "context": "test (24, windows-latest)" },
{ "context": "test (ubuntu-latest, 22)" },
{ "context": "test (macos-latest, 22)" },
{ "context": "test (windows-latest, 22)" },
{ "context": "test (ubuntu-latest, 24)" },
{ "context": "test (macos-latest, 24)" },
{ "context": "test (windows-latest, 24)" },
{ "context": "Changeset Required" },
{ "context": "require-issue-link" },
{ "context": "pr-template-format" }

12
.github/rulesets/release-branches.json vendored
View File

@@ -32,12 +32,12 @@
"strict_required_status_checks_policy": true,
"required_status_checks": [
{ "context": "lint-tests" },
{ "context": "test (22, ubuntu-latest)" },
{ "context": "test (22, macos-latest)" },
{ "context": "test (22, windows-latest)" },
{ "context": "test (24, ubuntu-latest)" },
{ "context": "test (24, macos-latest)" },
{ "context": "test (24, windows-latest)" },
{ "context": "test (ubuntu-latest, 22)" },
{ "context": "test (macos-latest, 22)" },
{ "context": "test (windows-latest, 22)" },
{ "context": "test (ubuntu-latest, 24)" },
{ "context": "test (macos-latest, 24)" },
{ "context": "test (windows-latest, 24)" },
{ "context": "Changeset Required" },
{ "context": "require-issue-link" },
{ "context": "pr-template-format" }