docs(35): re-verify phase after gap closure - CR-01 gap found

This commit is contained in:
Jakub Zych
2026-11-13 22:33:37 +01:00
parent b1f85c2177
commit 0aa38db8b5

View File

@@ -1,8 +1,8 @@
---
phase: 35-mail-templates-and-layouts-editor
verified: 2026-11-13T13:43:11Z
status: human_needed
score: 12/12 must-haves verified
verified: 2026-11-13T21:30:50Z
status: gaps_found
score: 13/14 must-haves verified
covered_files:
- .planning/phases/35-mail-templates-and-layouts-editor/35-01-PLAN.md
- .planning/phases/35-mail-templates-and-layouts-editor/35-01-SUMMARY.md
@@ -12,11 +12,18 @@ covered_files:
- .planning/phases/35-mail-templates-and-layouts-editor/35-03-SUMMARY.md
- .planning/phases/35-mail-templates-and-layouts-editor/35-04-PLAN.md
- .planning/phases/35-mail-templates-and-layouts-editor/35-04-SUMMARY.md
- .planning/phases/35-mail-templates-and-layouts-editor/35-05-PLAN.md
- .planning/phases/35-mail-templates-and-layouts-editor/35-05-SUMMARY.md
- .planning/phases/35-mail-templates-and-layouts-editor/35-06-PLAN.md
- .planning/phases/35-mail-templates-and-layouts-editor/35-06-SUMMARY.md
- .planning/phases/35-mail-templates-and-layouts-editor/35-07-PLAN.md
- .planning/phases/35-mail-templates-and-layouts-editor/35-07-SUMMARY.md
- admin/openapi/admin.json
- admin/package-lock.json
- admin/package.json
- admin/src/api/schema.d.ts
- admin/src/api/types.ts
- admin/src/components/form/LocaleVariantSwitcher.vue
- admin/src/components/form/codeeditor/editor.ts
- admin/src/components/form/fields/CodeEditorField.vue
- admin/src/components/form/fields/ColorPickerField.vue
@@ -38,6 +45,7 @@ covered_files:
- admin/tests/form/CodeEditorField.test.ts
- admin/tests/form/ColorPickerField.test.ts
- admin/tests/form/FormViewMail.test.ts
- admin/tests/form/LocaleVariantSwitcher.test.ts
- admin/tests/form/MailImageField.test.ts
- admin/tests/form/MailImagePicker.test.ts
- admin/tests/form/MailPreviewField.test.ts
@@ -55,6 +63,8 @@ covered_files:
- docs/services/mail.md
- docs/services/rate-limiting.md
- docs/services/storage.md
- go.mod
- go.sum
- modules/boardwalk/dist/assets/dm-mono-latin-400-normal--0xN8mdc.woff
- modules/boardwalk/dist/assets/dm-mono-latin-400-normal-4GdczIuU.woff2
- modules/boardwalk/dist/assets/dm-mono-latin-500-normal-CN8Miw6E.woff
@@ -79,12 +89,12 @@ covered_files:
- modules/boardwalk/dist/assets/dm-sans-latin-ext-600-normal-DRtaDpgU.woff
- modules/boardwalk/dist/assets/dm-sans-latin-ext-700-normal-BLI3TTWz.woff
- modules/boardwalk/dist/assets/dm-sans-latin-ext-700-normal-CJIcxD6K.woff2
- modules/boardwalk/dist/assets/editor-Bd7FUlHB.js
- modules/boardwalk/dist/assets/editor-DL0km8ky.js
- modules/boardwalk/dist/assets/editor-uDgt9VKj.js
- modules/boardwalk/dist/assets/index-Bvfii4cZ.css
- modules/boardwalk/dist/assets/index-C4FC7bPJ.js
- modules/boardwalk/dist/assets/index-DKWSpBPg.js
- modules/boardwalk/dist/assets/index-Vcq4gwWv.js
- modules/boardwalk/dist/assets/load-BWLbnrie.js
- modules/boardwalk/dist/assets/load-7hoJXD7k.js
- modules/boardwalk/dist/favicon.ico
- modules/boardwalk/dist/index.html
- modules/cabana/README.md
@@ -120,8 +130,10 @@ covered_files:
- modules/cabana/form_schema.go
- modules/cabana/http.go
- modules/cabana/mail_admin.go
- modules/cabana/mail_brand_layout_postgres_test.go
- modules/cabana/mail_diff.go
- modules/cabana/mail_lifecycle_postgres_test.go
- modules/cabana/mail_locale_postgres_test.go
- modules/cabana/mail_permissions_postgres_test.go
- modules/cabana/mail_routes.go
- modules/cabana/mail_screens_smoke_test.go
@@ -147,8 +159,11 @@ covered_files:
- modules/phrasebook/backend/lang/pl/lang.yaml
- modules/postcard/README.md
- modules/postcard/assets/brand.css.tmpl
- modules/postcard/assets/default.htm
- modules/postcard/assets/minimal.htm
- modules/postcard/assets/partials/button.htm
- modules/postcard/assets/partials/footer.htm
- modules/postcard/assets/partials/header.htm
- modules/postcard/assets/partials/panel.htm
- modules/postcard/assets/partials/subcopy.htm
- modules/postcard/assets/partials/table.htm
@@ -160,7 +175,13 @@ covered_files:
- modules/postcard/editor.go
- modules/postcard/editor_smoke_test.go
- modules/postcard/editor_test.go
- modules/postcard/inline.go
- modules/postcard/inline_test.go
- modules/postcard/layouts_test.go
- modules/postcard/locale_postgres_test.go
- modules/postcard/locale_test.go
- modules/postcard/mailer.go
- modules/postcard/mailer_test.go
- modules/postcard/override_smoke_test.go
- modules/postcard/override_test.go
- modules/postcard/partials.go
@@ -175,178 +196,284 @@ covered_files:
- modules/surf/serve.go
- modules/surf/store_lookup_test.go
- scripts/check-phase35.sh
covered_digest: "v2:sha256:402ba8f1c62f397e73e8ea69cc9299bbf5c8aa2dc727d51a0fe6484b18b419ba"
covered_digest: "v2:sha256:f4b2434769c05675324d4203048de747593a6027ea0f5084450f9ea23790f146"
behavior_unverified: 0
overrides_applied: 0
re_verification:
previous_status: human_needed
previous_score: 12/12
gaps_closed:
- "G-35-1: locale variants of one mail template are one admin record with a locale switcher (35-05, tests in 35-07); automated evidence green, visual re-run of UAT test 1 still owed"
- "G-35-8 (framework part): built-in default/system/minimal layouts with logo-or-name header, card, footer, Branding site name, button partial, CSS inlining with opt-out (35-06, tests in 35-07); scoped visual re-run of UAT test 8 still owed"
gaps_remaining: []
regressions:
- "CR-01 (new in 35-06): a site name containing javascript:/vbscript:/data: (Branding Site name, or the display name of mail.from with no admin action) makes every send on the default and system layouts fail, including the file-version fallback; reproduced by the verifier"
gaps:
- truth: "Mail that already works keeps working: an application that sends mail today keeps sending it after upgrading, and no admin-saved Branding value can stop mail on the built-in layouts (roadmap goal clause; 35-06 must-have 'Mail that works today keeps working'; 35-01 D-14 'a failing override never stops mail')"
status: failed
reason: "35-06 began printing siteName (Branding Site name, falling back to the display name of mail.from) in the header and footer of the default and system layouts. Rendered HTML then goes through validateHTML, whose dangerousScheme regex `(?i)(?:javascript|vbscript|data):` matches any substring with no word boundary or attribute context. A sender such as `\"Metadata: Weekly\" <x@example.com>` or a Branding name such as `Big Data: Summit` makes Send return `postcard: rendered HTML contains a dangerous URL scheme` for every template on the default or system layout. The file version is no fallback: mailer.options carries the same siteName into it. At v0.6.3 the same mail.from sent fine, because default.htm printed no name. The Branding form accepts such a name (rules: nullable|max:255, BeforeValidate only trims), and Editor.Validate then refuses every template/layout save on those layouts. Verifier probe (go test -overlay, no source change): from_metadata, brand_big_data, layout default and layout system all return that error; minimal and plain names send. 35-07 pinned the unsafe-name behaviour as current (TestMailBrandSiteName/unsafe_name_current_behaviour) and left it open; no test covers the send path."
artifacts:
- path: "modules/postcard/mailer.go"
issue: "siteName()/options() pass any Branding or mail.from display name into every built-in layout render, file version included, so it can fail the safety check"
- path: "modules/postcard/templates.go"
issue: "dangerousScheme (line 45) is unanchored and runs over the whole rendered document, so plain text such as 'Big Data: Summit' counts as a URL scheme"
- path: "modules/postcard/assets/default.htm"
issue: "header partial and footer copyright print .siteName (system.htm does the same)"
- path: "modules/cabana/mail_admin.go"
issue: "MailBrandSetting site_name has no save-time check (Rules nullable|max:255, BeforeValidate trims only), so the Branding form stores a name that breaks sends and saves"
missing:
- "At render time, a site name never fails a send: drop (or neutralise) a name that would fail the safety check and log a rate-limited warning, on the override path and the file-version path"
- "Save-time refusal on the Branding site_name field with a translated en/pl message (reuse the postcard check, e.g. an exported helper)"
- "Regression tests: Send on default and system layouts with mail.from '\"Metadata: Weekly\" <x@example.com>' and with Branding SiteName 'Big Data: Summit' succeeds; Branding save of an unsafe name is a 422 on site_name; a template save under a previously stored unsafe name is not refused; replace TestMailBrandSiteName/unsafe_name_current_behaviour"
- "Optional, same plan: anchor dangerousScheme to URL-bearing attribute values instead of the whole document (it also rejects body text like 'metadata:'); bundle WR-01 (site name parsed as Markdown in the footer) since it touches the same copyright line"
advisory:
- finding: "Layout status filter hides database-only layouts (WR-01)"
- finding: "WR-01: site name is rendered as Markdown in the footer partial (`*Acme*` becomes <em>, `Acme <Studio>` loses text, `[x](url)` becomes a link) while the header prints it literally"
category: other
reason: "35-REVIEW.md WR-01 — filter customized/outdated require source IS NOT NULL; custom layouts vanish under any status value. Does not break default unfiltered list or editability must-haves."
evidence_status: "code present; advisory from code review"
- finding: "Unknown filterStatus value leaves query unfiltered (WR-02)"
reason: "35-REVIEW.md WR-01; admin-controlled input, cosmetic or consistency issue; fix alongside CR-01"
evidence_status: "reported by code review probe; not re-run by verifier"
- finding: "WR-02: EnsureLocaleRows takes the global advisory lock and upserts sibling rows inside ShowRecord/save transactions, which can deadlock with SyncIndex and makes a GET write"
category: architectural
reason: "35-REVIEW.md WR-02; self-heals (one side's savepoint absorbs the deadlock) but adds ~1s stalls; not goal-blocking"
evidence_status: "code inspection by review; no reproducing test"
- finding: "WR-03: mailLocales swallows TranslationWriter errors while running on the request transaction, so a failed optional-plugin query aborts the transaction and the template show returns 500"
category: other
reason: "35-REVIEW.md WR-02 — soft filter hygiene; wrong values should match nothing."
evidence_status: "code present; advisory from code review"
- finding: "Mail image upload errors ignore field-level ValidationError details (WR-03)"
reason: "35-REVIEW.md WR-03; conditional on a failing optional translation plugin"
evidence_status: "code inspection by review; no reproducing test"
- finding: "WR-04: two-letter fallback-locale rule resolves typos such as order-ok to the base template and rejects 3-letter or multi-subtag locales"
category: other
reason: "35-REVIEW.md WR-03 — UX; operators often see generic Validation failed."
evidence_status: "code present; advisory from code review"
- finding: "Partial/layout draftEmpty only checks content_html (WR-04)"
category: other
reason: "35-REVIEW.md WR-04 — text-only drafts show empty preview state; server can still render text."
evidence_status: "code present; advisory from code review"
human_verification:
- test: "Open Settings → Mail → Mail templates in a running admin SPA with a plugin that registers HasMailTemplates (e.g. user plugin templates)."
expected: "All registered templates appear; customize subject/body/layout; save; Reset to file version restores file content; drift callout appears after file change."
why_human: "List/form UX, Winter-shaped flow and empty-state copy need visual confirmation beyond unit/API tests."
- test: "Edit a layout in codeeditor (HTML/text/CSS tabs); insert an image from the library; save Branding colours and logo; preview HTML/plain text; Send test to me."
expected: "CodeMirror highlighting/focus feels correct; inserted URL is absolute server URL; preview iframe is sandboxed server HTML; test mail arrives only at the signed-in admin address (Mailpit)."
why_human: "35-VALIDATION.md manual-only rows (D-09 feel, D-17 inbox rendering); visual appearance and real mail-client rendering cannot be proven by grep."
reason: "35-REVIEW.md WR-04; does not affect names that have files, so working mail is unaffected"
evidence_status: "reported by code review probe"
- finding: "WR-05: scheme check runs before entity decoding; with disable_auto_inline_css on, an admin-written layout with href=\"javascript&#58;...\" passes; with inlining on, a post-inline failure stops the message, contradicting docs"
category: security
reason: "35-REVIEW.md WR-05; requires an administrator with system.manage_mail_layouts to write the payload"
evidence_status: "reported by code review probe"
human_verified:
- test: "Customize and save a template"
uat_row: 2
recorded_at: "2026-11-13T21:09:53.000Z"
- test: "Reset to file version"
uat_row: 3
recorded_at: "2026-11-13T21:09:53.000Z"
- test: "Drift notice"
uat_row: 4
recorded_at: "2026-11-13T21:09:53.000Z"
- test: "Layout editor"
uat_row: 5
recorded_at: "2026-11-13T21:09:53.000Z"
- test: "Insert image into layout"
uat_row: 6
recorded_at: "2026-11-13T21:09:53.000Z"
- test: "Branding"
uat_row: 7
recorded_at: "2026-11-13T21:09:53.000Z"
- test: "Send test to me"
uat_row: 9
recorded_at: "2026-11-13T21:09:53.000Z"
- test: "Confirm judgment-tier prohibition: postcard imports modules/lagoon/attach for AbsolutePublicURL."
expected: "Accept as intentional (D-24 / 35-01 SUMMARY threat_flag dependency-surface) or request a follow-up to move AbsolutePublicURL out of lagoon."
why_human: "PLAN prohibition said postcard must not import lagoon; implementation imports attach by design. Judgment-tier — needs explicit human resolution."
uat_row: 10
recorded_at: "2026-11-13T21:09:53.000Z"
human_verification: # pending human items, kept although status is gaps_found so they are not lost; run after the CR-01 gap closure
- test: "Template list"
expected: "On sm-demo-app rebuilt on this framework commit: Mail templates shows one row per template with a Customized locales column; opening a template shows the Language switcher under the title; switching to a locale without a file, saving it and switching back works behind the unsaved-changes confirm. Re-run UAT test 1 in full."
why_human: "Placement and readability of the switcher and the Customized locales column in the embedded admin (35-VALIDATION Manual-Only, G-35-1)"
- test: "Preview"
expected: "Scoped re-run: first reset the UAT overrides of golem15.user::mail.activate and golem15.user::mail.layouts.user; save Branding with a logo and a Site name; preview a template switched to the default layout and then the system layout, with a body override calling {{ partial \"button\" \"url\" \"https://example.com\" \"body\" \"Go\" }}. Expect the logo header (or the name without a logo), the white card, the styled button and the footer (© year and name)."
why_human: "Visual rendering of the built-in layouts in the admin preview (35-VALIDATION Manual-Only, G-35-8 framework part)"
- test: "Inlined mail in a real inbox"
expected: "Test-send a template in the default layout to a real webmail/Outlook inbox; the button and card keep their colours with the style block stripped"
why_human: "Mail clients differ in what they keep of a style block; cannot be asserted by unit tests"
- test: "Confirm judgment-tier prohibitions of 35-05..35-07"
expected: "Accept: no sibling repository changed (sm-user-plugin and sm-paymentgateway-plugin trees clean before and after the verifier's consumers run); nothing pushed or tagged (master is 75 commits ahead of origin, newest tag v0.6.4 predates the gap closure); 35-07 changed only tests, the gate script and planning docs"
why_human: "Judgment-tier prohibitions need explicit human resolution; the verifier's LLM judgment is non-authoritative"
---
# Phase 35: Mail templates and layouts editor Verification Report
**Phase Goal:** Administrators edit every mail the application sends from the admin panel, as in WinterCMS's Mail templates screen. System mail and the templates plugins register through `pact.HasMailTemplates` appear in a list. Each template can get a database override of its subject and body, and the override can be reset to the file version. Layouts become admin-editable records assigned to templates, with a few predefined layouts seeded. Images can be uploaded and placed in layouts and templates. postcard renders the override when one exists, otherwise the plugin's file, so mail that already works keeps working.
**Verified:** 2026-11-13T13:43:11Z
**Status:** human_needed
**Re-verification:** No — initial verification
**Verified:** 2026-11-13T21:30:50Z
**Status:** gaps_found
**Re-verification:** Yes. This report regenerates the stale 2026-11-13T13:43Z report after gap-closure plans 35-05 (G-35-1), 35-06 (G-35-8) and 35-07 (tests and gate). The previous report had no `gaps:` block, so every must-have was re-derived and re-checked.
## Goal Achievement
Roadmap lists **Requirements: TBD** and no Success Criteria block for Phase 35. Must-haves are derived from the ROADMAP goal (Option C) and merged with PLAN frontmatter truths (D-01..D-25). `check.decision-coverage-verify`: **25/25** CONTEXT decisions honored.
ROADMAP has no Success Criteria block and `Requirements: TBD` for Phase 35. Must-haves are derived from the goal's clauses (Option C) and merged with the PLAN frontmatter truths of 35-01..35-07. Rows 1-10 and 14 group the 35-01..04 truths that the previous report verified; the verifier re-checked them for regressions. Rows 2, 3, 6-8, 11 and 12 carry the gap-closure truths.
### Observable Truths
| # | Truth | Status | Evidence |
| --- | --- | --- | --- |
| 1 | Administrators edit mail from Settings → Mail screens (templates, layouts, partials, branding, images) with no top-level nav | ✓ VERIFIED | `modules/cabana/mail_admin.go` + `backend_screens.go` register five Settings entries and controllers; smoke `TestMailScreensSmoke`; SPA generic FormView/ListView/SettingsFormView |
| 2 | Templates from `pact.HasMailTemplates` (and file catalog) appear as list rows after SyncIndex | ✓ VERIFIED | `postcard.SyncIndex` in `store.go`; cabana `http.go` → `mail.syncOnDatabase` → `postcard.SyncIndex`; list YAML under `backendscreens/controllers/mailtemplates/` |
| 3 | Template DB override of subject, Markdown body and layout; Reset clears override and re-mirrors file | ✓ VERIFIED | `mailer.go` per-send `NewDBSource`; `ResetOverride` in `store.go`; `go test -short ./modules/postcard -run 'TestOverride'` PASS; cabana `TestMailReset` exists |
| 4 | Layouts are admin-editable (file override + custom create/delete); predefined `default`, `system`, `minimal` seeded as files | ✓ VERIFIED | assets `default.htm`/`system.htm`/`minimal.htm`; layout form + `TestMailLayoutDelete`; template `fields.yaml` layout dropdown |
| 5 | Images uploadable via mail library and insertable into templates/layouts/partials | ✓ VERIFIED | `GET/POST /mail/images` in `mail_routes.go`; `MailImagePicker.vue` + `insertImage.ts`; SPA tests `insertImage`/`MailImagePicker` PASS |
| 6 | postcard renders override when present, else file; fallback on failure; no boot-time snapshot | ✓ VERIFIED | `mailer.render` / `overrides()` once per send; `TestOverride`+`TestFallback` PASS; Activate installs `NewDBSource(app)` |
| 7 | Partials via additive `pact.HasMailPartials`; built-ins button/panel/table/subcopy; Markdown-safe `partial` | ✓ VERIFIED | `capabilities.go` HasMailPartials; `partials.go`; `TestPartial` PASS |
| 8 | Branding colours + logo replace `mail.brandCss` once row exists; logoUrl absolute at send time | ✓ VERIFIED | `brand.go` CompileBrandCSS; `store.go` calls `attach.AbsolutePublicURL`; `TestBrand` PASS |
| 9 | Live draft preview (sandboxed iframe) and test-send to signed-in admin only, rate-limited | ✓ VERIFIED | `MailPreviewField.vue` `sandbox=""`; `mailTestSend` refuses recipient; SPA MailPreviewField tests PASS (sequence guard); `TestMailTestSend` exists |
| 10 | Permission split `system.manage_mail_templates` / `system.manage_mail_layouts`; no default role grants | ✓ VERIFIED | `backend_screens.go` constants; `TestMailPermissions` listed; smoke asserts zero default grants |
| 11 | Drift: customized + outdated when `base_hash` ≠ `file_hash`; File version diff; re-save clears | ✓ VERIFIED | SyncIndex hash columns; cabana row states; `TestMailDrift` exists; `mail_diff.go` |
| 12 | D-21 gate: `scripts/check-phase35.sh` + unit/SPA coverage map filled | ✓ VERIFIED | `--self-test` PASS; `35-VALIDATION.md` nyquist_compliant + Wave 0 checked; artifact tests present |
| 1 | Administrators edit mail from Settings → Mail (templates, layouts, partials, branding, images) | ✓ VERIFIED | `mail_admin.go`/`backend_screens.go` unchanged in shape. UAT rows 2, 5, 7 and 9 passed. The cabana Postgres tests pass (below). |
| 2 | Templates registered through `pact.HasMailTemplates` appear in the list, **one row per template** however many locales (G-35-1, supersedes D-05) | ✓ VERIFIED | `ListExtendQuery` keeps one representative row per `base_code`; `columns.yaml` has `customized_locales`; the locale filter is gone. `TestMailLocaleGroups/one_row_per_template` PASS (run by the verifier). The visual re-run of UAT test 1 is still owed (human item). |
| 3 | The template form has a locale switcher. A locale without a file shows the default version and can be customized, reset and drift-tracked per locale. | ✓ VERIFIED | `LocaleVariantSwitcher.vue` (`data-locale-variant`) is rendered by `FormView.vue:714` from `meta.localeVariants` when there are 2 or more variants. `postcard.EnsureLocaleRows` is called from sync (`mail_admin.go:220`) and from the show hook (`:1971`). `TestMailLocaleGroups/{variants,fallback_shows_default_version,save_then_send,reset,drift_through_the_base_file,ids_outside_the_group,permissions_on_fallback_rows,locale_enabled_at_run_time}` PASS. The SPA switcher and FormViewMail tests pass (14/14). |
| 4 | Each template can get a DB override of its subject and body; Reset restores the file version | ✓ VERIFIED | `TestOverride` and `TestFallback` PASS. `ResetOverride` accepts fallback codes (`TestEnsureLocaleRows` PASS). UAT rows 2 and 3 passed. |
| 5 | Layouts are admin-editable records assigned to templates; predefined layouts default, system and minimal are seeded | ✓ VERIFIED | assets `default.htm`/`system.htm`/`minimal.htm`; layout form; UAT row 5 passed. `SyncIndex` mirrors the file layouts. |
| 6 | Built-in layouts look finished: default and system have a logo-or-name header, the white card and the © footer; minimal shows the logo; the button partial is styled in all three (G-35-8 framework part) | ✓ VERIFIED | `default.htm` (`layout-default`, `partial "header"`, `inner-body`, footer). `system.htm` calls header and footer; the `.layout-system .content-cell` override is gone. `minimal.htm:12` prints the logo img. `TestBuiltinLayoutsLogo`, `TestHeaderFooterPartials` and `TestButtonPartial` PASS. The scoped visual re-run of UAT test 8 is still owed. |
| 7 | Branding has a Site name; when it is empty, the display name of mail.from is used | ✓ VERIFIED | `Brand.SiteName`, migration `202611130002_mail_brand_site_name`, `siteName()` in `mailer.go:176`, and the `site_name` field in `mailbrandsetting/fields.yaml`. `TestSiteName` and `TestMailBrandSiteName/{saved_trimmed,max_length,preview,send}` PASS. |
| 8 | CSS is inlined at render with a per-layout opt-out (file key, column, switch); an inliner failure never stops mail | ✓ VERIFIED | `inline.go` (go-premailer, panic recovery). `templates.go:705` `inlineHTML` runs unless `disableInline` is set. Migration `202611130003`. `TestInlineCSS`, `TestInlineCSSOptOut`, `TestInlineFailure` and `TestMailLayoutInlineOptOut/*` PASS. |
| 9 | Images can be uploaded and placed in layouts and templates | ✓ VERIFIED | `GET/POST /mail/images`, `MailImagePicker.vue`, `insertImage.ts` (35-02/03, unchanged by the gap closure). UAT row 6 passed. |
| 10 | postcard renders the override when one exists, otherwise the file; `<template>-<locale>` without a file resolves to own customization, then base customization, then base file | ✓ VERIFIED | `mailer.render` → `resolveTemplate` → `overrides(msg.Template)`, then the base. `TestSendLocaleFallback` and `TestTemplateFor` PASS. Names that have files are unchanged: the consumers stage passes. |
| 11 | **Mail that already works keeps working**: no configuration that sends today, and no admin-saved Branding value, stops mail on the built-in layouts | ✗ FAILED | **CR-01, reproduced.** A site name containing `data:`/`javascript:`/`vbscript:` (for example mail.from `"Metadata: Weekly" <x@example.com>`, with no admin action, or Branding `Big Data: Summit`) makes `Send` fail on the default and system layouts, file version included. At v0.6.3 the same config sent fine. See Gaps. |
| 12 | `check-phase35.sh` runs the consumers read-only through scratch `-modfile`, refuses dirty siblings, requires every new test by name; `--all` passes | ✓ VERIFIED | The verifier ran `--consumers` (user 2/2, paymentgateway 3/3 tests, both trees clean before and after), `--additive` (8 packages vs v0.6.3) and `--self-test`: all pass. `--all` PASS is reported by 35-07 and the orchestrator; the verifier did not re-run it. |
| 13 | D-05 and D-10's inlining claim are superseded on record; the UI-SPEC carries C16 and the inlining/site-name copy; go-premailer is recorded before go.mod changed | ✓ VERIFIED | `.planning/notes/2026-11-13-mail-template-locale-groups.md` and `...-mail-layouts-css-inlining.md` exist. STACK.md row. The note commit `dcd0ae53` is an ancestor of the go.mod commit `d3207335`. `go.mod:43` pins v1.38.0. |
| 14 | Permission split, test send to the signed-in admin only, sandboxed server-rendered preview (35-02/03) | ✓ VERIFIED | No regression: `TestMailLocaleGroups/permissions_on_fallback_rows` PASS, UAT row 9 passed, `mailTemplateDraft` only widened to codes `TemplateFor` resolves. |
**Score:** 12/12 truths verified (0 present, behavior-unverified)
**Score:** 13/14 truths verified (0 present but behavior-unverified)
Granular PLAN truths (35-01..04) map onto the rows above; spot-checks did not find a PLAN truth that fails while the parent row holds. Advisory WR-01..04 do not falsify these truths.
### Deferred Items
| # | Item | Addressed In | Evidence |
|---|------|-------------|----------|
| 1 | G-35-8 plugin part: sm-user-plugin and sm-paymentgateway-plugin CTAs through the button partial, finished `user`/`paymentgateway` layouts, framework bump with `go mod tidy` | Plugin follow-up after the framework tag (user decision 2026-11-13; no roadmap phase) | 35-06-PLAN "Follow-ups", 35-VALIDATION "Deferred follow-up check", 35-UAT G-35-8 `closure_note`. The phase goal names "a few predefined layouts seeded", which are the framework's built-in layouts; plugin layouts live in sibling repos this phase must not change. This is informational, not counted as a gap. |
### Advisory (New Scope, Unevidenced)
| # | Finding | Category | Why Advisory |
|---|---------|----------|--------------|
| 1 | WR-01 site name parsed as Markdown in the footer | other | admin-controlled and cosmetic; bundle with the CR-01 fix |
| 2 | WR-02 advisory lock and upserts inside show/save transactions (deadlock risk, writes on GET) | architectural | self-heals; no reproducing test |
| 3 | WR-03 swallowed TranslationWriter error aborts the request transaction | other | conditional on a failing optional plugin |
| 4 | WR-04 two-letter fallback rule (typos resolve, 3-letter locales skipped) | other | names that have files are unaffected |
| 5 | WR-05 scheme check before entity decoding; opt-out path bypass | security | needs a layouts-permission admin to author the payload |
### Required Artifacts
All PLAN `must_haves.artifacts` passed `verify.artifacts` (01: 8/8, 02: 6/6, 03: 6/6, 04: 5/5).
| Artifact | Expected | Status | Details |
| -------- | -------- | ------ | ------- |
| `modules/postcard/store.go` | NewDBSource, SyncIndex, ResetOverride | ✓ VERIFIED | exists, substantive, wired from Activate/mailer |
| `modules/postcard/editor.go` | Editor Validate/Preview/SendDraft | ✓ VERIFIED | used by cabana FormAfterUpdate + mail routes |
| `modules/cabana/mail_admin.go` | screens, permissions, reset | ✓ VERIFIED | wired via backend_screens EditorFrom |
| `modules/cabana/mail_routes.go` | preview, test-send, images | ✓ VERIFIED | OpenAPI + SPA calls |
| `admin/.../MailPreviewField.vue` | sandboxed preview | ✓ VERIFIED | `sandbox=""`, POST /mail/preview |
| `admin/.../CodeEditorField.vue` | lazy CodeMirror | ✓ VERIFIED | dynamic import of editor.ts |
| `scripts/check-phase35.sh` | phase gate | ✓ VERIFIED | self-test PASS |
| -------- | ----------- | ------ | ------- |
| `modules/postcard/store.go` | base_code migration, `EnsureLocaleRows`, site_name and inline-opt-out migrations | ✓ VERIFIED | migrations `202611130001..003` present; wired from cabana sync and the show hook |
| `modules/postcard/templates.go` | `TemplateBase`, `Catalog.TemplateFor`, `resolveTemplate`, `inlineHTML` | ✓ VERIFIED | used by `mailer.render` and `editor.renderTemplate` |
| `modules/postcard/inline.go` | go-premailer wrapper | ✓ VERIFIED | `inlineCSS` with panic recovery |
| `modules/postcard/assets/default.htm`, `system.htm`, `minimal.htm`, `partials/header.htm`, `partials/footer.htm` | finished built-in layouts | ✓ VERIFIED | substantive; exercised by `TestBuiltinLayoutsLogo` (CR-01 lives in what they print, see Gaps) |
| `modules/cabana/relation_field.go` | `RecordMeta.LocaleVariants` | ✓ VERIFIED | `localeVariants,omitempty`; in `admin.json` and `schema.d.ts` |
| `admin/src/components/form/LocaleVariantSwitcher.vue` | switcher | ✓ VERIFIED | `data-locale-variant`; rendered by FormView |
| `scripts/check-phase35.sh` | scratch-modfile consumers stage | ✓ VERIFIED | 21 `modfile` lines; requires `TestMailLocaleGroups`, `LocaleVariantSwitcher.test.ts` and the others |
| `modules/postcard/{locale,layouts,inline}_test.go`, `locale_postgres_test.go`, `modules/cabana/mail_{locale,brand_layout}_postgres_test.go` | gap-closure tests | ✓ VERIFIED | all named tests pass (run by the verifier) |
| `.planning/notes/2026-11-13-mail-template-locale-groups.md`, `...-mail-layouts-css-inlining.md` | decision notes | ✓ VERIFIED | present |
| `modules/boardwalk/dist` | rebuilt admin | ✓ VERIFIED | `check-admin-dist.sh`: matches a fresh build |
### Key Link Verification
| From | To | Via | Status | Details |
| ---- | --- | --- | ------ | ------- |
| `mailer.go` | `store.go` | `NewDBSource(app)` | ✓ WIRED | pattern found |
| `lagoon/migrations.go` | `store.go` | `postcard.Migrations` | ✓ WIRED | pattern found |
| `brand.go` → AbsolutePublicURL | `attach/absolute.go` | logo at send | ✓ WIRED (alt path) | mechanical pattern in brand.go MISSING; call is in `store.go:330` (`attach.AbsolutePublicURL`) per 35-01 SUMMARY plan inconsistency note — same intent |
| `mailer.go` | `pact` | `HasMailPartials` | ✓ WIRED | pattern found |
| `mail_admin.go` | `editor.go` | `.Validate(ctx` | ✓ WIRED | pattern found |
| `http.go` → SyncIndex | `store.go` | serve-start sync | ✓ WIRED (alt path) | mechanical `postcard.SyncIndex` not in http.go; `http.go` → `mail.syncOnDatabase` → `mail_admin.sync` → `postcard.SyncIndex` |
| `mail_routes.go` | cooler | Attempter | ✓ WIRED | pattern found |
| `backend_screens.go` | mail_admin | EditorFrom | ✓ WIRED | pattern found |
| SPA preview/picker/registry | cabana routes | api.POST | ✓ WIRED | plan 03 4/4 |
| check-phase35 consumers/additive | plugins / apisurface | stages | ✓ WIRED | plan 04 2/2 |
| `postcard/mailer.go` | `postcard/templates.go` | `resolveTemplate` for fallback-locale names | ✓ WIRED | `mailer.go:111`; `editor.go:214` |
| `cabana/mail_admin.go` | `postcard/store.go` | `postcard.EnsureLocaleRows` at sync and show | ✓ WIRED | lines 220 and 1971 |
| `admin/src/views/FormView.vue` | `LocaleVariantSwitcher.vue` | `meta.localeVariants` | ✓ WIRED | lines 272-273, 714-717 |
| `postcard/templates.go` | `postcard/inline.go` | `inlineHTML` → `inlineCSS` unless opted out | ✓ WIRED | lines 705, 731-737 |
| `postcard/mailer.go` | `assets/default.htm` | `siteName`/`year` layout keys | ✓ WIRED | `options()` sets both; also the source of CR-01 |
| `postcard/store.go` | `mailbrandsetting/fields.yaml` | `site_name` column | ✓ WIRED | store read at `:356`; form field |
| `scripts/check-phase35.sh` | `../sm-user-plugin`, `../sm-paymentgateway-plugin` | scratch `-modfile` | ✓ WIRED | verifier run: workspace resolves to this checkout, trees clean |
| 35-01..04 links (NewDBSource, postcard.Migrations, HasMailPartials, Editor.Validate, cooler.Attempter, EditorFrom, /mail/preview, /mail/images) | | | ✓ WIRED | unchanged since the previous report; the regression tests pass |
### Data-Flow Trace (Level 4)
| Artifact | Data Variable | Source | Produces Real Data | Status |
| -------- | ------------- | ------ | ------------------ | ------ |
| Template list | rows | `system_mail_templates` via SyncIndex + GORM list | Yes | ✓ FLOWING |
| Override at send | Overrides | `NewDBSource` SQL per send | Yes | ✓ FLOWING |
| Preview iframe srcdoc | html | POST /mail/preview → postcard.Editor | Yes (server HTML only) | ✓ FLOWING |
| Image insert URL | absolute URL | GET/POST /mail/images meta | Yes | ✓ FLOWING |
| Brand logoUrl | LogoURL | system_files + AbsolutePublicURL | Yes | ✓ FLOWING |
| Templates list | representative rows + `customized_locales` | `system_mail_templates` grouped by `base_code` | Yes | ✓ FLOWING |
| Locale switcher | `meta.localeVariants` | cabana show/save from group rows | Yes | ✓ FLOWING |
| Fallback-locale send | template override | `MailOverrides(code)` then the base | Yes | ✓ FLOWING |
| Layout header/footer | `siteName`, `logoUrl`, `year` | Branding row / mail.from / clock | Yes | ✓ FLOWING (unsafe names break the render: CR-01) |
| Inlined HTML | style attributes | go-premailer over the rendered doc | Yes | ✓ FLOWING |
### Behavioral Spot-Checks
| Behavior | Command | Result | Status |
| -------- | ------- | ------ | ------ |
| Override/fallback/partial/brand/sample/validate | `go test -short ./modules/postcard -run 'TestOverride\|TestFallback\|TestPartial\|TestBrand\|TestSample\|TestValidateDraft'` | ok | ✓ PASS |
| HasMailTemplates / row states pin | `go test -short ./modules/pact -run 'TestHasMailTemplates\|TestRowState'` | ok | ✓ PASS |
| SPA preview/codeeditor/insertImage | `npm --prefix admin run test -- --run MailPreviewField insertImage CodeEditorField` | 16 passed | ✓ PASS |
| Phase gate self-test | `bash scripts/check-phase35.sh --self-test` | phase35 self-test passed | ✓ PASS |
| Cabana mail locale/unit (short) | `go test -short ./modules/cabana -run 'TestMailLocale\|TestMailUnit\|TestFieldMail'` | ok | ✓ PASS |
| Full docker mail postgres suite | (not run — Docker/stateful) | — | ? SKIP (tests exist: TestMailPermissions, TestMailTestSend, TestMailDrift, …) |
| postcard gap-closure and regression unit tests | `go test -short ./modules/postcard -run '^(TestTemplateBase\|TestTemplateFor\|TestSendLocaleFallback\|TestBuiltinLayoutsLogo\|TestHeaderFooterPartials\|TestButtonPartial\|TestSiteName\|TestInlineCSS\|TestInlineCSSOptOut\|TestInlineFailure\|TestOverride\|TestFallback\|TestPartial\|TestBrand\|TestSample\|TestValidateDraft)$'` | 16 PASS | ✓ PASS |
| pact pin | `go test -short ./modules/pact -run 'TestHasMailTemplates\|TestRowState'` | ok | ✓ PASS |
| Fallback rows (Postgres) | `go test ./modules/postcard -run '^TestEnsureLocaleRows$'` | PASS | ✓ PASS |
| Admin side of both gaps (Postgres) | `go test ./modules/cabana -run '^(TestMailLocaleGroups\|TestMailBrandSiteName\|TestMailLayoutInlineOptOut)$'` | 3 PASS, 17 subtests | ✓ PASS |
| SPA switcher | `npm --prefix admin run test -- tests/form/LocaleVariantSwitcher.test.ts tests/form/FormViewMail.test.ts` | 14 passed | ✓ PASS |
| Embedded admin | `scripts/check-admin-dist.sh` | matches a fresh build | ✓ PASS |
| Core plugins unchanged | `scripts/check-phase35.sh --consumers` | passed, both sibling trees clean | ✓ PASS |
| API additive | `scripts/check-phase35.sh --additive` | 8 packages vs v0.6.3 | ✓ PASS |
| Gate self-test | `scripts/check-phase35.sh --self-test` | passed | ✓ PASS |
| CR-01 probe | overlay test (scratchpad, no source change): Send with mail.from `"Metadata: Weekly" <x@example.com>` / Branding `Big Data: Summit` | default and system layouts: `rendered HTML contains a dangerous URL scheme`; minimal and plain names OK | ✗ FAIL (gap) |
### Probe Execution
No phase-declared `scripts/*/tests/probe-*.sh`. N/A.
No `scripts/*/tests/probe-*.sh` is declared or present for this phase. N/A. The phase gate stages above were run directly.
### Requirements Coverage
REQUIREMENTS.md has **no Phase 35 IDs** (ROADMAP `Requirements: TBD`). Plans declare CONTEXT **D-*** IDs.
REQUIREMENTS.md maps no IDs to Phase 35 (ROADMAP `Requirements: TBD`; the related I18N-03 and KERN-03 are already complete from earlier phases). Plans declare CONTEXT decision IDs and UAT gap IDs:
| Requirement | Source Plan | Description | Status | Evidence |
| ----------- | ---------- | ----------- | ------ | -------- |
| D-01..D-25 | 35-01..04 + CONTEXT | Full decision set | ✓ SATISFIED | `check.decision-coverage-verify` 25/25 honored |
| (v1 REQ IDs) | — | none mapped to phase 35 | N/A | no orphaned Phase 35 rows in REQUIREMENTS.md |
| D-01..D-25 | 35-01..04 | CONTEXT decision set | ✓ SATISFIED | previous report (25/25); regression tests green; D-05 superseded by note (35-05); D-10 inlining claim superseded (35-06) |
| G-35-1 | 35-05, 35-07 | one record per template, locale switcher | ✓ SATISFIED (automated); visual re-run owed | Truths 2-3 |
| G-35-8 | 35-06, 35-07 | finished built-in layouts, site name, inlining | ✓ SATISFIED for the framework part; plugin part deferred; visual re-run owed | Truths 6-8. CR-01 is a regression introduced by this work and tracked as its own gap |
| D-06, D-07, D-13, D-16 | 35-05 | reset/drift per locale, Editor path | ✓ SATISFIED | TestMailLocaleGroups reset/drift/save_then_send |
| D-10, D-11, D-12, D-14 | 35-06 | Branding, precedence, partials, fallback | ✗ BLOCKED in part | D-14 spirit ("a failing override never stops mail") is broken by CR-01: the file-version fallback fails too |
| D-21 | 35-07 | unit tests last, gate | ✓ SATISFIED | gate stages pass |
| Orphaned | — | — | none | no REQUIREMENTS.md row names Phase 35 |
### Anti-Patterns Found
| File | Line | Pattern | Severity | Impact |
| ---- | ---- | ------- | -------- | ------ |
| — | — | TBD/FIXME/XXX in key phase files | none found | — |
| `modules/postcard/store.go` | import | imports `lagoon/attach` | ℹ️ Info / judgment prohibition | Intentional for AbsolutePublicURL (D-24); conflicts with written prohibition text |
| 35-REVIEW WR-01..04 | — | filter/UX gaps | 📋 Advisory | Do not fail must-haves; recorded in advisory frontmatter |
| 52 files changed in the gap closure | — | TBD/FIXME/XXX | none found | — |
| `modules/postcard/templates.go` | 45, 820 | unanchored `dangerousScheme` over the whole document, now fed configuration text | 🛑 Blocker | CR-01: the regex was there before this phase, but 35-06 made it reachable from config alone |
| `modules/cabana/mail_admin.go` | ~1784-1806 | `site_name` with no safety check at save | 🛑 Blocker (same root cause) | stores a value that breaks sends and saves |
| `modules/postcard/assets/partials/footer.htm` | 11 | `{{ markdown .body }}` on the site name | ⚠️ Warning | WR-01 |
| `modules/cabana/crud.go` / `mail_admin.go` | ~562, ~1000, 1960-1977 | advisory lock inside request tx | ⚠️ Warning | WR-02 |
| `modules/cabana/mail_admin.go` | 173-201 | error swallowed inside a Postgres tx | ⚠️ Warning | WR-03 |
| `modules/cabana/mail_admin.go` | 518-525 | dead `scopeTemplates` | ℹ️ Info | IN-01 |
| `modules/postcard/store.go` | — | imports `lagoon/attach` | ℹ️ Info | accepted by the human in UAT row 10 |
### Prohibitions (judgment-tier)
### Prohibitions
| Statement | LLM judgment | Flag |
| --------- | ------------- | ---- |
| HasMailTemplates / Mailer signatures additive only | Holds — HasMailPartials additive; interface methods unchanged | unverified-prohibition — human review recommended |
| Byte-identical file mail without override | Holds — TestOverride/file path + consumer stage in gate | unverified-prohibition — human review recommended |
| goldmark not unsafe | Holds — `goldmark.New()` / Table only; no WithUnsafe | unverified-prohibition — human review recommended |
| postcard does not import cabana or lagoon | **Partial:** no cabana; **does** import `lagoon/attach` | unverified-prohibition — human resolution required (see Human Verification #3) |
| No free-text recipient on mail screens | Holds — test-send posts no recipient; server refuses recipient key | unverified-prohibition — human review recommended |
| No default role grants for mail permissions | Holds — smoke/permission tests assert zero grants | unverified-prohibition — human review recommended |
| Statement (plan) | Tier | Verdict | Flag |
| --------- | ---- | ------- | ---- |
| pact/postcard/cabana API changes additive only (35-05, 35-06) | automated | Holds: `--additive` passes against v0.6.3 | none |
| go-premailer exactly v1.38.0, note and STACK row before go.mod (35-06) | automated | Holds: `go.mod:43`; `dcd0ae53` is an ancestor of `d3207335` | none |
| Tests and gate never write a sibling repository (35-07) | automated | Holds: both trees clean before and after the verifier's consumers run | none |
| No sibling repository file changed (35-05, 35-06) | judgment | Holds (LLM, non-authoritative) | unverified-prohibition, human review recommended (Human item 4) |
| Nothing pushed or tagged (35-05..07) | judgment | Holds: 75 ahead of origin, newest tag v0.6.4 predates the gap closure | unverified-prohibition, human review recommended (Human item 4) |
| 35-07 changes no production code | judgment | Holds: `git diff 0e97113a..a3ce0974` outside .planning touches only tests and `check-phase35.sh` | unverified-prohibition, human review recommended (Human item 4) |
| postcard does not import lagoon (35-01) | judgment | Deviates (imports `lagoon/attach`) | resolved: accepted by the human in UAT row 10 |
### Human Verification Required
### 1. Winter-shaped Settings → Mail flow
Recorded UAT passes for rows 2-7, 9 and 10 stand as evidence (`human_verified`). `verification.uat-evidence` reports no covered file changed after the UAT file's last record time. The re-run of test 1 below exercises the save/reset/drift flow again on the grouped record. These items are pending and should run after the CR-01 gap closure:
**Test:** Open Settings → Mail → Mail templates in a running admin SPA with a plugin that registers HasMailTemplates.
**Expected:** Templates listed; override save/reset/drift behave as Winter-like; empty-state copy correct.
**Why human:** Visual list/form UX beyond API tests.
### 1. Template list (UAT test 1 re-run)
**Test:** On sm-demo-app rebuilt on this framework commit, open Mail templates, open a template, switch to a locale without a file, save it, switch back.
**Expected:** One row per template with Customized locales; the Language switcher under the title; the unsaved-changes confirm when switching.
**Why human:** Placement and readability in the embedded admin.
### 2. Codeeditor, branding, preview, real test-send
### 2. Preview (UAT test 8 re-run, scoped to built-in layouts)
**Test:** Reset the UAT overrides of `golem15.user::mail.activate` and `golem15.user::mail.layouts.user`. Save Branding with a logo and Site name, then preview a template on the default and on the system layout with a body override calling the button partial.
**Expected:** Logo header (or name), white card, styled button, © year + name footer.
**Why human:** Visual rendering.
**Test:** Edit layout in codeeditor; insert image; save Branding; preview; Send test to me; check Mailpit.
**Expected:** Editor feel OK; absolute URLs; sandboxed preview; mail only to admin.
**Why human:** 35-VALIDATION.md manual-only (D-09, D-17).
### 3. Inlined mail in a real inbox
**Test:** Test-send a template in the default layout to a real webmail or Outlook inbox.
**Expected:** The button and card keep their colours after the client strips the style block.
**Why human:** Mail clients behave differently.
### 3. Accept postcard → lagoon/attach import
**Test:** Review prohibition vs D-24 AbsolutePublicURL placement.
**Expected:** Accept deviation or schedule follow-up extraction.
**Why human:** Judgment-tier prohibition conflict with intentional implementation.
### 4. Judgment-tier prohibitions of 35-05..07
**Test:** Confirm that no sibling repository changed, that nothing was pushed or tagged, and that 35-07 changed tests only.
**Expected:** Accept. The verifier found no evidence against any of them.
**Why human:** Judgment-tier items need explicit human resolution.
### Gaps Summary
No must-have truths FAILED. Automated goal-backward evidence is green (12/12). Status is `human_needed` because Step 8 human items (visual UAT + judgment prohibition resolution) are non-empty — not because of implementation gaps. Advisory code-review warnings (WR-01..04) noted; they do not alone fail verification.
One goal-blocking gap. The goal says postcard renders the override or the file "so mail that already works keeps working". The gap closure (35-06) made the built-in default and system layouts print a site name taken from Branding or, with no admin action, from the display name of `mail.from`. postcard's whole-document safety regex treats any `data:`, `javascript:` or `vbscript:` substring as a URL scheme. A sender name such as "Metadata: Weekly" or a Branding name such as "Big Data: Summit" therefore turns every send on those two layouts into an error. Password resets and other system mail on the default layout stop. The file-version fallback does not save the message, because it carries the same site name. The verifier reproduced this with an overlay probe that changed no source; the same configuration sends at v0.6.3. The Branding form accepts such a name, and every template or layout save on those layouts is then refused.
The trigger is narrow, but it comes from configuration alone and the failure is total, so this is FAILED rather than a warning. No later roadmap phase covers it. The fix is small and self-contained, enough for one gap-closure plan:
- never let a site name fail a render (drop it, log a rate-limited warning);
- refuse an unsafe name on the Branding field at save time;
- add send-path regression tests for both sources.
Optionally, the same plan can anchor `dangerousScheme` to URL-bearing attributes and fix WR-01's Markdown footer, which builds the same copyright line.
Everything else in the goal is verified with fresh evidence:
- G-35-1 (one record per template with a locale switcher, per-locale customize, reset and drift, send-time fallback);
- the framework part of G-35-8 (finished layouts, site name, button partial, CSS inlining with opt-out);
- the read-only consumers gate, with the core plugins' mail tests passing against this checkout.
The UAT re-runs of tests 1 and 8 and a real-inbox check remain human items. The plugin part of G-35-8 is deferred by user decision.
---
_Verified: 2026-11-13T13:43:11Z_
_Verifier: the agent (msd-verifier)_
_Verified: 2026-11-13T21:30:50Z_
_Verifier: Claude (msd-verifier)_