test(35): re-verify after quick 261115-cha - 23/23 truths, human_needed (inbox check)
This commit is contained in:
@@ -1,8 +1,8 @@
|
||||
---
|
||||
phase: 35-mail-templates-and-layouts-editor
|
||||
verified: 2026-11-14T17:43:56Z
|
||||
verified: 2026-11-16T07:16:15Z
|
||||
status: human_needed
|
||||
score: 22/22 must-haves verified
|
||||
score: 23/23 must-haves verified
|
||||
covered_files:
|
||||
- .planning/phases/35-mail-templates-and-layouts-editor/35-01-PLAN.md
|
||||
- .planning/phases/35-mail-templates-and-layouts-editor/35-01-SUMMARY.md
|
||||
@@ -24,6 +24,8 @@ covered_files:
|
||||
- .planning/phases/35-mail-templates-and-layouts-editor/35-09-SUMMARY.md
|
||||
- .planning/quick/261114-p5m-fix-cr-02-residual-quoted-end-tags-in-ra/261114-p5m-PLAN.md
|
||||
- .planning/quick/261114-p5m-fix-cr-02-residual-quoted-end-tags-in-ra/261114-p5m-SUMMARY.md
|
||||
- .planning/quick/261115-cha-let-a-mail-template-use-another-plugin-s/261115-cha-PLAN.md
|
||||
- .planning/quick/261115-cha-let-a-mail-template-use-another-plugin-s/261115-cha-SUMMARY.md
|
||||
- admin/openapi/admin.json
|
||||
- admin/package-lock.json
|
||||
- admin/package.json
|
||||
@@ -184,6 +186,7 @@ covered_files:
|
||||
- modules/postcard/editor_test.go
|
||||
- modules/postcard/inline.go
|
||||
- modules/postcard/inline_test.go
|
||||
- modules/postcard/layout_ref_test.go
|
||||
- modules/postcard/layouts_test.go
|
||||
- modules/postcard/locale_postgres_test.go
|
||||
- modules/postcard/locale_test.go
|
||||
@@ -207,175 +210,171 @@ covered_files:
|
||||
- modules/surf/serve.go
|
||||
- modules/surf/store_lookup_test.go
|
||||
- scripts/check-phase35.sh
|
||||
covered_digest: "v2:sha256:0946027fa67264b1d8b7f9fe4210f2674311daed071f1a2bd629ef1b91566579"
|
||||
covered_digest: "v2:sha256:b413e9cd2855f94de7e18bdd280605c598352dbcbe3c3d75eaa4160791f5a57d"
|
||||
behavior_unverified: 0
|
||||
overrides_applied: 0
|
||||
re_verification:
|
||||
previous_status: gaps_found
|
||||
previous_score: 21/22
|
||||
previous_status: human_needed
|
||||
previous_score: 22/22
|
||||
stale_reason: "covered_changed: quick 261115-cha (1fb42542, b8487b02) changed modules/postcard/templates.go, mailer.go (comment), README.md, docs/services/mail.md and added layout_ref_test.go"
|
||||
gaps_closed:
|
||||
- "CR-02 residual (truth 18): a raw-text end tag or '-->' inside a quoted attribute no longer hides the rest of the tag. unsafeMarkupAt now runs a second, quote-aware tag reading (unsafeTagReading: NextIsNotRawText after raw-text start tags, '<!--' blanked). Verifier's re-run probe: validateHTML refuses all 8 end-tag-in-attribute payloads; Editor.Validate refuses the noscript href, noscript handler and svg/style layouts; a default-layout override carrying them falls back to the file version with inlining on and off (logged 'override failed, sending the file version'). TestURLSchemeCheck *_end_in_attr subtests (refuse, send inline/opt_out, editor, escaped_send with a parser oracle) PASS"
|
||||
- "G-35-9 framework part: a template's layout key may name a layout another registered plugin owns by its full code (truth 23)"
|
||||
gaps_remaining: []
|
||||
regressions: []
|
||||
deferred:
|
||||
- truth: "The mfa plugin's two-factor code mail renders in the user plugin's layout (G-35-9 plugin part; UAT row 1 issue)"
|
||||
addressed_in: "sm-mfa-plugin follow-up after the next framework tag (separate repository; out of scope for this framework phase by the caller's instruction)"
|
||||
evidence: "35-UAT.md G-35-9 closure_note: 'Plugin part deferred to the follow-up after the framework tag: sm-mfa-plugin sets layout = \"golem15.user::mail.layouts.user\" in both two_factor_code templates.' The framework mechanism it needs is verified here (truth 23)"
|
||||
- truth: "G-35-8 plugin part: user and paymentgateway plugin CTAs through the button partial, framework bump"
|
||||
addressed_in: "Plugin follow-up after the framework tag (separate repositories)"
|
||||
evidence: "35-UAT.md G-35-8 closure_note; UAT row 8 passed on the re-test"
|
||||
advisory:
|
||||
- finding: "The quote-aware tag reading can over-refuse: an unbalanced quote inside a comment or raw-text element joins later text into one tag, and attribute-shaped text after it (e.g. 'online=yes') is refused"
|
||||
category: other
|
||||
reason: "Documented as residual risk in .planning/notes/2026-11-14-mail-url-scheme-check.md. A refused override falls back to the file version, but a plugin's own file layout that tripped it would not send. Built-in layouts and both consumer plugins' mail tests pass today (--consumers); worth re-running --consumers after the concurrent plugin layout restyle (quick 261114-p5n) lands"
|
||||
evidence_status: "decision note; no failing case found"
|
||||
- finding: "35-UAT.md gap records G-35-1 and G-35-8 are marked 'resolved' by 35-07 (5735e7c7), while test rows 1 and 8 still read 'result: issue' and no human re-test is recorded"
|
||||
category: other
|
||||
reason: "Record reconciliation, not human evidence; both re-tests stay in human_verification below"
|
||||
evidence_status: "file inspection"
|
||||
- finding: "WR-03 partial deviation: 'JavaScript: The Good Parts Club' is still refused as a site name (javascript: followed by whitespace)"
|
||||
category: other
|
||||
reason: "Deliberate, per the decision note; a product decision. A refused name is dropped, and mail still sends"
|
||||
reason: "Deliberate, per .planning/notes/2026-11-14-mail-url-scheme-check.md; a product decision. A refused name is dropped, and mail still sends"
|
||||
evidence_status: "35-REVIEW-FIX.md; code inspection"
|
||||
- finding: "35-UI-SPEC.md:427 and 35-08-PLAN.md:130 still quote the old Branding refusal copy with 'text such as onclick='"
|
||||
- finding: "35-UI-SPEC.md:427 still quotes the old Branding refusal copy with 'text such as onclick='"
|
||||
category: other
|
||||
reason: "Phrasebook en/pl changed in 31de2ff9; update UI-SPEC if it is a living copy contract"
|
||||
evidence_status: "not re-checked this round"
|
||||
- finding: "IN-01..IN-03 (35-REVIEW) and WR-04, WR-05, IN-04 (earlier review) remain open in the disposition record (open: 6)"
|
||||
reason: "Phrasebook en/pl changed in 31de2ff9 and UAT row 11 confirmed the new copy in the admin; update UI-SPEC if it is a living copy contract"
|
||||
evidence_status: "grep, 2026-11-16"
|
||||
- finding: "IN-01..IN-03 (35-REVIEW) and WR-04, WR-05, IN-04 (earlier review) remain open in 35-REVIEW-DISPOSITION.md"
|
||||
category: other
|
||||
reason: "Info-level or outside the fix round; none stops a send"
|
||||
evidence_status: "35-REVIEW-DISPOSITION.md"
|
||||
- finding: "A template naming the default layout by full code (postcard::mail.layouts.default) now resolves to the full name instead of the default alias"
|
||||
category: other
|
||||
reason: "Before 261115-cha that value failed at boot, so no shipped configuration changes. layoutByCode finds the full name and builtin_full_code covers the minimal case; the default case is untested"
|
||||
evidence_status: "code inspection of resolveLayoutLocked"
|
||||
human_verified:
|
||||
- test: "Customize and save a template"
|
||||
uat_row: 2
|
||||
recorded_at: "2026-11-15T08:11:21.000Z"
|
||||
- test: "Reset to file version"
|
||||
uat_row: 3
|
||||
recorded_at: "2026-11-13T21:09:53.000Z"
|
||||
recorded_at: "2026-11-15T08:11:21.000Z"
|
||||
- test: "Drift notice"
|
||||
uat_row: 4
|
||||
recorded_at: "2026-11-13T21:09:53.000Z"
|
||||
recorded_at: "2026-11-15T08:11:21.000Z"
|
||||
- test: "Layout editor"
|
||||
uat_row: 5
|
||||
recorded_at: "2026-11-15T08:11:21.000Z"
|
||||
- test: "Insert image into layout"
|
||||
uat_row: 6
|
||||
recorded_at: "2026-11-15T08:11:21.000Z"
|
||||
- test: "Branding"
|
||||
uat_row: 7
|
||||
recorded_at: "2026-11-15T08:11:21.000Z"
|
||||
- test: "Preview"
|
||||
uat_row: 8
|
||||
recorded_at: "2026-11-15T08:11:21.000Z"
|
||||
- test: "Send test to me"
|
||||
uat_row: 9
|
||||
recorded_at: "2026-11-15T08:11:21.000Z"
|
||||
- test: "Confirm judgment-tier prohibition: postcard imports modules/lagoon/attach for AbsolutePublicURL."
|
||||
uat_row: 10
|
||||
recorded_at: "2026-11-13T21:09:53.000Z"
|
||||
human_verification:
|
||||
- test: "Template list"
|
||||
expected: "On the demo app rebuilt on this framework commit: Mail templates shows one row per template with a Customized locales column; opening a template shows the Language switcher under the title; switching to a locale without a file, saving it and switching back works behind the unsaved-changes confirm. Re-run UAT test 1 in full."
|
||||
why_human: "Placement and readability of the switcher and the Customized locales column in the embedded admin (35-VALIDATION Manual-Only). The G-35-1 gap record is marked resolved by 35-07 in 35-UAT.md, but row 1 still reads 'issue' and was never re-tested"
|
||||
retest_reason: "UAT row 1 was an issue (G-35-1); the fix (35-05, 35-07) landed after it"
|
||||
- test: "Preview"
|
||||
expected: "Scoped re-run: reset the UAT overrides of the user plugin's activate template and its layout; save Branding with a logo and a Site name; preview a template on the default and on the system layout with a body override calling {{ partial \"button\" \"url\" \"https://example.com\" \"body\" \"Go\" }}. Expect the logo header (or the name without a logo), the white card, the styled button and the footer (© year and name, printed literally)."
|
||||
why_human: "Visual rendering of the built-in layouts in the admin preview (35-VALIDATION Manual-Only)"
|
||||
retest_reason: "UAT row 8 was an issue (G-35-8, framework part); the fix (35-06, 35-07) landed after it"
|
||||
- test: "Customize and save a template"
|
||||
expected: "Saving a customized template still works and the saved version is sent"
|
||||
why_human: "Admin save flow in the embedded SPA"
|
||||
retest_reason: "the save-time safety check changed after the UAT pass (2026-11-13T21:09:53Z): modules/postcard/safety.go (35-08 tokenizer check, CR-02 raw-text/comment re-check, WR-01 whitespace stripping, then the quote-aware tag reading of quick 261114-p5m, d6ac0aeb) and modules/postcard/templates.go (WR-02 removed the handler regex)"
|
||||
- test: "Layout editor"
|
||||
expected: "Editing and saving a layout still works; an unsafe layout is refused with a line under the field"
|
||||
why_human: "Admin save flow in the embedded SPA"
|
||||
retest_reason: "layout validation in modules/postcard/safety.go and templates.go changed after the UAT pass (2026-11-13T21:09:53Z), including the 'nests raw-text elements or comments too deeply' refusal and the second, quote-aware tag reading (d6ac0aeb)"
|
||||
- test: "Insert image into layout"
|
||||
expected: "An uploaded image inserted into a layout saves and previews"
|
||||
why_human: "Image picker flow in the embedded SPA"
|
||||
retest_reason: "the src/href check that validates the inserted img was rewritten after the UAT pass (2026-11-13T21:09:53Z): tokenizer check in 35-08, stripURLSpace refactor in WR-01, shared unsafeAttrs and a second tag reading in d6ac0aeb"
|
||||
- test: "Branding"
|
||||
expected: "Change a colour, set a logo and a prose Site name, Save, reload; values persist and the template preview uses them"
|
||||
why_human: "Settings form and preview in the embedded admin"
|
||||
retest_reason: "modules/cabana/mail_admin.go BeforeValidate now calls postcard.UnsafeText (35-08), whose rule changed again in CR-01 (printContext), WR-03 (data-URL shape) and d6ac0aeb (validateHTML gained the tag reading); modules/cabana/settings.go error localization and modules/postcard/editor.go brand preview changed after the UAT pass (2026-11-13T21:09:53Z)"
|
||||
recorded_at: "2026-11-15T08:11:21.000Z"
|
||||
- test: "Branding refusal on the demo instance"
|
||||
expected: "On the demo app: Site name 'javascript:alert(1)' and 'data:text/html,x' are refused with the translated message under Site name (en and pl, copy without 'text such as onclick='); 'Online=Shop', 'Data:Lab' and 'Big Data: Summit' save and appear in the preview header and footer"
|
||||
why_human: "Field-error rendering and the new en/pl copy in the embedded admin; never seen by a human"
|
||||
- test: "Send test to me"
|
||||
expected: "Send test to me delivers the draft to the signed-in admin only"
|
||||
why_human: "Real delivery through the configured driver"
|
||||
retest_reason: "modules/postcard/mailer.go (site name selection), templates.go and safety.go (send-time validateHTML, handler regex removed, tag reading added) and the default/system layouts and footer partial changed after the UAT pass (2026-11-13T21:09:53Z)"
|
||||
uat_row: 11
|
||||
recorded_at: "2026-11-15T08:11:21.000Z"
|
||||
- test: "Review the CR-01, CR-02 and WR-02 safety-rule changes, including the CR-02 residual fix"
|
||||
expected: "Accept or reject the rule changes that 35-REVIEW-FIX.md marks 'requires human verification': (CR-01) UnsafeText checks the name where the layouts print it; (CR-02) raw-text element and comment content is re-checked as markup with an 8-level depth limit; (CR-02 residual, quick 261114-p5m) every tag is read a second time with attribute quoting alone deciding where it ends, which can over-refuse after an unbalanced quote in a comment or style element; (WR-02) text shaped like an event handler is sent, and only attributes count as handlers. The decision note .planning/notes/2026-11-14-mail-url-scheme-check.md was amended twice to match"
|
||||
why_human: "Logic changes to the mail safety contract, a reversal of a documented accepted residual and a new accepted over-refusal risk; the fixer asked for human sign-off"
|
||||
uat_row: 12
|
||||
recorded_at: "2026-11-15T08:11:21.000Z"
|
||||
- test: "Confirm judgment-tier prohibitions of 35-05..35-09, the review fix round and quick 261114-p5m"
|
||||
uat_row: 14
|
||||
recorded_at: "2026-11-15T08:11:21.000Z"
|
||||
human_verification:
|
||||
- test: "Inlined mail in a real inbox"
|
||||
expected: "Test-send a template in the default layout to a real webmail/Outlook inbox; the button and card keep their colours with the style block stripped"
|
||||
why_human: "Mail clients differ in what they keep of a style block; cannot be asserted by unit tests"
|
||||
- test: "Confirm judgment-tier prohibitions of 35-05..35-09, the review fix round and quick 261114-p5m"
|
||||
expected: "Accept: no sibling repository changed by this phase (sm-user-plugin and sm-paymentgateway-plugin clean before and after the verifier's --consumers run; the concurrent restyle there is quick 261114-p5n, not this phase); nothing pushed or tagged (master is 113 commits ahead of origin/master, newest tag v0.6.4 predates the gap closures); framework code, docs and tests name no consuming application (--marker passed)"
|
||||
why_human: "Judgment-tier prohibitions need explicit human resolution; the verifier's LLM judgment is non-authoritative"
|
||||
why_human: "Mail clients differ in what they keep of a style block; unit tests (TestInlineCSS) prove the style attributes are written, not how a client renders them. UAT row 13 was skipped: the demo uses the log mail driver"
|
||||
---
|
||||
|
||||
# Phase 35: Mail templates and layouts editor Verification Report
|
||||
|
||||
**Phase Goal:** Administrators edit every mail the application sends from the admin panel, as in WinterCMS's Mail templates screen. System mail and the templates plugins register through `pact.HasMailTemplates` appear in a list. Each template can get a database override of its subject and body, and the override can be reset to the file version. Layouts become admin-editable records assigned to templates, with a few predefined layouts seeded. Images can be uploaded and placed in layouts and templates. postcard renders the override when one exists, otherwise the plugin's file, so mail that already works keeps working.
|
||||
**Verified:** 2026-11-14T17:43:56Z
|
||||
**Verified:** 2026-11-16T07:16:15Z
|
||||
**Status:** human_needed
|
||||
**Re-verification:** Yes. Fourth re-verification, after quick task 261114-p5m (d6ac0aeb fix, e47d4ae6 note, f1f284a0 tests), which targets the only remaining gap (truth 18, CR-02 residual). The carried-forward gap got a full check: the code diff was read, the four verifier overlay probes were re-run unchanged, and the new tests were run by name. The previously passed truths got a regression check (vet, the short suite once, named and Docker tests, gate stages). No repository source was modified. The verifier wrote no new bypass variants this round. The quick task's eight `*_end_in_attr` refuse cases, its accept cases and its parser-oracle `escaped_send` subtests cover the residual's shape.
|
||||
**Re-verification:** Yes. The previous report (2026-11-14, human_needed, 22/22) went stale when quick 261115-cha changed covered files. This round fully checked the new code, regression-checked every earlier truth, and applied the completed UAT (35-UAT.md, 12 passed, 1 issue, 1 skipped). No repository source was modified.
|
||||
|
||||
## Goal Achievement
|
||||
|
||||
ROADMAP gives no Success Criteria for Phase 35 and `Requirements: TBD`, so the must-haves are the goal's clauses (Option C) merged with the PLAN truths of 35-01..35-09. The 22 rows are the same as in the previous report.
|
||||
ROADMAP gives no Success Criteria for Phase 35 (`Requirements: TBD`), so the must-haves are the goal's clauses (Option C), merged with the PLAN truths of 35-01..35-09 (rows 1-22, unchanged from the previous report) and the must-haves of quick 261115-cha (row 23).
|
||||
|
||||
### Observable Truths
|
||||
|
||||
| # | Truth | Status | Evidence |
|
||||
| --- | --- | --- | --- |
|
||||
| 1 | Administrators edit mail from Settings → Mail (templates, layouts, partials, branding, images) | ✓ VERIFIED | Screens unchanged; cabana Postgres tests pass; UAT re-tests owed (Human Verification) |
|
||||
| 2 | Templates appear one row per template (G-35-1) | ✓ VERIFIED | `TestMailLocaleGroups` PASS (Docker); visual re-run of UAT 1 owed |
|
||||
| 3 | Locale switcher; per-locale customize, reset, drift | ✓ VERIFIED | `TestMailLocaleGroups` PASS |
|
||||
| 4 | DB override of subject/body; Reset restores the file | ✓ VERIFIED | `TestOverride`, `TestFallback` PASS; UAT row 3 stands (reset code untouched) |
|
||||
| 5 | Layouts are editable records; default/system/minimal seeded | ✓ VERIFIED | unchanged; `TestMailOverrideSmoke/layouts_and_partials` PASS |
|
||||
| 6 | Built-in layouts finished (header, card, footer, button) | ✓ VERIFIED | `TestBuiltinLayoutsLogo`, `TestHeaderFooterPartials`, `TestButtonPartial` PASS; they also pass the new tag reading |
|
||||
| 7 | Branding Site name, else mail.from display name | ✓ VERIFIED | `TestSiteName`, `TestMailBrandSiteName` PASS |
|
||||
| 8 | CSS inlined with per-layout opt-out; inliner failure never stops mail | ✓ VERIFIED | `TestInlineCSS`, `TestInlineFailure`, `TestMailLayoutInlineOptOut` PASS |
|
||||
| 9 | Images uploaded and placed in layouts and templates | ✓ VERIFIED | routes and picker unchanged; UAT 6 re-test owed |
|
||||
| 10 | Override when present, else file; `<template>-<locale>` fallback | ✓ VERIFIED | `TestSendLocaleFallback`, `TestTemplateFor`, `TestMailOverrideSmoke/locale_fallback` PASS |
|
||||
| 11 | Mail that already works keeps working: no config that sends today and no admin-saved Branding value stops mail on the built-in layouts | ✓ VERIFIED | Re-run probe 1: Branding and mail.from `Online=Shop`/`onboarding=team` and the prose variable send on default and system (10 × `err=<nil>`); `TestSiteNameSend` PASS; consumer plugins' mail tests pass (`--consumers`) |
|
||||
| 12 | `check-phase35.sh` gate: read-only consumers, new names required | ✓ VERIFIED | Verifier ran `--self-test`, `--docs`, `--marker`, `--additive` (8 packages vs v0.6.3), `--consumers`: all exit 0 |
|
||||
| 13 | Decision notes recorded | ✓ VERIFIED | `.planning/notes/2026-11-14-mail-url-scheme-check.md` amended again (e47d4ae6): status line, decision bullet, over-refusal residual risk, two rejected alternatives, amendment bullet |
|
||||
| 14 | Permission split, own-address test send, sandboxed preview | ✓ VERIFIED | no regression; `TestMailLocaleGroups` PASS |
|
||||
| 15 | Sends with mail.from `"Metadata: Weekly"` / Branding `Big Data: Summit` on every path; name in header and footer | ✓ VERIFIED | `TestSiteNameSend` PASS |
|
||||
| 16 | An unsafe site name is left out at render with one rate-limited warning; send succeeds on every path and in the editor | ✓ VERIFIED | `TestUnsafeSiteNameDropped` PASS |
|
||||
| 17 | Branding save of an unsafe name is a 422 on site_name (en/pl); template/layout saves under a stored name are not refused | ✓ VERIFIED | `TestMailSiteNameSafety` PASS (Docker); probe `Editor.Validate` under `Online=Shop` accepts both fixture templates |
|
||||
| 18 | URL-scheme check anchored to URL-bearing attributes, decoded; prose passes; `javascript:` URLs refused at save and send, inlining on or off | ✓ VERIFIED | **Gap closed.** Behavior-dependent truth with behavioral evidence: `TestURLSchemeCheck` PASS with 23 new subtests matched (refuse ×8, send inline/opt_out ×6, escaped_send ×4, accept, editor), 0 FAIL. Re-run probe 2: `validateHTML` refuses all 8 payloads that passed last round, including the conditional-comment advisory case. The noscript href, noscript handler and svg/style layout overrides fall back to the file version with inlining on and off. svg title/textarea are sent as html/template-escaped text, and the repository's parser oracle (scripting on and off) finds no live element. Probe 3 still shows x/net/html would build `svg:a href=javascript:` from the svg/style payload, so refusing it is the correct outcome |
|
||||
| 19 | An inlined result that fails the check is sent as its style-block version with a warning | ✓ VERIFIED | `TestInlineUnsafeOutput` PASS |
|
||||
| 1 | Administrators edit mail from Settings → Mail (templates, layouts, partials, branding, images) | ✓ VERIFIED (human UAT, rows 2, 5, 6, 7) | cabana Docker suite PASS (90.9 s, 0 skips); screens unchanged since the UAT |
|
||||
| 2 | Templates appear one row per template (G-35-1) | ✓ VERIFIED | `TestMailLocaleGroups` PASS (Docker). The UAT row 1 note says "Previous G-35-1 (one row per locale) confirmed fixed"; the row's remaining issue is G-35-9's plugin part (deferred) |
|
||||
| 3 | Locale switcher; per-locale customize, reset, drift | ✓ VERIFIED (human UAT, rows 3, 4) | `TestMailLocaleGroups` PASS |
|
||||
| 4 | DB override of subject/body; Reset restores the file | ✓ VERIFIED (human UAT, rows 2, 3) | `TestOverride`, `TestFallback`, `TestMailOverrideSmoke/override` PASS |
|
||||
| 5 | Layouts are editable records; default/system/minimal seeded | ✓ VERIFIED (human UAT, row 5) | `TestMailOverrideSmoke/layouts_and_partials` PASS |
|
||||
| 6 | Built-in layouts finished (header, card, footer, button) | ✓ VERIFIED (human UAT, row 8) | `TestBuiltinLayoutsLogo`, `TestHeaderFooterPartials`, `TestButtonPartial` PASS |
|
||||
| 7 | Branding Site name, else mail.from display name | ✓ VERIFIED (human UAT, rows 7, 11) | `TestSiteName`, `TestMailBrandSiteName` PASS |
|
||||
| 8 | CSS inlined with per-layout opt-out; inliner failure never stops mail | ✓ VERIFIED | `TestInlineCSS`, `TestInlineFailure`, `TestMailLayoutInlineOptOut` PASS. How a real client renders it stays a human item (UAT row 13 skipped) |
|
||||
| 9 | Images uploaded and placed in layouts and templates | ✓ VERIFIED (human UAT, row 6) | routes and picker unchanged |
|
||||
| 10 | Override when present, else file; `<template>-<locale>` fallback | ✓ VERIFIED | `TestSendLocaleFallback`, `TestTemplateFor`, `TestMailOverrideSmoke/locale_fallback`, `/file`, `/fallback` PASS |
|
||||
| 11 | Mail that already works keeps working | ✓ VERIFIED | Full short suite exit 0 (47 packages); `TestSiteNameSend` PASS; `--consumers` PASS against this checkout after the plugin restyle (261114-p5n) landed |
|
||||
| 12 | `check-phase35.sh` gate | ✓ VERIFIED | `--self-test`, `--docs`, `--marker`, `--additive` (8 packages vs v0.6.3), `--consumers`: all exit 0 |
|
||||
| 13 | Decision notes recorded | ✓ VERIFIED | unchanged; `.planning/notes/2026-11-14-mail-url-scheme-check.md` accepted in UAT row 12 |
|
||||
| 14 | Permission split, own-address test send, sandboxed preview | ✓ VERIFIED (human UAT, row 9) | cabana Docker suite PASS |
|
||||
| 15 | Sends with `"Metadata: Weekly"` / `Big Data: Summit`; name in header and footer | ✓ VERIFIED (human UAT, row 11) | `TestSiteNameSend` PASS |
|
||||
| 16 | Unsafe site name left out at render; send succeeds | ✓ VERIFIED | `TestUnsafeSiteNameDropped` PASS |
|
||||
| 17 | Branding save of an unsafe name is a 422 on site_name (en/pl) | ✓ VERIFIED (human UAT, row 11) | `TestMailSiteNameSafety` PASS (Docker) |
|
||||
| 18 | URL-scheme check anchored, decoded; `javascript:` refused at save and send | ✓ VERIFIED (human UAT, row 12 accepted the rule changes) | `TestURLSchemeCheck` PASS |
|
||||
| 19 | An inlined result that fails the check is sent as its style-block version | ✓ VERIFIED | `TestInlineUnsafeOutput` PASS |
|
||||
| 20 | Footer prints the site name literally | ✓ VERIFIED | `TestFooterSiteNameLiteral` PASS |
|
||||
| 21 | sm-user-plugin and sm-paymentgateway-plugin mail tests pass read-only | ✓ VERIFIED | `--consumers` passed (2 + 3 top-level tests); both trees clean before and after (empty `git status`) |
|
||||
| 22 | 35-07 pin subtest gone; gate requires new names; IN-03 self-test uses `cmp` | ✓ VERIFIED | `--self-test` passed |
|
||||
| 21 | sm-user-plugin and sm-paymentgateway-plugin mail tests pass read-only | ✓ VERIFIED | `--consumers` PASS; both trees clean before and after (empty `git status --porcelain`) |
|
||||
| 22 | 35-07 pin subtest gone; gate requires new names; IN-03 self-test uses `cmp` | ✓ VERIFIED | `--self-test` PASS |
|
||||
| 23 | A template's `layout` may name a layout another registered plugin owns by full code; an unregistered full code fails at boot with a require-the-owner hint; another plugin's short alias is still refused with the byte-identical error; existing resolution unchanged; editor, overrides and the index work with it (G-35-9 framework part) | ✓ VERIFIED | Diff read: the new branch in `resolveLayoutLocked` (templates.go:246-252) runs only after the own-alias and built-in lookups miss and the value holds `::`, and it checks `c.layouts`. party boots plugins in `Requires()` order (registry.go:141-147), so the owner's layouts are in the catalog first. `TestCrossPluginLayout` (6 subtests: send renders the lender's HTML and text wrappers, `owner_registers_later` error prefix and hint, `unknown_full_code`, `other_plugin_alias_refused` exact text, `precedence_unchanged`, `builtin_full_code`), `TestCrossPluginLayoutOverride` (3: override layout, customized owner layout, Editor Validate/Preview) PASS; `TestCrossPluginLayoutSync` PASS under Docker (borrower rows join the lender layout row; layout_id stable on a second sync) |
|
||||
|
||||
**Score:** 22/22 truths verified (0 present, behavior-unverified).
|
||||
**Score:** 23/23 truths verified (0 present, behavior-unverified).
|
||||
|
||||
### Deferred Items
|
||||
|
||||
| # | Item | Addressed In | Evidence |
|
||||
|---|------|-------------|----------|
|
||||
| 1 | G-35-8 plugin part: user and paymentgateway plugin CTAs through the button partial, finished plugin layouts, framework bump | Plugin follow-up after the framework tag (user decision 2026-11-13; quick 261114-p5n in flight in the sibling repos) | 35-06-PLAN "Follow-ups", 35-UAT G-35-8. Informational |
|
||||
| 1 | G-35-9 plugin part: sm-mfa-plugin's two_factor_code templates set `layout = "golem15.user::mail.layouts.user"` (UAT row 1 issue) | sm-mfa-plugin follow-up after the next framework tag (separate repo; out of scope by instruction) | 35-UAT.md G-35-9 closure_note; framework support verified as truth 23 |
|
||||
| 2 | G-35-8 plugin part: plugin CTAs through the button partial, framework bump | Plugin follow-up after the framework tag | 35-UAT.md G-35-8 closure_note |
|
||||
|
||||
### Advisory (New Scope, Unevidenced)
|
||||
|
||||
| # | Finding | Category | Why Advisory |
|
||||
|---|---------|----------|--------------|
|
||||
| 1 | Tag reading can over-refuse after an unbalanced quote in a comment or style element | other | Documented residual risk; no failing case. Re-run `--consumers` after 261114-p5n lands |
|
||||
| 2 | 35-UAT gap records marked resolved, but rows 1 and 8 still read `issue` | other | Record reconciliation, not human evidence; the re-tests stay owed |
|
||||
| 3 | WR-03 deviation: `JavaScript: The Good Parts Club` still refused | other | Deliberate per the note; product decision |
|
||||
| 4 | 35-UI-SPEC.md:427, 35-08-PLAN.md:130 quote the old copy | other | Copy contract drift |
|
||||
| 5 | IN-01..IN-03, WR-04, WR-05, IN-04 open | other | Info-level or outside the fix round |
|
||||
| 1 | WR-03 deviation: `JavaScript: The Good Parts Club` still refused | other | Deliberate per the note; product decision |
|
||||
| 2 | 35-UI-SPEC.md:427 quotes the old refusal copy | other | Copy contract drift; the admin shows the new copy (UAT row 11) |
|
||||
| 3 | IN-01..IN-03, WR-04, WR-05, IN-04 open | other | Info-level or outside the fix round |
|
||||
| 4 | `layout = "postcard::mail.layouts.default"` now resolves to the full name instead of the alias, and no test covers it | other | That value failed at boot before, so no existing configuration changes |
|
||||
|
||||
Closed since the previous report: the conditional-comment advisory (`-->` inside an attribute) is now refused (`refuse/conditional_comment_end_in_attr`), and 35-REVIEW-DISPOSITION.md frontmatter now marks CR-01/CR-02/WR-01 `fixed` (d8137c17).
|
||||
Closed since the previous report:
|
||||
- The over-refusal advisory: the human accepted the tag-reading risk in UAT row 12, and `--consumers` passes after 261114-p5n.
|
||||
- The "rows 1 and 8 still read issue" advisory: row 8 passed on the re-test, and row 1's remaining issue is G-35-9's plugin part.
|
||||
|
||||
### Required Artifacts
|
||||
|
||||
| Artifact | Expected | Status | Details |
|
||||
| -------- | -------- | ------ | ------- |
|
||||
| `modules/postcard/safety.go` | `unsafeMarkupAt` = depth guard, `unsafeHTMLReading` (old loop), `unsafeTagReading` (quote-aware); shared `unsafeAttrs` | ✓ VERIFIED | Read in full diff. The tag reading tokenizes a same-length copy with `<!--` → ` !--` and calls `NextIsNotRawText()` after each `rawTextElements` start tag; it runs at every recursion depth. No exported API change (`--additive` passes) |
|
||||
| `modules/postcard/safety_test.go` | end-tag-in-attribute refuse, send, editor, accept and parser-oracle cases | ✓ VERIFIED | PASS; `liveUnsafeElements` parses the sent HTML with `xhtml.ParseWithOptions`, scripting on and off |
|
||||
| `modules/postcard/README.md`, `docs/services/mail.md` | one sentence on the quote-aware reading | ✓ VERIFIED | Present in both; `--docs` passed |
|
||||
| `.planning/notes/2026-11-14-mail-url-scheme-check.md` | amended | ✓ VERIFIED | e47d4ae6 |
|
||||
| Earlier artifacts | | ✓ VERIFIED | admin/, boardwalk/dist, go.mod/go.sum unchanged since c1e8e57e |
|
||||
| `modules/postcard/templates.go` | full-code branch in `resolveLayoutLocked`, new error, comments | ✓ VERIFIED | 17-line change. The short-alias error is untouched (`postcard: unknown layout %s`) |
|
||||
| `modules/postcard/mailer.go` | BootPlugin doc comment | ✓ VERIFIED | comment-only change |
|
||||
| `modules/postcard/layout_ref_test.go` | TestCrossPluginLayout, TestCrossPluginLayoutOverride, TestCrossPluginLayoutSync | ✓ VERIFIED | 309 lines with real assertions on HTML/text wrappers, error text and DB joins; all PASS |
|
||||
| `modules/postcard/README.md`, `docs/services/mail.md` | full-code form, resolution order, require-the-owner rule, `acme.blog::mail.layouts.blog` example | ✓ VERIFIED | Present; `--docs` (TestDocsTree, TestCommandsDocumented, docs:build --check) PASS; no consumer app named (`--marker`) |
|
||||
| Earlier artifacts (admin/, boardwalk/dist, cabana, lagoon, pact, surf, go.mod/go.sum) | | ✓ VERIFIED | `git diff --name-only 3541c9bd HEAD` lists only the five files above under modules/ and docs/; no uncommitted changes there |
|
||||
|
||||
### Key Link Verification
|
||||
|
||||
| From | To | Via | Status | Details |
|
||||
| ---- | --- | --- | ------ | ------- |
|
||||
| `postcard/templates.go` | `postcard/safety.go` | `validateHTML` → `unsafeMarkup` → `unsafeMarkupAt` → `unsafeHTMLReading` + `unsafeTagReading` | ✓ WIRED | Both readings run on every call and at every depth |
|
||||
| `unsafeHTMLReading`, `unsafeTagReading` | `unsafeAttrs` | direct call per start tag | ✓ WIRED | same handler/URL rules in both readings |
|
||||
| `postcard/editor.go` | `validateHTML` | `Editor.Validate` | ✓ WIRED | probe 2 and `editor/*` subtests refuse the layouts |
|
||||
| `postcard/mailer.go` | `validateHTML` | send-time check → file-version fallback | ✓ WIRED | probe 2 and probe 4 log "override failed, sending the file version" |
|
||||
| `cabana/mail_admin.go` | `postcard.UnsafeText` | `BeforeValidate` | ✓ WIRED | `TestMailSiteNameSafety` PASS |
|
||||
| `party/registry.go` boot loop | `postcard.BootPlugin` → `Catalog.Register` → `resolveLayoutLocked` | `ordered` (Requires topological order) | ✓ WIRED | registry.go:141-147 |
|
||||
| `parsedTemplate.layout` (full code) | render (`layoutFor`/`layoutByCode`), `SyncIndex` layout_id | catalog lookup by code, no plugin scoping | ✓ WIRED | `file_layout_by_full_code` send and `TestCrossPluginLayoutSync` |
|
||||
| cabana layout picker / save | `Editor.Validate` | `scopeLayouts` lists every catalog layout code (mail_admin.go:321) | ✓ WIRED | `editor_validate_and_preview` PASS; cabana unchanged |
|
||||
| `postcard/templates.go`, `mailer.go`, `editor.go` | `validateHTML` (safety) | unchanged since the previous report | ✓ WIRED | `TestURLSchemeCheck` PASS |
|
||||
|
||||
### Data-Flow Trace (Level 4)
|
||||
|
||||
| Artifact | Data Variable | Source | Produces Real Data | Status |
|
||||
| -------- | ------------- | ------ | ------------------ | ------ |
|
||||
| Layout header/footer | `siteName` | Branding row / mail.from via `siteNameFrom` | Yes | ✓ FLOWING |
|
||||
| Layout override HTML | rendered layout | `Overrides.Layouts` → render → `validateHTML` → driver | Yes | ✓ FLOWING (unsafe → file version) |
|
||||
| Earlier flows | | | Yes | ✓ FLOWING |
|
||||
| Borrower template HTML/text | layout wrapper | lender's file layout in `c.layouts`, or its override in `Overrides.Layouts` | Yes | ✓ FLOWING |
|
||||
| Template row `layout_id` | lender layout row | `SyncIndex` subquery by code | Yes | ✓ FLOWING |
|
||||
| Earlier flows (site name, overrides, layouts) | | | Yes | ✓ FLOWING |
|
||||
|
||||
### Behavioral Spot-Checks
|
||||
|
||||
@@ -383,84 +382,69 @@ Closed since the previous report: the conditional-comment advisory (`-->` inside
|
||||
| -------- | ------- | ------ | ------ |
|
||||
| vet | `go vet ./...` | clean | ✓ PASS |
|
||||
| Full short suite (once) | `go test -short -count=1 ./...` | exit 0, 47 packages ok | ✓ PASS |
|
||||
| postcard named tests | `go test -short ./modules/postcard -run '^(TestURLSchemeCheck\|TestSiteNameSend\|TestUnsafeSiteNameDropped\|TestUnsafeText\|TestFooterSiteNameLiteral\|TestInlineUnsafeOutput\|TestMailSafetySmoke\|TestInlineCSS\|TestInlineFailure\|TestOverride\|TestFallback\|TestTemplateFor\|TestSendLocaleFallback\|TestBuiltinLayoutsLogo\|TestHeaderFooterPartials\|TestButtonPartial\|TestSiteName)$' -v` | 17 PASS | ✓ PASS |
|
||||
| New CR-02 residual subtests | `go test -short ./modules/postcard -run '^TestURLSchemeCheck$' -v` | 23 matching subtests PASS, 0 FAIL in the whole test | ✓ PASS |
|
||||
| postcard Docker smoke | `go test -count=1 ./modules/postcard -run '^TestMailOverrideSmoke$' -v` | 11 subtests PASS incl. `fallback`, `locale_fallback` | ✓ PASS |
|
||||
| cabana Postgres (Docker) | `go test -count=1 ./modules/cabana -run '^(TestMailSiteNameSafety\|TestMailBrandSiteName\|TestMailLocaleGroups\|TestMailLayoutInlineOptOut)$' -v` | 4 PASS | ✓ PASS |
|
||||
| Gate stages | `check-phase35.sh --self-test`, `--docs`, `--marker`, `--additive`, `--consumers` | all exit 0 | ✓ PASS |
|
||||
| Probe 1 (re-run) | `go test -short -overlay .../probe/overlay.json ./modules/postcard -run TestZZ -v` | CR-01 sends `err=<nil>`; CR-02 payloads refused; noscript layout falls back | ✓ PASS |
|
||||
| Probe 2 (re-run, the open gap) | `-overlay .../probe/overlay2.json -run 'TestZZV2'` | `validateHTML` refuses 8/8 (was 0/8); noscript ×2 and svg/style layouts `fallback=true` with inlining on and off; svg title/textarea sent as escaped text. Body overrides carry no raw HTML (goldmark) | ✓ PASS (gap closed) |
|
||||
| Probe 2 `liveJS=true` lines (svg title/textarea, opt-out) | sent HTML `<svg><title><a title="</title>" href="javascript:alert(1)">x</a></title>` | The probe's regex matches a substring. The text after `</title>` is a text node, and no `<a` start tag remains. `escaped_send/*` subtests parse the sent HTML (scripting on and off) and find no live unsafe attribute | ✓ PASS (probe false positive) |
|
||||
| Probe 3 (re-run) | `-overlay .../probe/overlay3.json -run TestZZV3Parse` | the parser still builds live links from the raw payloads; `validateHTML` now refuses all three | ✓ PASS (refusal is correct) |
|
||||
| Probe 4 (re-run) | `-overlay .../probe/overlay4.json -run TestZZV4` | with inlining on, both payloads now fall back by the check, not by premailer's side effects | ✓ PASS |
|
||||
|
||||
Probe files (scratchpad, not in the repo): `/tmp/claude-1000/-media-nvme-dev-golem15-summercms-io-summercms-summercms-go/0c86abd1-8e0c-485b-8ad1-fd321a8a0fda/scratchpad/probe/zz_verifier_probe_test.go`, `zz_verifier_probe2_test.go`, `zz_verifier_probe3_test.go` and `zz_verifier_probe4_test.go` in the same directory, applied through `overlay.json`, `overlay2.json`, `overlay3.json` and `overlay4.json`.
|
||||
| postcard + cabana short | `go test -short -count=1 ./modules/postcard/... ./modules/cabana/...` | ok, ok | ✓ PASS |
|
||||
| postcard + cabana with Docker | `go test -count=1 ./modules/postcard/... ./modules/cabana/...` | exit 0, 0 skips (postcard 10.7 s, cabana 90.9 s) | ✓ PASS |
|
||||
| Cross-plugin layout | `go test -short ./modules/postcard -run '^(TestCrossPluginLayout\|TestCrossPluginLayoutOverride\|TestCrossPluginLayoutSync)$' -v` | 9 subtests PASS (Sync skipped under -short) | ✓ PASS |
|
||||
| Cross-plugin sync (Docker) | `go test ./modules/postcard -run '^(TestCrossPluginLayoutSync\|TestMailOverrideSmoke)$' -v` | PASS; smoke 11 subtests PASS | ✓ PASS |
|
||||
| Named regressions | 15 postcard tests (URL check, site name, inlining, overrides, locale fallback, layouts) and 4 cabana Postgres tests | all PASS | ✓ PASS |
|
||||
| Gate stages | `check-phase35.sh --self-test`, `--docs`, `--marker`, `--additive`, `--consumers` | all exit 0; siblings clean before and after | ✓ PASS |
|
||||
|
||||
### Probe Execution
|
||||
|
||||
No `scripts/*/tests/probe-*.sh` is declared or present for this phase, so this step is N/A. The phase gate stages and the verifier's overlay probes above were run directly.
|
||||
No `scripts/*/tests/probe-*.sh` is declared or present for this phase, so this step is N/A. The phase gate stages were run directly.
|
||||
|
||||
### Requirements Coverage
|
||||
|
||||
REQUIREMENTS.md has no row naming Phase 35. Plan `requirements:` values are review and decision IDs:
|
||||
REQUIREMENTS.md has no row naming Phase 35. Plan `requirements:` values are review and decision IDs; the quick task declares `QUICK-261115-cha`.
|
||||
|
||||
| Requirement | Source Plan | Description | Status | Evidence |
|
||||
| ----------- | ---------- | ----------- | ------ | -------- |
|
||||
| CR-01 | 35-08, 35-09, fix 2dbee305/31de2ff9 | site name never stops mail | ✓ SATISFIED | rows 11, 16, 17 |
|
||||
| WR-01 (2026-11-13) | 35-08, 35-09 | literal footer | ✓ SATISFIED | row 20 |
|
||||
| WR-05 | 35-08, 35-09 | decoded scheme check; inliner never stops mail | ✓ SATISFIED | rows 8, 18, 19 |
|
||||
| D-13 | 35-08 | unsafe URLs refused at save and send | ✓ SATISFIED | row 18 (CR-02 residual closed) |
|
||||
| D-10, D-14 | 35-08 | Branding rules; a failing override never stops mail | ✓ SATISFIED | rows 11, 17 |
|
||||
| D-21 | 35-09 | tests last, gate | ✓ SATISFIED | gate stages pass |
|
||||
| Earlier D-01..D-25, G-35-1, G-35-8 | 35-01..07 | | ✓ SATISFIED | G-35-1/G-35-8 still need the UAT re-test |
|
||||
| Orphaned | — | — | none | no REQUIREMENTS.md row maps to Phase 35 |
|
||||
| CR-01, WR-01, WR-05, D-13, D-10, D-14, D-21 | 35-08, 35-09 | safety rules, site name, gate | ✓ SATISFIED | rows 11, 16-20; UAT rows 11, 12 |
|
||||
| D-01..D-25, G-35-1, G-35-8 (framework) | 35-01..07 | editor, overrides, layouts, images, locale grouping, finished layouts | ✓ SATISFIED | rows 1-10; UAT rows 2-9 |
|
||||
| QUICK-261115-cha / G-35-9 (framework) | quick 261115-cha | cross-plugin layout by full code | ✓ SATISFIED | row 23 |
|
||||
| Orphaned | none | none | none | no REQUIREMENTS.md row maps to Phase 35 |
|
||||
|
||||
### Anti-Patterns Found
|
||||
|
||||
| File | Line | Pattern | Severity | Impact |
|
||||
| ---- | ---- | ------- | -------- | ------ |
|
||||
| modules/, docs/, scripts/ lines added in c1e8e57e..HEAD | — | TBD/FIXME/XXX/TODO/HACK | none found | — |
|
||||
|
||||
No blockers. The previous blocker (`unsafeMarkupAt` bounded by the tokenizer's raw-text end) is resolved.
|
||||
| modules/, docs/, scripts/, admin/ lines added in 3541c9bd..HEAD | none | TBD/FIXME/XXX/TODO/HACK | none found | none |
|
||||
|
||||
### Prohibitions
|
||||
|
||||
| Statement (plan) | Tier | Verdict | Flag |
|
||||
| --------- | ---- | ------- | ---- |
|
||||
| pact/postcard/cabana API changes additive only | automated | Holds: `--additive` passes against v0.6.3 | none |
|
||||
| No new dependency, go.mod/go.sum unchanged | automated | Holds: empty diff since c1e8e57e | none |
|
||||
| admin/ and boardwalk/dist unchanged (35-08) | automated | Holds: empty diff since c1e8e57e | none |
|
||||
| No new dependency, go.mod/go.sum unchanged | automated | Holds: empty diff since the previous report | none |
|
||||
| Tests and gate never write a sibling repository | automated | Holds: both trees clean before and after `--consumers` | none |
|
||||
| No sibling repository changed | judgment | Holds for this phase (LLM, non-authoritative); concurrent changes there belong to quick 261114-p5n | unverified-prohibition, human review recommended |
|
||||
| Nothing pushed or tagged | judgment | Holds: 113 ahead of origin/master, newest tag v0.6.4 | unverified-prohibition, human review recommended |
|
||||
| Framework code, docs, tests name no consuming application | judgment | Holds: `--marker` passed | unverified-prohibition, human review recommended |
|
||||
| postcard does not import lagoon (35-01) | judgment | Deviates (`lagoon/attach`) | resolved: accepted in UAT row 10 |
|
||||
| No sibling repo changed, nothing pushed or tagged, no consuming app named | judgment | Accepted in UAT row 14. Still holds after 261115-cha: 121 commits ahead of origin/master, newest tag v0.6.4 (2026-11-08), `--marker` passed. The quick plan declares no prohibitions of its own | resolved: UAT row 14 |
|
||||
| postcard imports lagoon/attach (35-01 deviation) | judgment | Accepted | resolved: UAT row 10 |
|
||||
|
||||
### Human Verification Required
|
||||
|
||||
UAT rows 3, 4 and 10 stand as human evidence, because the reset, drift and import code they exercised did not change. Rows 1 and 8 were issues whose fixes (35-05..35-07) were never re-tested, even though the gap records were since marked resolved. Rows 2, 5, 6, 7 and 9 passed before the safety check, the Branding save path, the mailer and the layouts changed, so each has a `retest_reason`. For rows 2, 5, 6, 7 and 9 the reason now also covers d6ac0aeb.
|
||||
UAT evidence (Step 8b). `verification.uat-evidence` reports `changed_since_uat: []`, with `recorded_at` 2026-11-15T08:11:21Z. That is the time of the G-35-9 closure note. The human ran the tests before commit 42ab223e (07:57:50Z), though, and the quick commits 1fb42542 and b8487b02 (08:08Z, 08:09Z) changed `templates.go` after that. The verifier therefore checked whether the change bears on any passed row:
|
||||
- The new branch only runs where `Register` would have returned `postcard: unknown layout` before. A configuration that booted during the UAT never reaches it.
|
||||
- `mailer.go` changed only in a comment.
|
||||
- The README and docs changes do not touch runtime code.
|
||||
|
||||
1. **Template list** (UAT 1 re-run, G-35-1).
|
||||
2. **Preview** (UAT 8 scoped re-run, G-35-8): logo or name header, card, button, literal © footer on default and system.
|
||||
3. **Customize and save a template**: re-test (save-time check changed, including the tag reading).
|
||||
4. **Layout editor**: re-test (layout validation changed).
|
||||
5. **Insert image into layout**: re-test (src check rewritten, now read twice).
|
||||
6. **Branding**: re-test of UAT 7.
|
||||
7. **Branding refusal on the demo instance**: script/data names refused with the new en/pl copy; `Online=Shop`, `Data:Lab`, `Big Data: Summit` saved and shown.
|
||||
8. **Send test to me**: re-test (mailer, validateHTML and layouts changed).
|
||||
9. **CR-01, CR-02 (with its residual fix) and WR-02 safety-rule changes**: accept or reject, including the over-refusal risk the tag reading accepts.
|
||||
10. **Inlined mail in a real inbox**: colours survive when the style block is stripped.
|
||||
11. **Judgment-tier prohibitions**: accept or reject.
|
||||
No row's code path changed, so rows 2-12 and 14 stand as human evidence (`human_verified`). Row 1's remaining issue is G-35-9's plugin part, which is deferred above.
|
||||
|
||||
One item remains:
|
||||
|
||||
1. **Inlined mail in a real inbox** (UAT row 13, skipped). Test-send a template in the default layout to a real webmail/Outlook inbox. The button and card should keep their colours with the style block stripped. This needs an instance with working SMTP; the demo uses the log driver. If the developer judges `TestInlineCSS` sufficient, they can record an override for this item instead.
|
||||
|
||||
### Gaps Summary
|
||||
|
||||
No gaps remain. Quick 261114-p5m closed the CR-02 residual at its cause. `unsafeMarkupAt` no longer trusts only the tokenizer's view of where a raw-text element or comment ends. After the existing HTML reading, it reads every tag again with attribute quoting alone deciding where the tag ends. That reading treats raw-text content as tags and recognises no comments, and it applies the same `unsafeAttrs` rules. Each reading is linear, and the existing depth limit bounds the recursion. All eight payloads the previous round reproduced are now refused by `validateHTML`. The layout payloads that would reach a client as live markup are refused by `Editor.Validate` and fall back to the file version at send with inlining on and off. The quick task pinned this with refuse, send, editor and parser-oracle tests. Every regression gate passes.
|
||||
No gaps. Quick 261115-cha delivers the framework half of G-35-9 correctly and in a small change:
|
||||
- A template's `layout` key can now name a layout another plugin owns by its full code.
|
||||
- The change only turns a former boot error into a resolution when the named layout is already registered. Every resolution that worked before is untouched, and the short-alias error text is byte-identical.
|
||||
- party's `Requires()` boot order makes the require-the-owner rule hold in practice.
|
||||
- Tests cover the send, the boot errors, the precedence, overrides, the editor and the Postgres index.
|
||||
- Every earlier truth passes its regression check: vet, the full short suite, the postcard and cabana Docker suites, and all five gate stages including the read-only consumer run.
|
||||
|
||||
The cost of the fix is a documented over-refusal risk: an unbalanced quote in a comment or style element can make later attribute-shaped text count as an attribute. No shipped layout or consumer plugin trips it today. It is part of human item 9.
|
||||
|
||||
All automated checks pass. Status is `human_needed` for the 11 items above.
|
||||
The completed UAT settles every earlier human item except row 13, the real-inbox check, which was skipped for lack of SMTP. Status is `human_needed` for that one item. The mfa plugin's own layout key lives in a separate repository and is deferred by instruction.
|
||||
|
||||
---
|
||||
|
||||
_Verified: 2026-11-14T17:43:56Z_
|
||||
_Verified: 2026-11-16T07:16:15Z_
|
||||
_Verifier: Claude (msd-verifier)_
|
||||
|
||||
Reference in New Issue
Block a user