Commit Graph

1243 Commits

Author SHA1 Message Date
Tom Boucher
d5f2a7ea19 docs: update README and docs/ for v1.27 release
Add documentation for all new v1.27 features:
- 7 new commands (/gsd:fast, /gsd:review, /gsd:plant-seed, /gsd:thread,
  /gsd:add-backlog, /gsd:review-backlog, /gsd:pr-branch)
- Security hardening (security.cjs, prompt guard hook, workflow guard hook)
- Multi-repo workspace support, discussion audit trail, advisor mode
- New config options (research_before_questions, hooks.workflow_guard)
- Updated component counts in ARCHITECTURE.md

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-20 12:21:53 -04:00
Lex Christopherson
47cb2b5c16 1.27.0 2026-03-20 10:08:45 -06:00
Lex Christopherson
0ea6ebe87d docs: update changelog for v1.27.0
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:08:19 -06:00
Lex Christopherson
fb5c190075 docs: update README for v1.27.0
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-20 10:06:03 -06:00
Tom Boucher
51b3eee1ca Merge pull request #1258 from gsd-build/security/prompt-injection-guards
security: prompt injection guards, path traversal prevention, input validation
2026-03-20 11:41:14 -04:00
Tom Boucher
62db008570 security: add prompt injection guards, path traversal prevention, and input validation
Defense-in-depth security hardening for a codebase where markdown files become
LLM system prompts. Adds centralized security module, PreToolUse hook for
injection detection, and CI-ready codebase scan.

New files:
- security.cjs: path traversal prevention, prompt injection scanner/sanitizer,
  safe JSON parsing, field name validation, shell arg validation
- gsd-prompt-guard.js: PreToolUse hook scans .planning/ writes for injection
- security.test.cjs: 62 unit tests for all security functions
- prompt-injection-scan.test.cjs: CI scan of all agent/workflow/command files

Hardened code paths:
- readTextArgOrFile: path traversal guard (--prd, --text-file)
- cmdStateUpdate/Patch: field name validation prevents regex injection
- cmdCommit: sanitizeForPrompt strips invisible chars from commit messages
- gsd-tools --fields: safeJsonParse wraps unprotected JSON.parse
- cmdFrontmatterGet/Set: null byte rejection
- cmdVerifyPathExists: null byte rejection
- install.js: registers prompt guard hook, updates uninstaller

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-20 11:38:26 -04:00
Tom Boucher
5adbba81b2 Merge pull request #1211 from jecanore/feat/advisor-mode-v2
feat: add advisor mode with research-backed discussion
2026-03-20 11:07:56 -04:00
Tom Boucher
122bc0d7c3 Merge pull request #1181 from diegomarino/feat/materialize-new-project-config
feat: materialize full config on new-project initialization
2026-03-20 11:07:09 -04:00
Tom Boucher
2245d6375a Merge pull request #1257 from gsd-build/enhancement/decision-traceability-1243
enhancement(workflow): add decision IDs for discuss-to-plan traceability
2026-03-20 11:05:23 -04:00
Tom Boucher
2418e6c61d Merge pull request #1256 from gsd-build/enhancement/verifier-stub-detection-1244
enhancement(agents): add stub detection to verifier and executor
2026-03-20 11:04:56 -04:00
Tom Boucher
a6afdde460 Merge pull request #1255 from gsd-build/fix/context-monitor-matcher-1246
fix(install): add matcher and timeout to context-monitor hook
2026-03-20 11:04:34 -04:00
Tom Boucher
7b6dc0029d Merge pull request #1254 from gsd-build/fix/stale-hooks-workflow-guard-1249
fix(hooks): add version header to gsd-workflow-guard.js
2026-03-20 11:03:15 -04:00
Tom Boucher
b0e60e9bbd Merge pull request #1253 from gsd-build/fix/commit-docs-gitignore-autodetect-1250
fix(core): auto-detect commit_docs from gitignore in loadConfig
2026-03-20 11:02:51 -04:00
Tom Boucher
71214d13e5 Merge pull request #1252 from gsd-build/fix/init-roadmap-fallback-1238
fix(init): add ROADMAP fallback to plan-phase, execute-phase, and verify-work
2026-03-20 11:02:23 -04:00
Diego Mariño
fb83ada838 merge: resolve conflicts with upstream main (firecrawl + exa_search)
ensureConfigFile(): keep our refactored version that delegates to
buildNewProjectConfig({}) instead of upstream's duplicated logic.

buildNewProjectConfig(): add firecrawl and exa_search API key
detection alongside existing brave_search, matching upstream's
new integrations.
2026-03-20 15:54:58 +01:00
Tom Boucher
0993eb613f enhancement(workflow): add decision IDs for discuss-to-plan traceability (#1243)
Decisions in CONTEXT.md are now numbered (D-01, D-02, etc.) so
downstream agents can reference them and the plan-checker can verify
100% coverage.

Changes:
- templates/context.md: Decisions use **D-XX:** prefix format
- workflows/discuss-phase.md: write_context step numbers decisions
- agents/gsd-planner.md: Self-check verifies decision ID references
  in task actions; tasks reference D-XX IDs for traceability
- agents/gsd-plan-checker.md: Dimension 7 (Context Compliance)
  extracts D-XX IDs and verifies every decision has a task
2026-03-20 10:54:42 -04:00
Tom Boucher
bc1181f554 enhancement(agents): add stub detection to verifier and executor (#1244)
Enhanced gsd-verifier's anti-pattern detection to catch:
- Hardcoded empty data props (={[]}, ={{}}, ={null})
- 'not available' and 'not yet implemented' placeholder text
- Data stub classification guidance (only flag when value flows
  to rendering without a data-fetching path)

Added stub tracking to gsd-executor's summary creation:
- Before writing SUMMARY, scan files for stub patterns
- Document stubs in a '## Known Stubs' section
- Block plan completion if stubs prevent the plan's goal
2026-03-20 10:52:07 -04:00
Tom Boucher
9bf85fb97d fix(install): add matcher and timeout to context-monitor hook (#1246)
The gsd-context-monitor PostToolUse hook was configured without a
matcher or timeout, causing it to fire on every tool use including
Read, Glob, and Grep. When multiple Read calls happen in parallel,
some hook processes failed with errors.

Added matcher: 'Bash|Edit|Write|MultiEdit|Agent|Task' to limit the
hook to tools that actually modify context significantly. Added
timeout: 10 to prevent hangs.

Includes migration logic: existing installations without matcher/timeout
get them added on next /gsd:update.
2026-03-20 10:45:56 -04:00
Tom Boucher
66a639fe6f fix(hooks): add version header to gsd-workflow-guard.js (#1249)
gsd-workflow-guard.js was missing the // gsd-hook-version: {{GSD_VERSION}}
header that all other hook files have. The stale hook detection in
gsd-check-update.js scans all gsd-*.js files for this header and flags
any without it as stale (hookVersion: 'unknown'). This caused a
persistent '⚠ stale hooks — run /gsd:update' warning in the statusline
even on the latest version.

Added the version header to gsd-workflow-guard.js. Running /gsd:update
will reinstall the hook with the correct version stamp.
2026-03-20 10:43:51 -04:00
Tom Boucher
28166e4839 fix(core): auto-detect commit_docs from gitignore in loadConfig (#1250)
loadConfig() defaulted commit_docs to true regardless of whether
.planning/ was gitignored. The documented auto-detection only existed
inside cmdCommit, so init commands returned commit_docs: true even
when .planning/ was in .gitignore. This caused LLM executors to
bypass the cmdCommit gate and re-commit planning files with raw git.

Now loadConfig() checks isGitIgnored(cwd, '.planning/') when no
explicit commit_docs value is set in config.json. If .planning/ is
gitignored, commit_docs defaults to false. An explicit commit_docs
value in config.json is always respected.

Added 5 regression tests covering auto-detection, explicit overrides,
and the no-config-file edge case.
2026-03-20 10:41:42 -04:00
Tom Boucher
1063fdf1ad fix(init): add ROADMAP fallback to plan-phase, execute-phase, and verify-work (#1238)
cmdInitPlanPhase, cmdInitExecutePhase, and cmdInitVerifyWork returned
phase_found: false when the phase existed in ROADMAP.md but no phase
directory had been created yet. This caused workflows to fail silently
after /gsd:new-project, producing directories named null-null.

cmdInitPhaseOp (used by discuss-phase) already had a ROADMAP fallback.
Applied the same pattern to the three missing commands: when
findPhaseInternal returns null, fall back to getRoadmapPhaseInternal
and construct phaseInfo from the ROADMAP entry.

Added 5 regression tests covering:
- plan-phase ROADMAP fallback
- execute-phase ROADMAP fallback
- verify-work ROADMAP fallback
- phase_found false when neither directory nor ROADMAP entry exists
- disk directory preferred over ROADMAP fallback
2026-03-20 10:38:57 -04:00
Tom Boucher
40993dd8b0 Merge pull request #1248 from benzntech/feat/exa-firecrawl-research
feat: add Exa and Firecrawl MCP support for research agents
2026-03-20 10:20:42 -04:00
Tom Boucher
1d5233a21b Merge pull request #1237 from Disaster-Terminator/fix-codex-config-crlf-features
fix(codex-config): safely manage codex_hooks in existing configs
2026-03-20 10:18:59 -04:00
Diego Mariño
a1852fef33 fix(tests): add USERPROFILE override for Windows HOME sandboxing
On Windows, os.homedir() reads USERPROFILE instead of HOME. The 6
tests using { HOME: tmpDir } to sandbox ~/.gsd/ lookups failed on
windows-latest because the child process still resolved homedir to
the real user profile.

Pass USERPROFILE alongside HOME in all sandboxed test calls.
2026-03-20 14:56:28 +01:00
Tom Boucher
020e764774 Merge pull request #1247 from salmanmkc/upgrade-github-actions-node24
Upgrade GitHub Actions for Node 24 compatibility
2026-03-20 08:39:19 -04:00
Diego Mariño
2d8e3b4791 Merge branch 'feat/materialize-new-project-config' of github.com:diegomarino/get-shit-done into feat/materialize-new-project-config 2026-03-20 11:56:41 +01:00
benzntech
b621d556f0 feat: add Exa and Firecrawl MCP support for research agents
Integrate Exa (semantic search) and Firecrawl (deep web scraping) as
MCP-based research tools, following the existing Brave Search pattern.

- Add tool declarations to all 3 researcher agents
- Add tool strategy sections with usage guidance and priority
- Add config detection for FIRECRAWL_API_KEY and EXA_API_KEY env vars
- Add firecrawl/exa_search config keys to core defaults and init output
- Update source priority hierarchy across all researchers
2026-03-20 14:53:46 +05:30
Salman Muin Kayser Chishti
d673283cb1 Upgrade GitHub Actions for Node 24 compatibility
Signed-off-by: Salman Muin Kayser Chishti <13schishti@gmail.com>
2026-03-20 09:17:40 +00:00
Disaster-Terminator
b6a49163ea fix(codex-config): preserve EOL when enabling codex hooks 2026-03-20 13:24:19 +08:00
Flo Kempenich
f12a40015e fix(stats): replace undefined $GSD_TOOLS with standard gsd-tools path (#1236)
The stats workflow was the only file using $GSD_TOOLS, which is never
defined anywhere. This caused the LLM to improvise the path at runtime,
producing the wrong directory (tools/) and extension (.mjs) instead of
the correct bin/gsd-tools.cjs used by all other workflows.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-19 23:23:13 -06:00
jecanore
24626ad320 docs: add advisor mode entry to CHANGELOG.md
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-19 20:09:10 -05:00
jecanore
86c10b4cea test: update agent count for new gsd-advisor-researcher agent 2026-03-19 20:08:50 -05:00
jecanore
a6dd641599 feat: add advisor mode with research-backed discussion
Adds an optional advisor mode to discuss-phase that provides research-backed
comparison tables before asking users to make decisions. Activates when
USER-PROFILE.md exists, degrades gracefully otherwise.

New agent: gsd-advisor-researcher -- spawned in parallel per gray area,
returns structured 5-column comparison tables calibrated to the user vendor
philosophy preference (full_maturity/standard/minimal_decisive).

Workflow changes (discuss-phase.md):
- Advisor mode detection in analyze_phase step
- New advisor_research step spawns parallel research agents
- Table-first discussion flow in discuss_areas when advisor mode active
- Standard conversational flow unchanged when advisor mode inactive
2026-03-19 20:08:30 -05:00
Diego Mariño
fd2a80675a merge: resolve conflicts with upstream main
VALID_CONFIG_KEYS: merge our additions (workflow.auto_advance,
workflow.node_repair, workflow.node_repair_budget, hooks.context_warnings)
with upstream's additions (workflow.text_mode, git.quick_branch_template).

ensureConfigFile(): keep our refactored version that delegates to
buildNewProjectConfig({}) instead of upstream's duplicated logic.

buildNewProjectConfig(): add git.quick_branch_template: null and
workflow.text_mode: false to match upstream's new keys.

new-project.md: integrate upstream's Step 5.1 Sub-Repo Detection
after our commit block; drop upstream's duplicate Note (ours at
line 493 is more detailed).
2026-03-19 22:48:21 +01:00
Tom Boucher
d213bdcaa2 Merge pull request #1191 from eli-herman/feat/runtime-state-inventory 2026-03-19 17:28:33 -04:00
Tom Boucher
e79a6f4e92 Merge pull request #1213 from skoduri-epic/feat/multi-repo-workspace-v2 2026-03-19 17:26:18 -04:00
Srinivas Koduri
32c6d880bf fix: address maintainer review — gate findProjectRoot, warn on unmatched files
1. Gate findProjectRoot to commands that access .planning/ — skip for
   pure-utility commands (generate-slug, current-timestamp, template,
   frontmatter, verify-path-exists, verify-summary) to avoid unnecessary
   filesystem traversal on every invocation.

2. Warn to stderr when commit-to-subrepo encounters files that don't
   match any configured sub-repo prefix.

3. Document that loadConfig auto-syncs sub_repos with the filesystem,
   so config.json may be rewritten when repos are added or removed.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-19 12:19:00 -07:00
Srinivas Koduri
fd0d546484 fix(new-project): remove invalid commit step for multi-repo config
The workflow set commit_docs to false for multi-repo workspaces then
immediately ran gsd-tools commit on config.json, which would be
skipped. Replace with a note that config changes are local-only.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-19 12:18:20 -07:00
Srinivas Koduri
99b239dbaf fix(executor): record per-repo commit hashes in multi-repo mode
The hash recording step used `git rev-parse --short HEAD` which fails
when the project root is not a git repo (multi-repo workspaces). Update
the protocol to extract hashes from commit-to-subrepo JSON output and
record all sub-repo hashes in the SUMMARY.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-19 12:18:20 -07:00
Srinivas Koduri
d0aae7b63c fix: address PR review — nested path resolution, sub_repos in init, depth-1 detection
- findProjectRoot: use isInsideGitRepo() to walk up and find .git in
  ancestor dirs, fixing nested paths like backend/src/modules/
- Add sub_repos to cmdInitExecutePhase output so execute-plan.md and
  gsd-executor.md can route commits correctly
- Align new-project.md sub-repo detection to maxdepth 1 matching
  detectSubRepos() behavior
- Add 3 nested path tests for .git heuristic, sub_repos, and multiRepo

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-19 12:18:20 -07:00
Srinivas Koduri
21081dc821 feat: multi-repo workspace support with auto-detection and project root resolution
Add support for workspaces with multiple independent git repositories.
When configured, GSD routes commits to the correct sub-repo and ensures
.planning/ stays at the project root.

Core features:
- detectSubRepos(): scans child directories for .git to discover repos
- findProjectRoot(): walks up from CWD to find the project root that
  owns .planning/, preventing orphaned .planning/ in sub-repos
- loadConfig auto-syncs sub_repos when repos are added or removed
- Migrates legacy "multiRepo: true" to sub_repos array automatically
- All init commands include project_root in output
- cmdCommitToSubrepo: groups files by sub-repo prefix, commits independently

Zero impact on single-repo workflows — sub_repos defaults to empty array.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-19 12:18:20 -07:00
Tom Boucher
1f08939eb5 Merge pull request #1234 from trek-e/refactor/state-field-helpers-and-test-standardization
refactor: consolidate STATE.md field helpers, fix command injection in isGitIgnored
2026-03-19 15:10:36 -04:00
Tom Boucher
3e2c85e6fd refactor: consolidate STATE.md field helpers, fix command injection in isGitIgnored
Refactoring:
- Extract stateReplaceFieldWithFallback() to state.cjs as single source of truth
  for the try-primary-then-fallback pattern that was duplicated inline across
  phase.cjs, milestone.cjs, and state.cjs
- Replace all inline bold-only regex patterns in cmdPhaseComplete with shared
  stateReplaceField/stateExtractField helpers — now supports both **Bold:**
  and plain Field: STATE.md formats (fixes the same bug as #924)
- Replace inline bold-only regex patterns in cmdMilestoneComplete with shared helpers
- Replace inline bold-only regex for Completed Phases/Total Phases/Progress
  counters in cmdPhaseComplete with stateExtractField/stateReplaceField
- Replace inline bold-only Total Phases regex in cmdPhaseRemove with shared helpers

Security:
- Fix command injection surface in isGitIgnored (core.cjs): replace execSync with
  string concatenation with execFileSync using array arguments — prevents shell
  interpretation of special characters in file paths

Tests (7 new):
- 5 tests for stateReplaceFieldWithFallback: primary field, fallback, neither,
  preference, and plain format
- 1 regression test: phase complete with plain-format STATE.md fields
- 1 regression test: milestone complete with plain-format STATE.md fields

854 tests pass (was 847). No behavioral regressions.
2026-03-19 15:05:20 -04:00
Tom Boucher
4a8e1fef10 Merge pull request #1225 from trek-e/feat/worktree-support-1215
feat(core): worktree-aware .planning/ resolution and file locking
2026-03-19 13:46:31 -04:00
Tom Boucher
0afffb15f5 feat(core): worktree-aware .planning/ resolution and file locking (#1215)
- Add resolveWorktreeRoot() that detects linked worktrees via
  git rev-parse --git-common-dir and resolves to the main worktree
  where .planning/ lives
- Add withPlanningLock() file-based locking mechanism to prevent
  concurrent worktrees from corrupting shared planning files
- Wire worktree root resolution into gsd-tools.cjs main entry point
- Add regression tests for resolveWorktreeRoot (non-git, normal repo)
  and withPlanningLock (normal execution, error cleanup, stale lock
  recovery)
2026-03-19 13:41:11 -04:00
Tom Boucher
d585612afa Merge pull request #1229 from tonymfer/fix/commit-stage-deletions
fix(commit): stage file deletions when passed non-existent paths
2026-03-19 13:01:06 -04:00
Tom Boucher
78fa8f4052 Merge pull request #1224 from trek-e/feat/discussion-log-1209
feat(discuss-phase): auto-generate DISCUSSION-LOG.md audit trail
2026-03-19 13:00:13 -04:00
Tom Boucher
44e141c043 Merge pull request #1218 from j2h4u/fix/one-liner-extraction
fix(lifecycle): extract one-liner from summary body when not in frontmatter
2026-03-19 12:59:52 -04:00
Tom Boucher
aa29c46ca6 Merge pull request #947 from j2h4u/fix/state-advance-plan-compound
fix(state): parse compound Plan field in advance-plan command
2026-03-19 12:59:18 -04:00
Tom Boucher
6d7f9e35e5 Merge pull request #923 from j2h4u/fix/progress-table-columns
fix(roadmap): handle 5-column progress tables with Milestone column
2026-03-19 12:58:47 -04:00