Commit Graph

2487 Commits

Author SHA1 Message Date
Jakub Zych
8c03cc3621 feat(docsite): require src= on Go code blocks of module READMEs (quick-261118-qsd) 2026-11-18 20:18:38 +01:00
Jakub Zych
1e56d750ef docs(lighthouse,postcard,signpost): compile README Go examples via src= (quick-261118-qsd) 2026-11-18 20:13:14 +01:00
Jakub Zych
a2551d83d7 docs(pact,party,surf): compile README Go examples via src= (quick-261118-qsd) 2026-11-18 20:07:39 +01:00
Jakub Zych
cd55a3980d docs(pier,seaglass,sunrise,sunscreen,tide): compile README Go examples via src= (quick-261118-qsd) 2026-11-18 20:04:47 +01:00
Jakub Zych
6409837b0c docs(phrasebook,sieve,towel,wire,wristband): compile README Go examples via src= (quick-261118-qsd) 2026-11-18 20:01:05 +01:00
Jakub Zych
c517db564c docs(flare,kiosk,lagoon): compile README Go examples via src= (quick-261118-qsd)
- flare: send region run by TestDocsNotifyReply against a loopback TLS push
  service; blogSubscriptions and the publish-source region run by
  TestDocsSubscriptionSource on a Postgres container (skips under -short)
- kiosk: write, newest and client regions run by TestDocsWriteManifest (a
  copy of the literal fixture), ExampleVersionsResponse and
  TestDocsBlogReleases (httptest registry); the CheckT fence reuses
  TestPluginManifest
- lagoon: new open region run by TestDocsOpenFromApp (DocsDSN added to
  export_docs_test.go); the model, create-post, on-database, publish and
  migrations fences reuse the Database pages' targets
2026-11-18 19:53:27 +01:00
Jakub Zych
d04454c57b docs(cooler,diary,festival,fetchguard): compile README Go examples via src= (quick-261118-qsd)
- cooler: ExampleFromApp and the articlesController purge declarations;
  AllowExport run by TestDocsAllowExport on miniredis
- diary: blogLog and ExampleFor; the generated main's run function, run by
  TestDocsRun in a temp directory with diary.Reset on cleanup
- festival: PostPublished/ExampleBus_Fire and PostFormExtended/Collected/
  ExampleBus_Collect, with a TestDocsDeclarations for Collected
- fetchguard: fetch region run by TestDocsFetchImage (loopback refused as
  private_ip), client region run by TestDocsSyncItems on a stub transport
2026-11-18 19:48:01 +01:00
Jakub Zych
becb31fbef docs(cabana,compass,conga): compile README Go examples via src= (quick-261118-qsd)
- cabana: the hand-written controller fence points at Post, PostsController
  and BlogPlugin declarations; TestDocsDeclarations now calls each of them
- compass: mailSettings and ExampleOpen; the YAML block matches the
  directory ExampleOpen writes
- conga: job, dispatch and progress fences reuse the Jobs page targets; new
  reindex and worker regions run in TestDocsDispatch (Docker), and the
  schedule fence is FeedPlugin.Schedule, checked by TestDocsSchedule
2026-11-18 19:44:21 +01:00
Jakub Zych
a0f5b5e561 docs(backpack,beachcomber,boardwalk,bonfire,bouncer): compile README Go examples via src= (quick-261118-qsd)
- backpack: Greeter and ExampleApp_Publish replace the whole-file fence
- beachcomber: Post's Searchable methods plus a new SearchIndexSchema, a
  Plugin.Boot that installs the gate, and the existing gate/search regions
- boardwalk: new example_test.go; the mount region runs in ExampleHandler
- bonfire: importPostsCommand and acmeMain (the binary's main as a function
  returning the exit code), run by ExampleExecute; ExampleCatalog_Has
- bouncer: users/FindByID and ExampleNewJWTGuard; RefreshRoute run by
  TestDocsRefreshRoute on a production compass config
2026-11-18 19:39:50 +01:00
Jakub Zych
48527e4206 docs(breakwater): compile README Go examples via src= (quick-261118-qsd)
- the Usage fence becomes two src= references to ExampleRender and
  ExamplePurify, filled by summer docs:sync
- the Phase 11.1 SC4 acceptance scan now allows top-level src= fences
  in module READMEs (nested ones are still refused) and expects the
  api/<name> pages to caption them like docs/ pages
2026-11-18 19:32:11 +01:00
Jakub Zych
721830c502 feat(docsite): check, caption and sync src= blocks in module READMEs (quick-261118-qsd)
- checkSnippets compares top-level src= fences of module READMEs like
  docs/ pages; the README src= refusal is gone
- Sync also rewrites drifted src= fences in modules/<name>/README.md,
  still all-or-nothing across pages and READMEs
- fenceAnnotator captions top-level src= fences on every page
- the snippet-readme-src planted violation now plants a drifted README
  fence instead of the old refusal
- utilities.md, README.md and CLAUDE.md describe src= in module READMEs
2026-11-18 19:29:36 +01:00
Jakub Zych
830f305376 style: gofmt cabana mail routes and postcard store test 2026-11-18 18:42:59 +01:00
Jakub Zych
66ec8de315 docs(quick-261118-lbt): per-app plugin instances, closable limiter store, one router build 2026-11-18 15:50:11 +01:00
Jakub Zych
38f7f3a777 feat(surf): AssembleRouter builds the router and handler once; the router stops the MCP endpoint it mounted (quick-261118-lbt)
- surf.AssembleRouter returns the router and the compiled handler from
  one build, so an mcp.enabled app is not built twice; Assemble keeps
  its signature and is implemented on top of it
- serve uses AssembleRouter with a deferred Router.Close
- pier.Pier.Close stops the session reaper and the Redis warm-up; the
  router that mounted the endpoint owns it
- ExampleAssembleRouter, routing/testing docs and the surf/pier READMEs
2026-11-18 15:44:56 +01:00
Jakub Zych
d9e21ad019 fix(surf): close the rate-limit store a router created (quick-261118-lbt)
- MemoryStore.Close stops the sweep goroutine; Attempt keeps working
- Router.Close runs what the router owns (the fallback MemoryStore of
  BuildRouter), never a store published on the app
- BuildRouter closes the router on every error return
- serve closes its router and installCooler's fallback store on exit;
  route:list closes its router
- README and rate-limiting docs describe the ownership
2026-11-18 15:41:05 +01:00
Jakub Zych
ea1befdd6c feat(party): give every application its own plugin instances (quick-261118-lbt)
- Register keeps a pristine shallow copy of each pointer-to-struct plugin;
  every Activate hands its application a fresh copy, so a second
  application no longer rebinds the first one's plugins
- value plugins and pointers to non-struct types are used as is
- party.RegisterFactory for plugins whose init builds maps or pointers
- activate() and its tests are unchanged
- README and plugin/lifecycle docs describe the per-application rule
2026-11-18 15:37:06 +01:00
Jakub Zych
4d3b1e9f62 docs(phase-35): complete phase - UAT 14/14 (real-inbox check passed, G-35-9 framework part resolved) v0.6.5 2026-11-16 10:05:23 +01:00
Jakub Zych
0c24e0e656 test(35): re-verify after quick 261115-cha - 23/23 truths, human_needed (inbox check) 2026-11-16 08:19:09 +01:00
Jakub Zych
419e41fee5 test(35): note G-35-9 framework part closed by quick 261115-cha 2026-11-15 09:11:21 +01:00
Jakub Zych
ed17833ab7 docs(quick-261115-cha): let a mail template use another plugin's layout by full code 2026-11-15 09:11:11 +01:00
Jakub Zych
b8487b028b test(quick-261115-cha): cover cross-plugin mail layouts through overrides, the editor and the index
- TestCrossPluginLayoutOverride: a template override naming the lender's
  layout, a customized lender layout, Editor Validate and Preview
- TestCrossPluginLayoutSync (Docker): SyncIndex points the borrower rows'
  layout_id at the lender's layout row and keeps it on a second run
2026-11-15 09:09:58 +01:00
Jakub Zych
1fb4254291 feat(quick-261115-cha): let a mail template use another plugin's layout by full code
- resolveLayoutLocked: after the plugin's own alias and the built-in
  aliases, a full layout name already in the catalog resolves to itself;
  an unregistered full name fails with a require-the-owner hint
- another plugin's short alias and the short-alias error are unchanged
- TestCrossPluginLayout covers register, send, errors and precedence
- postcard README and docs/services/mail.md describe the rule
2026-11-15 09:08:21 +01:00
Jakub Zych
42ab223e79 test(35): complete UAT - 12 passed, 1 issue 2026-11-15 08:57:50 +01:00
Jakub Zych
358da17aeb docs(quick-261114-p5n): style the user and paymentgateway plugin mail layouts 2026-11-14 18:48:31 +01:00
Jakub Zych
4ef3aa1f90 test(35): seed UAT re-test rows after re-verification 2026-11-14 18:46:48 +01:00
Jakub Zych
3541c9bda3 docs(35): re-verify after quick 261114-p5m - all automated checks pass, human verification needed 2026-11-14 18:46:33 +01:00
Jakub Zych
5735e7c7d5 test(35): reconcile UAT gaps G-35-1 and G-35-8 as resolved by 35-07 2026-11-14 18:38:19 +01:00
Jakub Zych
8fabf87b8a docs(quick-261114-p5m): fix CR-02 residual quoted end tags in the mail URL check 2026-11-14 18:38:18 +01:00
Jakub Zych
f1f284a0f9 test(quick-261114-p5m): pin end tags inside quoted attributes in the mail URL check
- refuse cases for all eight probe payloads (noscript href and handler,
  svg style, title and textarea, noembed, xmp, conditional comment)
- send fallback and editor refusal for the three that survive rendering
- escaped_send subtests check svg title/textarea sends with an x/net/html
  parser oracle, scripting on and off
- accept cases for conditional comments, quoted CSS, a safe noscript
  link and a literal comment opener in an attribute
2026-11-14 18:37:08 +01:00
Jakub Zych
e47d4ae6cf docs(quick-261114-p5m): amend the mail URL scheme note for quoted end tags 2026-11-14 18:25:32 +01:00
Jakub Zych
d6ac0aeb4b fix(quick-261114-p5m): read tags across raw-text and comment ends in the mail URL check
- unsafeMarkupAt runs the existing HTML reading, then a tag reading in
  which attribute quoting alone decides where a tag ends
  (NextIsNotRawText after raw-text start tags, comment openers blanked)
- both readings share unsafeAttrs; existing refusals keep their message
  and snippet
- svg/style end tag inside a quoted attribute is refused at check, save
  and send; README and docs/services/mail.md describe the second reading
2026-11-14 18:25:13 +01:00
Jakub Zych
d8137c17d4 docs(35): align disposition frontmatter with fixed CR-01, CR-02, WR-01 2026-11-14 18:01:43 +01:00
Jakub Zych
c1e8e57e29 docs(35): re-verify after review fixes - CR-02 quoted end-tag residual open 2026-11-14 18:01:32 +01:00
Jakub Zych
7bd0eaaaee docs(35): shorten COVERAGE.md opt-out reason to pass the api-coverage gate 2026-11-14 17:52:00 +01:00
Jakub Zych
35c4081529 docs(35): reconcile disposition for re-titled CR-01, CR-02, WR-01 fixes 2026-11-14 17:47:41 +01:00
Jakub Zych
b729a8a605 docs(35): record code review disposition 2026-11-14 17:46:28 +01:00
Jakub Zych
73843dbf26 docs(35): add code review fix report 2026-11-14 17:46:27 +01:00
Jakub Zych
1d2e7e87fa docs(35): amend the mail URL scheme check note for the review fixes 2026-11-14 17:40:46 +01:00
Jakub Zych
8deb56ff0b fix(35): WR-03 treat data: in a site name as a data URL only with ; or ,
scriptURLText took data: followed by any non-space character as a data
URL, so names such as Data:Lab, Big Data:Summit and data:Science were
refused on the Branding form and dropped from mail, contrary to the docs.
A data URL now needs its optional MIME type and the ; or , every data URL
has. javascript: and vbscript: keep matching with whitespace after the
colon, since such a URL still runs.
2026-11-14 17:40:13 +01:00
Jakub Zych
31de2ff90f fix(35): WR-02 drop the whole-document event-handler regex
validateHTML ran (?i)\son[a-z]+\s*= over the rendered document, text
included, so a variable such as "buy one = get one free" stopped its own
message, and it is what made Online=Shop in the footer a send failure.
The tokenizer walk refuses every on* attribute, and since CR-02 it also
reads raw-text element and comment content as markup, so the regex is
dropped. Text shaped like a handler is now sent; such site names are shown
and saved, and the Branding refusal copy no longer mentions onclick=.
2026-11-14 17:37:52 +01:00
Jakub Zych
baba524caf fix(35): WR-01 strip whitespace before the list, meta, CSS and comment scheme checks
Single-URL attributes removed ASCII whitespace and control characters
before looking for a scheme, the list-valued, meta content, style and
comment checks did not, so values="java&#9;script:..." and a tab-split
meta refresh passed. The stripping is factored out as stripURLSpace and
used by every scheme check.
2026-11-14 17:32:14 +01:00
Jakub Zych
1d481bb02d fix(35): CR-02 check raw-text element and comment content as markup
The tokenizer-only walk read noscript, title, textarea, style, xmp and the
other raw-text elements as one text token and never looked inside, so an
unencoded javascript: link in <noscript> or <svg><title> passed the check
and was sent. A mail client renders with scripting off and parses svg
children as markup, so the raw content of those elements, and comment
data (Outlook conditional comments), is now checked again as markup;
nesting deeper than eight levels is refused.
2026-11-14 17:30:07 +01:00
Jakub Zych
2dbee30530 fix(35): CR-01 check the site name where the layouts print it
UnsafeText checked the escaped name on its own, so a name starting with
on<letters>= (Online=Shop, onboarding=team) passed, was saved, and then
failed every default/system-layout send once the footer printed it after
"© <year> ". The name is now checked in the footer, header span and alt
contexts, so such a name is dropped at render and refused on the Branding
form instead of stopping mail.
2026-11-14 17:25:53 +01:00
Jakub Zych
980ba48764 docs(35): re-verify after gap closure 35-08/35-09 - CR-01 residual and CR-02 open 2026-11-14 16:26:50 +01:00
Jakub Zych
9195bc4822 docs(35): record code review disposition 2026-11-14 16:18:30 +01:00
Jakub Zych
f1d22353ca docs(35): re-review gap closure - CR-01 residual and scheme-check bypass found 2026-11-14 16:18:18 +01:00
Jakub Zych
9ff6e1a2e8 docs(35-09): record plan completion in state and roadmap 2026-11-14 16:09:00 +01:00
Jakub Zych
dce002ee45 docs(35-09): complete site name safety unit tests plan 2026-11-14 16:08:01 +01:00
Jakub Zych
fbbfce0702 docs(35): validation map for the site name safety gap
- CR-01 rows for the send path, the decoded scheme check and the admin side;
  WR-01 and WR-05 rows with their go test commands
- CR-01 status replaces the open item on the Branding site name
- Manual-Only row for the Branding refusal on sm-demo-app; Wave 0 lists the
  three new test files
2026-11-14 16:06:59 +01:00
Jakub Zych
e54be76cf0 test(35): self-test compares the planted consumer's go.mod
- the workspace-modfile case copies the planted consumer's go.mod before the
  modfile run and compares it after with cmp -s (IN-03)
- drops the git status check on the dirty-sibling fixture, which asserted
  against the wrong repository; the replace-line grep stays
2026-11-14 16:00:23 +01:00